Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35581 META: tasks related to RTL theme fixes before 2.4 freeze (Week 39)
  3. MDL-35250

Right align all TABs in all TinyMCE dialogs, when in RTL mode

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.3.1, Future Dev
    • Fix Version/s: STABLE backlog
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Add one RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home ► Site administration ► Language ► Language packs)
      2. Switch to Hebrew language (on Moodle's front page)
      3. Navigate to any page that display a TinyMCE editor ( ex. the "Description" element inside a user's profile page . OR start a new discussion on a Forum page )
      4. Click the "Add new Image" button, inside the TinyMCE editor.
      5. Validate that the Tabs you see in the pop up dialog are all left aligned (as shown in the attached image to this issue)
      6. Apply the patch
      7. Switch to Design Mode (Home ► Site administration ► Appearance ► Themes ► Theme settings)
        You might also need to set JavaScript cache to OFF. I added the following lines of code to my config.php file:

         $CFG->themedesignermode = 1; $CFG->cachejs = false; 

        Clear theme cache (Home ► Site administration ► Appearance ► Themes ► Theme selector)
        Or even:
        Purge all caches (Home ► Site administration ► Development ► Purge all caches)

      8. "Refresh" (CTRL-R / F5) the page you were viewing and make sure you see the problematic UI element... gone (Solved)
      Show
      Add one RTL language package (Hebrew or Arabic or Farsi...) to Moodle (Home ► Site administration ► Language ► Language packs) Switch to Hebrew language (on Moodle's front page) Navigate to any page that display a TinyMCE editor ( ex. the "Description" element inside a user's profile page . OR start a new discussion on a Forum page ) Click the "Add new Image" button, inside the TinyMCE editor. Validate that the Tabs you see in the pop up dialog are all left aligned (as shown in the attached image to this issue) Apply the patch Switch to Design Mode (Home ► Site administration ► Appearance ► Themes ► Theme settings) You might also need to set JavaScript cache to OFF. I added the following lines of code to my config.php file: $CFG->themedesignermode = 1; $CFG->cachejs = false; Clear theme cache (Home ► Site administration ► Appearance ► Themes ► Theme selector) Or even: Purge all caches (Home ► Site administration ► Development ► Purge all caches) "Refresh" (CTRL-R / F5) the page you were viewing and make sure you see the problematic UI element... gone (Solved)
    • Affected Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      WIP-MDL-35250-master

      Description

      Right align all TABs in all TinyMCE dialogs, when in RTL mode

      Insert Image dialog
      Insert Link dialog
      Insert Multimedia dialog

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              nadavkav Nadav Kavalerchik
              Reporter:
              nadavkav Nadav Kavalerchik
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Participants:
              Component watchers:
              Bas Brands, Mathew May
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated: