Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.4
    • Component/s: Installation, Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Backup your current config.php file and then remove it from Moodle's main folder (or just rename it)
      2. Start a "new" Moodle install process by navigating your browser to your previously installed Moodle URL (or just Reload the page)
      3. "Install" process should start. and you should choose "Hebrew" as the installation language.
      4. If you have not applied the patch yet, you should see the INPUT UI elements aligned to the right on each page, when clicking "next" button for the following 3 pages.
      5. Apply the patch. Go Back to the beginning of the install process and make sure the 3 first pages of the install process are all left justified. Header are right aligned. Input text-boxes' labels are right aligned. The last page, generated "config.php" file is left justified and left aligned.

      Show
      1. Backup your current config.php file and then remove it from Moodle's main folder (or just rename it) 2. Start a "new" Moodle install process by navigating your browser to your previously installed Moodle URL (or just Reload the page) 3. "Install" process should start. and you should choose "Hebrew" as the installation language. 4. If you have not applied the patch yet, you should see the INPUT UI elements aligned to the right on each page, when clicking "next" button for the following 3 pages. 5. Apply the patch. Go Back to the beginning of the install process and make sure the 3 first pages of the install process are all left justified. Header are right aligned. Input text-boxes' labels are right aligned. The last page, generated "config.php" file is left justified and left aligned.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      WIP-MDL-35275
    • Rank:
      43930

      Description

      Left align INPUT boxes and TEXT boxes during Install process, when in RTL mode

      Folder, Files and URL text boxes should always be aligned to the left, in all languages.

        Activity

        Hide
        Dan Poltawski added a comment -

        Thanks Nadav, i've integrated this to 2.4

        Show
        Dan Poltawski added a comment - Thanks Nadav, i've integrated this to 2.4
        Hide
        Dan Poltawski added a comment -

        Tested during integration and looks good!

        Show
        Dan Poltawski added a comment - Tested during integration and looks good!
        Hide
        Dan Poltawski added a comment -

        Congratulations, you've done it!

        Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

        Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

        Show
        Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.
        Hide
        Mary Evans added a comment - - edited

        @Nadav

        This has caused a regression in Sky-High theme page-header!
        And totally breaks Formal White outer frame too.

        html[dir=rtl] #page-header {float: right;}
        Show
        Mary Evans added a comment - - edited @Nadav This has caused a regression in Sky-High theme page-header! And totally breaks Formal White outer frame too. html[dir=rtl] #page-header { float : right;}
        Hide
        Nadav Kavalerchik added a comment -

        @Mary

        I was testing it only on "Standard" theme. and not all the other themes.
        Actually, I am not sure how to test it on other themes...

        Anyways, do you have a fix for that?

        Show
        Nadav Kavalerchik added a comment - @Mary I was testing it only on "Standard" theme. and not all the other themes. Actually, I am not sure how to test it on other themes... Anyways, do you have a fix for that?
        Hide
        Mary Evans added a comment -

        The repercussions of this in all themes could be dramatic, I only found it by chance last night when testing the menu in RTL. I'll take another look at it today, as it may be something else that's causing it.

        Show
        Mary Evans added a comment - The repercussions of this in all themes could be dramatic, I only found it by chance last night when testing the menu in RTL. I'll take another look at it today, as it may be something else that's causing it.
        Hide
        Mary Evans added a comment -

        @Nadav,

        I have fixes for both Sky High and Formal White which I will do shortly.

        The Sky High was result of this RTL fix but was an easy solution. The background page-header image is right positioned, but the page header had no width. Adding width 100% fixed it.

        Formal White was nothing to do with your RTL fix. It is just a design fault with the theme that shows up in RTL mode. Again this is all about widths and floats and margins and paddings.

        So you can rest now, and have a nice day.
        Shalom

        Show
        Mary Evans added a comment - @Nadav, I have fixes for both Sky High and Formal White which I will do shortly. The Sky High was result of this RTL fix but was an easy solution. The background page-header image is right positioned, but the page header had no width. Adding width 100% fixed it. Formal White was nothing to do with your RTL fix. It is just a design fault with the theme that shows up in RTL mode. Again this is all about widths and floats and margins and paddings. So you can rest now, and have a nice day. Shalom
        Hide
        Nadav Kavalerchik added a comment -

        Bless you!!! These are great news

        Show
        Nadav Kavalerchik added a comment - Bless you!!! These are great news
        Hide
        Dan Poltawski added a comment -

        Doh. Mary: can you create a new issue with the fixes?

        Show
        Dan Poltawski added a comment - Doh. Mary: can you create a new issue with the fixes?
        Hide
        Mary Evans added a comment -

        Done MDL-36368

        Show
        Mary Evans added a comment - Done MDL-36368

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: