Moodle
  1. Moodle
  2. MDL-35288

If user drag'n'drops a folder into a course, tell them to try zipping it first

    Details

    • Testing Instructions:
      Hide
      1. (Purge all caches, if a version change hasn't already achieved this)
      2. View a course and turn editing on
      3. Drag and drop a folder onto the course
      4. verify the error message suggests that the user 'zip' the folder before uploading
      Show
      (Purge all caches, if a version change hasn't already achieved this) View a course and turn editing on Drag and drop a folder onto the course verify the error message suggests that the user 'zip' the folder before uploading
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-35288_dndupload_folder_warning
    • Rank:
      43949

      Description

      If a user tries to drag and drop a folder into Moodle, they get an error message that says:

      "Error: The file ..... has no data in it - did you try to upload a folder?"

      However there's already functionality available in Moodle that if you upload a zipped folder, it will ask you what you want to do with it and the default option is to create a folder activity with the unzipped contents of the folder.

      That's really cool functionality, and would be more discoverable if the error message above said something like:

      ""Error: The file is empty or a folder. To upload folders zip them first"

        Activity

        Hide
        Michael de Raadt added a comment -

        That sounds reasonable.

        Davo: I've assigned this to you for consideration. If you're not keen to work on it, please reassign to moodle.com.

        Show
        Michael de Raadt added a comment - That sounds reasonable. Davo: I've assigned this to you for consideration. If you're not keen to work on it, please reassign to moodle.com.
        Hide
        Davo Smith added a comment -

        Sounds like a sensible re-wording of the language string. I'll add a quick patch to change this, but will need a bit of guidance as to whether I need to add an AMOS comment when re-wording a lang string.

        Show
        Davo Smith added a comment - Sounds like a sensible re-wording of the language string. I'll add a quick patch to change this, but will need a bit of guidance as to whether I need to add an AMOS comment when re-wording a lang string.
        Hide
        Sam Hemelryk added a comment -

        Thanks Davo, this has been integrated now.
        Re AMOS it picks up changes like this fine, it only requires help if you are moving, or copying a string (changing its identifier for instance).

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Thanks Davo, this has been integrated now. Re AMOS it picks up changes like this fine, it only requires help if you are moving, or copying a string (changing its identifier for instance). Many thanks Sam
        Hide
        Rossiani Wijaya added a comment -

        Tested this for 2.3 and 2.4.

        It works as expected.

        Test passed.

        Show
        Rossiani Wijaya added a comment - Tested this for 2.3 and 2.4. It works as expected. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        From somewhere within the clouds...

        Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao
        Hide
        zeinab khadem added a comment -

        this problem occures when https enable in site.

        Show
        zeinab khadem added a comment - this problem occures when https enable in site.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: