Details

    • Testing Instructions:
      Hide

      24dev:

      • full QA testing cycle necessary - otherwise:
        • add all possible tinymce buttons to editor toolbars
        • try each button in the toolbar one by one
        • somehow trigger all possible error messages and extra dialogs and look for missing strings
      • test with debug mode on/off, javascript caching on/off and language caching on/off - as many combinations as possible
      • try switching Moodle to different language that has localised TinyMCE strings (de, cs, fr, etc.) and verify the UI is at least partially translated
      • keep JS debug console open in your browser and watch for errors

      2.2.x and 2.3.x:

      • open Moodle page with TinyMCE editor
      • click on special chars button and verify there are instructions at the bottom "use left-righ..."
      Show
      24dev: full QA testing cycle necessary - otherwise: add all possible tinymce buttons to editor toolbars try each button in the toolbar one by one somehow trigger all possible error messages and extra dialogs and look for missing strings test with debug mode on/off, javascript caching on/off and language caching on/off - as many combinations as possible try switching Moodle to different language that has localised TinyMCE strings (de, cs, fr, etc.) and verify the UI is at least partially translated keep JS debug console open in your browser and watch for errors – 2.2.x and 2.3.x: open Moodle page with TinyMCE editor click on special chars button and verify there are instructions at the bottom "use left-righ..."
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w37_MDL-35289_m24_tinymcelangs

      Description

      The text

      {#advanced_dlg.charmap_usage}

      is displayed at the bottom of the "select custom character" popup of the TinyMCE editor. I assume that's supposed to be replaced with some help text.


      There are in fact multiple missing TinyMCE strings in Moodle, the reason is we either download incorrect file or upstream does not maintain it, in anycase it will be better to parse the js lang packs right after each TinyMCE import. And leave the import of other langs to AMOS (skodak)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            David Scotson added a comment -

            I couldn't figure out how to re-open the other bug, so I've cloned it instead, as it seems to have dropped off the radar. See the other bug for more details.

            Show
            David Scotson added a comment - I couldn't figure out how to re-open the other bug, so I've cloned it instead, as it seems to have dropped off the radar. See the other bug for more details.
            Hide
            Petr Skoda added a comment -

            Hello, I am working on a fix. I have updated the title and description a bit, thanks a lot for the report!

            Show
            Petr Skoda added a comment - Hello, I am working on a fix. I have updated the title and description a bit, thanks a lot for the report!
            Hide
            Petr Skoda added a comment -

            Here is a patch, I have decided to do a major TinyMCE string cleanup in master, this should hopefully resolve it once and forever. The changes were too big for stable, so I decided to not waste time backporting it. Thanks again for the report!

            Show
            Petr Skoda added a comment - Here is a patch, I have decided to do a major TinyMCE string cleanup in master, this should hopefully resolve it once and forever. The changes were too big for stable, so I decided to not waste time backporting it. Thanks again for the report!
            Hide
            Petr Skoda added a comment -

            Adding David because this is going to make noise in AMOS...

            Show
            Petr Skoda added a comment - Adding David because this is going to make noise in AMOS...
            Hide
            Petr Skoda added a comment -

            YAY! I have managed to remove all our TinyMCE hacks and I have also added lang caching mechanism, this should significantly simplify future upgrades.

            Show
            Petr Skoda added a comment - YAY! I have managed to remove all our TinyMCE hacks and I have also added lang caching mechanism, this should significantly simplify future upgrades.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated (22, 23 & master), thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 & master), thanks!
            Hide
            Tim Barker added a comment -

            We don't have the capacity to run the QA tests for a single issue.

            Show
            Tim Barker added a comment - We don't have the capacity to run the QA tests for a single issue.
            Hide
            Tim Barker added a comment -

            Rejecting this because of: "full QA testing cycle necessary - this patch should resolve all missing string problems because the strings are now taken directly from JavaScript lang files that are part of the TinMCE distribution"

            There is no way we can do this. Some exploratory testing may be possible. The time-boxed test session starts at 13:30PM WAST. Please let me know if that is acceptable.

            Show
            Tim Barker added a comment - Rejecting this because of: "full QA testing cycle necessary - this patch should resolve all missing string problems because the strings are now taken directly from JavaScript lang files that are part of the TinMCE distribution" There is no way we can do this. Some exploratory testing may be possible. The time-boxed test session starts at 13:30PM WAST. Please let me know if that is acceptable.
            Hide
            Petr Skoda added a comment -

            I do not know what exactly should be tested there, sorry, I have updated the test instructions to include pretty much all functionality of TinyMCE because that is where problems might have been fixed. Please note this patch includes a different TinyMCE build which means that not only missing strings should be looked for, but all the functionality we need should be tested including all custom plugins.

            Show
            Petr Skoda added a comment - I do not know what exactly should be tested there, sorry, I have updated the test instructions to include pretty much all functionality of TinyMCE because that is where problems might have been fixed. Please note this patch includes a different TinyMCE build which means that not only missing strings should be looked for, but all the functionality we need should be tested including all custom plugins.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            (sending this back for testing, based on new instructions availability)

            Show
            Eloy Lafuente (stronk7) added a comment - (sending this back for testing, based on new instructions availability)
            Hide
            Tim Barker added a comment -

            I'll run this shortly!

            Show
            Tim Barker added a comment - I'll run this shortly!
            Hide
            Tim Barker added a comment -

            OK, another problem with the testing instructions:

            Fix Version/s: 2.2.6, 2.3.3

            Testing Instructions:
            24dev

            Why am I testing a fix in 2.4dev when the fix versions are 2.2.6 and 2.3.3?

            If this is a concern over whether this will get tested in 2.4 put qa_test_required flag on it. Is this the case? It's just not very clear to me.

            Show
            Tim Barker added a comment - OK, another problem with the testing instructions: Fix Version/s: 2.2.6, 2.3.3 Testing Instructions: 24dev Why am I testing a fix in 2.4dev when the fix versions are 2.2.6 and 2.3.3? If this is a concern over whether this will get tested in 2.4 put qa_test_required flag on it. Is this the case? It's just not very clear to me.
            Hide
            Petr Skoda added a comment -

            That is the standard way I am afraid. Anyway did you actually test our TinyMCE integration?

            Show
            Petr Skoda added a comment - That is the standard way I am afraid. Anyway did you actually test our TinyMCE integration?
            Hide
            Aparup Banerjee added a comment -

            The patches here have been applied to 2.2.5, 2.3.2 and 2.4dev (master) so testing is required in 22, 23 and master.

            specific to master:
            To test this, imo Petr means that we should test the entire tinymce feature set.
            That is not really possible given time and that we're going to do QA cycles soon anyway after freeze.

            So his alternative test is what i'd go with, ie the tests mentioned after 'otherwise'. Just test his steps and ignore 'full QA cycle testing' for now here. unfortunately we can't afford full QA test atm.

            There's no need for new QA tests either for this MDL, but we may want to note somewhere that we expect somethings in tinymce to possibly go boom due to this and the META during QA cycle.

            Show
            Aparup Banerjee added a comment - The patches here have been applied to 2.2.5, 2.3.2 and 2.4dev (master) so testing is required in 22, 23 and master. specific to master: To test this, imo Petr means that we should test the entire tinymce feature set. That is not really possible given time and that we're going to do QA cycles soon anyway after freeze. So his alternative test is what i'd go with, ie the tests mentioned after 'otherwise'. Just test his steps and ignore 'full QA cycle testing' for now here. unfortunately we can't afford full QA test atm. There's no need for new QA tests either for this MDL, but we may want to note somewhere that we expect somethings in tinymce to possibly go boom due to this and the META during QA cycle.
            Hide
            Aparup Banerjee added a comment -

            resetting for testing for Tim

            Show
            Aparup Banerjee added a comment - resetting for testing for Tim
            Hide
            Aparup Banerjee added a comment -

            actually, i'm not sure of QA tests and if any progress in that area towards auto QA tests. if tinymce is covered maybe that could be run

            Show
            Aparup Banerjee added a comment - actually, i'm not sure of QA tests and if any progress in that area towards auto QA tests. if tinymce is covered maybe that could be run
            Hide
            Tim Barker added a comment -

            OK, apologies for the delays; I wanted to be thorough and ensure I had a good understanding of the expectations here.

            2.2 and 2.3 tests both passed.

            Ran an exploratory session based up 2.4 tests and this was also OK. Good work

            Show
            Tim Barker added a comment - OK, apologies for the delays; I wanted to be thorough and ensure I had a good understanding of the expectations here. 2.2 and 2.3 tests both passed. Ran an exploratory session based up 2.4 tests and this was also OK. Good work
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: