Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35297

Upgrade steps not followed by mdl_book in upgrade to 2.3

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3.3
    • Component/s: Book, Installation
    • Labels:
    • Testing Instructions:
      Hide

      Requirements:

      • Enable debug developer & display errors.
      • This requires access to multiple git repositories and being able to switch branches by the tester.
      • Also, ideally, the ability to perform "site backups" (db & moodledata) is recommended to avoid the manual execution of the "preparing the initial status" section multiple times.

      Preparing the initial status:

      • Install MOODLE_19_STABLE site
      • Clone git://github.com/skodak/moodle-mod_book.git into the site mod/book dir
      • Checkout the MOODLE_19_STABLE branch of mod/book
      • Install mod/book.
      • There is one attached backup file (backup-book-mdl-35297.zip) containing:
      • 1 book activity with image in the intros (pink).
      • 2 chapters and 1 subchapter all them with images too (red, green, blue).
      • Restore, as admin, the backup file into the site, 2 times to new course and 2 times to existing course, so at the end you get at least 2 courses with 2 book activities each. The process ends ok and all the images are in place (the summary and the chapters ones).
      • Note: At this point probably it would be interesting to perform a site backup (database & moodledata) because the points executed until now must be repeated later for other combination of branches/versions.

      The "TESTs CHECK LIST"

      This is the list of things that must be tested at the end of each upgrade combination below:

      1. Edit the settings of any of the book activities.
      2. Without modifying anything, click and press "Save and return to course".
      3. TEST: No error happens and you are redirected to the course page normally.
      4. Visit the 4 books and verify that:
        1. TEST: Each book has 2 chapters and 1 subchapter.
        2. TEST: Each of the chapters/subchapters have one image (red, green, blue).
        3. TEST: The links of the images are served through pluginfile.php (aka they have been moved to proper book file area (mod_book/chapter).
        4. TEST: Manually going to the list of books in a course (http://MOODLEURL/mod/book/index.php?id=COURSEID) shows the intro for all book activities, each one with its "pink" image.
        5. TEST: The "pink" images are also being served through pluginfile.php with proper file area (mod_book/intro).
      5. TEST: Verify the following database columns exist with the detailed specs below:
        1. book->intro, of type text exists
        2. book->introformat, of type integer exists, not null
        3. book->revision, of type integer exists, not null
        4. book->disableprinting does not exist
        5. book->summary does not exist
        6. book_chapters->contentformat, of type integer exists, not null

      Testing 1.9 => 2.2 => 2.4 upgrade.

      • Prepare the initial status (manually or from site backup).
      • Checkout MOODLE_22_STABLE for the site.
      • Checkout MOODLE_20_STABLE for the mod/book.
      • Upgrade the site.
      • TEST: No error happens.
      • Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later).
      • Checkout master for the site.
      • Upgrade the site.
      • TEST: No error happens.
      • Verify the complete "TESTs CHECK LIST" above is passing.

      Testing 1.9 => 2.2 => 2.3 => 2.4 upgrade.

      • Prepare the initial status (manually or from site backup).
      • Checkout MOODLE_22_STABLE for the site.
      • Checkout MOODLE_20_STABLE for the mod/book.
      • Upgrade the site.
      • TEST: No error happens.
      • Delete the mod/book dir.
      • Checkout MOODLE_23_STABLE for the site.
      • Upgrade the site.
      • TEST: No error happens.
      • Verify the complete "TESTs CHECK LIST" above is passing.
      • Checkout master for the site.
      • Upgrade the site.
      • TEST: No error happens.
      • Verify the complete "TESTs CHECK LIST" above is passing.

      And that's all, I think that with these combinations tested we are ensuring that anybody installing 23_STABLE or later will be getting the mod_book upgraded properly. Of course, if you're interested into testing any other combination... you are welcome.

      Ciao

      Show
      Requirements: Enable debug developer & display errors. This requires access to multiple git repositories and being able to switch branches by the tester. Also, ideally, the ability to perform "site backups" (db & moodledata) is recommended to avoid the manual execution of the "preparing the initial status" section multiple times. Preparing the initial status: Install MOODLE_19_STABLE site Clone git://github.com/skodak/moodle-mod_book.git into the site mod/book dir Checkout the MOODLE_19_STABLE branch of mod/book Install mod/book. There is one attached backup file (backup-book-mdl-35297.zip) containing: 1 book activity with image in the intros (pink). 2 chapters and 1 subchapter all them with images too (red, green, blue). Restore, as admin, the backup file into the site, 2 times to new course and 2 times to existing course, so at the end you get at least 2 courses with 2 book activities each. The process ends ok and all the images are in place (the summary and the chapters ones). Note: At this point probably it would be interesting to perform a site backup (database & moodledata) because the points executed until now must be repeated later for other combination of branches/versions. The "TESTs CHECK LIST" This is the list of things that must be tested at the end of each upgrade combination below: Edit the settings of any of the book activities. Without modifying anything, click and press "Save and return to course". TEST: No error happens and you are redirected to the course page normally. Visit the 4 books and verify that: TEST: Each book has 2 chapters and 1 subchapter. TEST: Each of the chapters/subchapters have one image (red, green, blue). TEST: The links of the images are served through pluginfile.php (aka they have been moved to proper book file area (mod_book/chapter). TEST: Manually going to the list of books in a course ( http://MOODLEURL/mod/book/index.php?id=COURSEID ) shows the intro for all book activities, each one with its "pink" image. TEST: The "pink" images are also being served through pluginfile.php with proper file area (mod_book/intro). TEST: Verify the following database columns exist with the detailed specs below: book->intro, of type text exists book->introformat, of type integer exists, not null book->revision, of type integer exists, not null book->disableprinting does not exist book->summary does not exist book_chapters->contentformat, of type integer exists, not null Testing 1.9 => 2.2 => 2.4 upgrade. Prepare the initial status (manually or from site backup). Checkout MOODLE_22_STABLE for the site. Checkout MOODLE_20_STABLE for the mod/book. Upgrade the site. TEST: No error happens. Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later). Checkout master for the site. Upgrade the site. TEST: No error happens. Verify the complete "TESTs CHECK LIST" above is passing. Testing 1.9 => 2.2 => 2.3 => 2.4 upgrade. Prepare the initial status (manually or from site backup). Checkout MOODLE_22_STABLE for the site. Checkout MOODLE_20_STABLE for the mod/book. Upgrade the site. TEST: No error happens. Delete the mod/book dir. Checkout MOODLE_23_STABLE for the site. Upgrade the site. TEST: No error happens. Verify the complete "TESTs CHECK LIST" above is passing. Checkout master for the site. Upgrade the site. TEST: No error happens. Verify the complete "TESTs CHECK LIST" above is passing. And that's all, I think that with these combinations tested we are ensuring that anybody installing 23_STABLE or later will be getting the mod_book upgraded properly. Of course, if you're interested into testing any other combination... you are welcome. Ciao
    • Workaround:
      Hide

      Upgrade to the 2.1 version of the plugin after upgrading to Moodle 2.2 before upgrading to 2.3.

      Show
      Upgrade to the 2.1 version of the plugin after upgrading to Moodle 2.2 before upgrading to 2.3.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Site with Book installed prior to upgrading to Moodle 2.3 throw an error when adding or editing chapters. I compared my upgraded site to a fresh 2.3 and noticed the fresh install had the extra column. The error is:

      Debug info: Unknown column 'revision' in 'field list'
      UPDATE mdl_book SET revision = ? WHERE id = ?
      [array (
      0 => 1,
      1 => '50',
      )]
      Error code: dmlwriteexception
      Stack trace:
       
          line 410 of /lib/dml/moodle_database.php: dml_write_exception thrown
          line 1207 of /lib/dml/mysqli_native_moodle_database.php: call to moodle_database->query_end()
          line 1529 of /lib/dml/moodle_database.php: call to mysqli_native_moodle_database->set_field_select()
          line 100 of /mod/book/edit.php: call to moodle_database->set_field()
       
      Output buffer: Notice: Undefined property: stdClass::$revision in /srv/www/htdocs/mod/book/edit.php on line 100 Notice: Undefined index: revision in /srv/www/htdocs/lib/dml/mysqli_native_moodle_database.php on line 1192

      I added the revision column manually to resolve the issue. Please see http://moodle.org/mod/forum/discuss.php?d=208436.

        Gliffy Diagrams

          Issue Links

            Activity

            rob13 Rob created issue -
            poltawski Dan Poltawski made changes -
            Field Original Value New Value
            URL http://moodle.org/mod/forum/discuss.php?d=208436#unread
            Hide
            salvetore Michael de Raadt added a comment -

            The field is present in Moodle 2.3 when it is installed. The field is also present in the 2.1 version of the plugin. The field is not present in the 2.0 or earlier versions.

            It looks like none of the upgrade rules have been carried over from the plugin to the new version distributed with Moodle. I'm not sure why that is the case.

            The workaround is to upgrade to the 2.1 version of the plugin after the upgrade to Moodle 2.2 before upgrading to 2.3.

            Show
            salvetore Michael de Raadt added a comment - The field is present in Moodle 2.3 when it is installed. The field is also present in the 2.1 version of the plugin. The field is not present in the 2.0 or earlier versions. It looks like none of the upgrade rules have been carried over from the plugin to the new version distributed with Moodle. I'm not sure why that is the case. The workaround is to upgrade to the 2.1 version of the plugin after the upgrade to Moodle 2.2 before upgrading to 2.3.
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Priority Minor [ 4 ] Blocker [ 1 ]
            Description Site with Book installed prior to upgrading to Moodle 2.3 throw an error when adding or editing chapters. I compared my upgraded site to a fresh 2.3 and noticed the fresh install had the extra column. The error is:

            Debug info: Unknown column 'revision' in 'field list'
            UPDATE mdl_book SET revision = ? WHERE id = ?
            [array (
            0 => 1,
            1 => '50',
            )]
            Error code: dmlwriteexception
            Stack trace:

                line 410 of /lib/dml/moodle_database.php: dml_write_exception thrown
                line 1207 of /lib/dml/mysqli_native_moodle_database.php: call to moodle_database->query_end()
                line 1529 of /lib/dml/moodle_database.php: call to mysqli_native_moodle_database->set_field_select()
                line 100 of /mod/book/edit.php: call to moodle_database->set_field()

            Output buffer: Notice: Undefined property: stdClass::$revision in /srv/www/htdocs/mod/book/edit.php on line 100 Notice: Undefined index: revision in /srv/www/htdocs/lib/dml/mysqli_native_moodle_database.php on line 1192

            I added the revision column manually to resolve the issue. Please see http://moodle.org/mod/forum/discuss.php?d=208436.
            Site with Book installed prior to upgrading to Moodle 2.3 throw an error when adding or editing chapters. I compared my upgraded site to a fresh 2.3 and noticed the fresh install had the extra column. The error is:

            {noformat}
            Debug info: Unknown column 'revision' in 'field list'
            UPDATE mdl_book SET revision = ? WHERE id = ?
            [array (
            0 => 1,
            1 => '50',
            )]
            Error code: dmlwriteexception
            Stack trace:

                line 410 of /lib/dml/moodle_database.php: dml_write_exception thrown
                line 1207 of /lib/dml/mysqli_native_moodle_database.php: call to moodle_database->query_end()
                line 1529 of /lib/dml/moodle_database.php: call to mysqli_native_moodle_database->set_field_select()
                line 100 of /mod/book/edit.php: call to moodle_database->set_field()

            Output buffer: Notice: Undefined property: stdClass::$revision in /srv/www/htdocs/mod/book/edit.php on line 100 Notice: Undefined index: revision in /srv/www/htdocs/lib/dml/mysqli_native_moodle_database.php on line 1192
            {noformat}

            I added the revision column manually to resolve the issue. Please see http://moodle.org/mod/forum/discuss.php?d=208436.
            Workaround Upgrade to the 2.1 version of the plugin after upgrading to Moodle 2.2 before upgrading to 2.3.
            Labels triaged
            Assignee moodle.com [ moodle.com ] Petr Škoda (skodak) [ skodak ]
            Component/s Installation [ 10069 ]
            Hide
            skodak Petr Skoda added a comment -

            Hi Michael, this is not my fault, Eloy nuked the old upgrade code - MDL-32709, at present you have to upgrade to my most recent git version when still in Moodle 2.2, otherwise it will break badly.

            Show
            skodak Petr Skoda added a comment - Hi Michael, this is not my fault, Eloy nuked the old upgrade code - MDL-32709 , at present you have to upgrade to my most recent git version when still in Moodle 2.2, otherwise it will break badly.
            skodak Petr Skoda made changes -
            Assignee Petr Škoda (skodak) [ skodak ] Eloy Lafuente (stronk7) [ stronk7 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Crap, when doing the upgrade cleanup (note that 2.3 only can be upgraded from 2.2), I assumed that everybody running the mod_book from contrib would be using the using the last version there.

            But somehow I missed or incorrectly checked the requires = 2011070100 (Moodle 2.1) shared by all branches of the contrib book module, grrr, my fault!

            So the question is... should we be reviving the TWO missed steps (the files conversion one and the revision column one). Is is it safe to assume that the files one has been already performed... looking to versions and requires... it seems it's not really safe.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Crap, when doing the upgrade cleanup (note that 2.3 only can be upgraded from 2.2), I assumed that everybody running the mod_book from contrib would be using the using the last version there. But somehow I missed or incorrectly checked the requires = 2011070100 (Moodle 2.1) shared by all branches of the contrib book module, grrr, my fault! So the question is... should we be reviving the TWO missed steps (the files conversion one and the revision column one). Is is it safe to assume that the files one has been already performed... looking to versions and requires... it seems it's not really safe. Ciao
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Eloy,
            shouldn't we be doing all the steps(not just two?)? because the problem is when somone with moodle 1.9 upgrades to Moodle 2.3 via 2.2 . Am not sure we can assume that any of those upgrade steps would have been applied.

            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Eloy, shouldn't we be doing all the steps(not just two?)? because the problem is when somone with moodle 1.9 upgrades to Moodle 2.3 via 2.2 . Am not sure we can assume that any of those upgrade steps would have been applied. Thanks
            salvetore Michael de Raadt made changes -
            Link This issue is duplicated by MDL-35065 [ MDL-35065 ]
            Hide
            salvetore Michael de Raadt added a comment -

            Yes, there are a few more steps. The linked duplicate issue reports an error with a missing intro field.

            Show
            salvetore Michael de Raadt added a comment - Yes, there are a few more steps. The linked duplicate issue reports an error with a missing intro field.
            salvetore Michael de Raadt made changes -
            Summary Revision column not created in mdl_book in upgrade to 2.3 Upgrade steps not followed by mdl_book in upgrade to 2.3
            Affects Version/s 2.3 [ 10657 ]
            Hide
            rob13 Rob added a comment -

            Somewhere along the upgrade path, the intro field was added on my site that was missing the revision column. I upgraded in summer (northern hemisphere) 2011 from 1.9.7 to 2.1.1. I upgraded the book module then, but I do not remember if it was a version meant for Moodle 2.0 or 2.1. After a year using the 2.1 branch, I upgraded to 2.3.1 via 2.2.4 in July. I did not upgrade any plugins until 2.3.1 was installed. I hope this information helps sort out the issue.

            Show
            rob13 Rob added a comment - Somewhere along the upgrade path, the intro field was added on my site that was missing the revision column. I upgraded in summer (northern hemisphere) 2011 from 1.9.7 to 2.1.1. I upgraded the book module then, but I do not remember if it was a version meant for Moodle 2.0 or 2.1. After a year using the 2.1 branch, I upgraded to 2.3.1 via 2.2.4 in July. I did not upgrade any plugins until 2.3.1 was installed. I hope this information helps sort out the issue.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Thanks for the info, Rob.

            grrr, so we can have sites upgrading from, say, 1.7 to 2.3 (with any number of intermediate steps), missing to upgrade any plugin (book in this case, imagine it is forum, I know it's harder but may happen), and they will end with one cool Moodle 2.3 with some plugins really outdated, producing from small glitches to bad breakages.

            It should be admin responsibility (IMO) to keep plugins upgraded (and we should be warning them like crazy). I hope the new updates api is going to improve this by pushing people to update plugins often really.

            Oki, so the only solution to be 100% in the safe side, is to repeat ALL the previously existing upgrade steps, I'll do it, always checking if they are necessary.

            But, the question is... when is it safe to delete those upgrade steps? Never? Somebody can try to upgrade in 2013 from Moodle 1.9 to 2.5, leading to the same problem. Grrr.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Thanks for the info, Rob. grrr, so we can have sites upgrading from, say, 1.7 to 2.3 (with any number of intermediate steps), missing to upgrade any plugin (book in this case, imagine it is forum, I know it's harder but may happen), and they will end with one cool Moodle 2.3 with some plugins really outdated, producing from small glitches to bad breakages. It should be admin responsibility (IMO) to keep plugins upgraded (and we should be warning them like crazy). I hope the new updates api is going to improve this by pushing people to update plugins often really. Oki, so the only solution to be 100% in the safe side, is to repeat ALL the previously existing upgrade steps, I'll do it, always checking if they are necessary. But, the question is... when is it safe to delete those upgrade steps? Never? Somebody can try to upgrade in 2013 from Moodle 1.9 to 2.5, leading to the same problem. Grrr. Ciao
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Eloy,
            IMHO it is safe to remove upgrade code for a contirb plugin that became part of core only after we gone through a complete requirement cycle.
            Consider following case study
            upto 2.8 requires 2.5
            upto 2.5 requires 2.2

            user is upgrading from 1.9 ->2.8 with a plugin that became part of core in 2.3, but existed as contrib in 1.9
            upto 2.5 we keep full upgrade code
            2.5+ drops all upgrade code

            So user does 1.9->2.2 (no change in plugin)
            2.2->2.5 (Plugin goes through all upgrade required starting from 1.9)
            2.5->2.8 (Plugin goes through all the upgrades added after 2.5)

            So unless we have another Moodle required version blocker (like 2.2 now) we will have to keep all of it I guess.

            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Eloy, IMHO it is safe to remove upgrade code for a contirb plugin that became part of core only after we gone through a complete requirement cycle. Consider following case study upto 2.8 requires 2.5 upto 2.5 requires 2.2 user is upgrading from 1.9 ->2.8 with a plugin that became part of core in 2.3, but existed as contrib in 1.9 upto 2.5 we keep full upgrade code 2.5+ drops all upgrade code So user does 1.9->2.2 (no change in plugin) 2.2->2.5 (Plugin goes through all upgrade required starting from 1.9) 2.5->2.8 (Plugin goes through all the upgrades added after 2.5) So unless we have another Moodle required version blocker (like 2.2 now) we will have to keep all of it I guess. Thanks
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Open [ 1 ] Development in progress [ 3 ]
            ankit_frenz Ankit Agarwal made changes -
            Link This issue will help resolve MDL-35254 [ MDL-35254 ]
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Just to note this has been reported in MDL-35254 as well
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Just to note this has been reported in MDL-35254 as well Thanks
            stronk7 Eloy Lafuente (stronk7) made changes -
            Link This issue will help resolve MDL-35254 [ MDL-35254 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Link This issue is duplicated by MDL-35254 [ MDL-35254 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Testing Instructions h2. Requirements:

            - Enable debug developer & display errors.
            - This requires access to multiple git repositories and being able to switch branches by the tester.
            - Also, ideally, the ability to perform "site backups" (db & moodledata) is recommended to avoid the manual execution of the "preparing the initial status" section multiple times.

            h2. Preparing the initial status:

            - Install MOODLE_19_STABLE site
            - Clone git://github.com/skodak/moodle-mod_book.git into the site mod/book dir
            - Checkout the MOODLE_19_STABLE branch of mod/book
            - Install mod/book.

            - There is one attached backup file (backup-book-mdl-35297.zip) containing:
            - 1 book activity with image in the intros (pink).
            - 2 chapters and 1 subchapter all them with images too (red, green, blue).

            - Restore, as admin, the backup file into the site, 2 times to new course and 2 times to existing course, so at the end you get at least 2 courses with 2 book activities each. The process ends ok and all the images are in place (the summary and the chapters ones).

            - Note: At this point probably it would be interesting to perform a site backup (database & moodledata) because the points executed until now must be repeated later for other combination of branches/versions.

            h2. The "TESTs CHECK LIST"

            This is the list of things that must be tested at the end of each upgrade combination below:

            # Edit the settings of any of the book activities.
            # Without modifying anything, click and press "Save and return to course".
            # TEST: No error happens and you are redirected to the course page normally.
            # Visit the 4 books and verify that:
            ## TEST: Each book has 2 chapters and 1 subchapter.
            ## TEST: Each of the chapters/subchapters have one image (red, green, blue).
            ## TEST: The links of the images are served through pluginfile.php (aka they have been moved to proper book file area (mod_book/chapter).
            ## TEST: Manually going to the list of books in a course (http://MOODLEURL/mod/book/index.php?id=COURSEID) shows the intro for all book activities, each one with its "pink" image.
            ## TEST: The "pink" images are also being served through pluginfile.php with proper file area (mod_book/intro).
            # TEST: Verify the following database columns exist with the detailed specs below:
            ## book->intro, of type text exists
            ## book->introformat, of type integer exists, not null
            ## book->revision, of type integer exists, not null
            ## book->disableprinting does not exist
            ## book->summary does not exist
            ## book_chapters->contentformat, of type integer exists, not null

            h2. Testing 1.9 => 2.2 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_20_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later).
            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            h2. Testing 1.9 => 2.1 => 2.3 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_21_STABLE for the site.
            - Checkout MOODLE_20_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later).
            - Checkout MOODLE_23_STABLE for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.


            h2. Testing 1.9 => 2.2 => 2.3 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_22_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir.
            - Checkout MOODLE_23_STABLE for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            And that's all, I think that with these combinations tested we are ensuring that anybody installing 23_STABLE or later will be getting the mod_book upgraded properly. Of course, if you're interested into testing any other combination... you are welcome.

            Ciao :-)
            stronk7 Eloy Lafuente (stronk7) made changes -
            Attachment backup-book-mdl-35297.zip [ 29823 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Testing Instructions h2. Requirements:

            - Enable debug developer & display errors.
            - This requires access to multiple git repositories and being able to switch branches by the tester.
            - Also, ideally, the ability to perform "site backups" (db & moodledata) is recommended to avoid the manual execution of the "preparing the initial status" section multiple times.

            h2. Preparing the initial status:

            - Install MOODLE_19_STABLE site
            - Clone git://github.com/skodak/moodle-mod_book.git into the site mod/book dir
            - Checkout the MOODLE_19_STABLE branch of mod/book
            - Install mod/book.

            - There is one attached backup file (backup-book-mdl-35297.zip) containing:
            - 1 book activity with image in the intros (pink).
            - 2 chapters and 1 subchapter all them with images too (red, green, blue).

            - Restore, as admin, the backup file into the site, 2 times to new course and 2 times to existing course, so at the end you get at least 2 courses with 2 book activities each. The process ends ok and all the images are in place (the summary and the chapters ones).

            - Note: At this point probably it would be interesting to perform a site backup (database & moodledata) because the points executed until now must be repeated later for other combination of branches/versions.

            h2. The "TESTs CHECK LIST"

            This is the list of things that must be tested at the end of each upgrade combination below:

            # Edit the settings of any of the book activities.
            # Without modifying anything, click and press "Save and return to course".
            # TEST: No error happens and you are redirected to the course page normally.
            # Visit the 4 books and verify that:
            ## TEST: Each book has 2 chapters and 1 subchapter.
            ## TEST: Each of the chapters/subchapters have one image (red, green, blue).
            ## TEST: The links of the images are served through pluginfile.php (aka they have been moved to proper book file area (mod_book/chapter).
            ## TEST: Manually going to the list of books in a course (http://MOODLEURL/mod/book/index.php?id=COURSEID) shows the intro for all book activities, each one with its "pink" image.
            ## TEST: The "pink" images are also being served through pluginfile.php with proper file area (mod_book/intro).
            # TEST: Verify the following database columns exist with the detailed specs below:
            ## book->intro, of type text exists
            ## book->introformat, of type integer exists, not null
            ## book->revision, of type integer exists, not null
            ## book->disableprinting does not exist
            ## book->summary does not exist
            ## book_chapters->contentformat, of type integer exists, not null

            h2. Testing 1.9 => 2.2 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_20_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later).
            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            h2. Testing 1.9 => 2.1 => 2.3 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_21_STABLE for the site.
            - Checkout MOODLE_20_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later).
            - Checkout MOODLE_23_STABLE for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.


            h2. Testing 1.9 => 2.2 => 2.3 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_22_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir.
            - Checkout MOODLE_23_STABLE for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            And that's all, I think that with these combinations tested we are ensuring that anybody installing 23_STABLE or later will be getting the mod_book upgraded properly. Of course, if you're interested into testing any other combination... you are welcome.

            Ciao :-)
            h2. Requirements:

            - Enable debug developer & display errors.
            - This requires access to multiple git repositories and being able to switch branches by the tester.
            - Also, ideally, the ability to perform "site backups" (db & moodledata) is recommended to avoid the manual execution of the "preparing the initial status" section multiple times.

            h2. Preparing the initial status:

            - Install MOODLE_19_STABLE site
            - Clone git://github.com/skodak/moodle-mod_book.git into the site mod/book dir
            - Checkout the MOODLE_19_STABLE branch of mod/book
            - Install mod/book.

            - There is one attached backup file (backup-book-mdl-35297.zip) containing:
            - 1 book activity with image in the intros (pink).
            - 2 chapters and 1 subchapter all them with images too (red, green, blue).

            - Restore, as admin, the backup file into the site, 2 times to new course and 2 times to existing course, so at the end you get at least 2 courses with 2 book activities each. The process ends ok and all the images are in place (the summary and the chapters ones).

            - Note: At this point probably it would be interesting to perform a site backup (database & moodledata) because the points executed until now must be repeated later for other combination of branches/versions.

            h2. The "TESTs CHECK LIST"

            This is the list of things that must be tested at the end of each upgrade combination below:

            # Edit the settings of any of the book activities.
            # Without modifying anything, click and press "Save and return to course".
            # TEST: No error happens and you are redirected to the course page normally.
            # Visit the 4 books and verify that:
            ## TEST: Each book has 2 chapters and 1 subchapter.
            ## TEST: Each of the chapters/subchapters have one image (red, green, blue).
            ## TEST: The links of the images are served through pluginfile.php (aka they have been moved to proper book file area (mod_book/chapter).
            ## TEST: Manually going to the list of books in a course (http://MOODLEURL/mod/book/index.php?id=COURSEID) shows the intro for all book activities, each one with its "pink" image.
            ## TEST: The "pink" images are also being served through pluginfile.php with proper file area (mod_book/intro).
            # TEST: Verify the following database columns exist with the detailed specs below:
            ## book->intro, of type text exists
            ## book->introformat, of type integer exists, not null
            ## book->revision, of type integer exists, not null
            ## book->disableprinting does not exist
            ## book->summary does not exist
            ## book_chapters->contentformat, of type integer exists, not null

            h2. Testing 1.9 => 2.2 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_20_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later).
            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.


            h2. Testing 1.9 => 2.2 => 2.3 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_22_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir.
            - Checkout MOODLE_23_STABLE for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            And that's all, I think that with these combinations tested we are ensuring that anybody installing 23_STABLE or later will be getting the mod_book upgraded properly. Of course, if you're interested into testing any other combination... you are welcome.

            Ciao :-)
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            Pull Master Diff URL https://github.com/stronk7/moodle/compare/master...MDL-35297
            Pull 2.3 Diff URL https://github.com/stronk7/moodle/compare/MOODLE_23_STABLE...MDL-35297_23
            Pull Master Branch MDL-35297
            Pull from Repository git://github.com/stronk7/moodle.git
            Testing Instructions h2. Requirements:

            - Enable debug developer & display errors.
            - This requires access to multiple git repositories and being able to switch branches by the tester.
            - Also, ideally, the ability to perform "site backups" (db & moodledata) is recommended to avoid the manual execution of the "preparing the initial status" section multiple times.

            h2. Preparing the initial status:

            - Install MOODLE_19_STABLE site
            - Clone git://github.com/skodak/moodle-mod_book.git into the site mod/book dir
            - Checkout the MOODLE_19_STABLE branch of mod/book
            - Install mod/book.

            - There is one attached backup file (backup-book-mdl-35297.zip) containing:
            - 1 book activity with image in the intros (pink).
            - 2 chapters and 1 subchapter all them with images too (red, green, blue).

            - Restore, as admin, the backup file into the site, 2 times to new course and 2 times to existing course, so at the end you get at least 2 courses with 2 book activities each. The process ends ok and all the images are in place (the summary and the chapters ones).

            - Note: At this point probably it would be interesting to perform a site backup (database & moodledata) because the points executed until now must be repeated later for other combination of branches/versions.

            h2. The "TESTs CHECK LIST"

            This is the list of things that must be tested at the end of each upgrade combination below:

            # Edit the settings of any of the book activities.
            # Without modifying anything, click and press "Save and return to course".
            # TEST: No error happens and you are redirected to the course page normally.
            # Visit the 4 books and verify that:
            ## TEST: Each book has 2 chapters and 1 subchapter.
            ## TEST: Each of the chapters/subchapters have one image (red, green, blue).
            ## TEST: The links of the images are served through pluginfile.php (aka they have been moved to proper book file area (mod_book/chapter).
            ## TEST: Manually going to the list of books in a course (http://MOODLEURL/mod/book/index.php?id=COURSEID) shows the intro for all book activities, each one with its "pink" image.
            ## TEST: The "pink" images are also being served through pluginfile.php with proper file area (mod_book/intro).
            # TEST: Verify the following database columns exist with the detailed specs below:
            ## book->intro, of type text exists
            ## book->introformat, of type integer exists, not null
            ## book->revision, of type integer exists, not null
            ## book->disableprinting does not exist
            ## book->summary does not exist
            ## book_chapters->contentformat, of type integer exists, not null

            h2. Testing 1.9 => 2.2 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_20_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later).
            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.


            h2. Testing 1.9 => 2.2 => 2.3 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_22_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir.
            - Checkout MOODLE_23_STABLE for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            And that's all, I think that with these combinations tested we are ensuring that anybody installing 23_STABLE or later will be getting the mod_book upgraded properly. Of course, if you're interested into testing any other combination... you are welcome.

            Ciao :-)
            h2. Requirements:

            - Enable debug developer & display errors.
            - This requires access to multiple git repositories and being able to switch branches by the tester.
            - Also, ideally, the ability to perform "site backups" (db & moodledata) is recommended to avoid the manual execution of the "preparing the initial status" section multiple times.

            h2. Preparing the initial status:

            - Install MOODLE_19_STABLE site
            - Clone git://github.com/skodak/moodle-mod_book.git into the site mod/book dir
            - Checkout the MOODLE_19_STABLE branch of mod/book
            - Install mod/book.

            - There is one attached backup file (backup-book-mdl-35297.zip) containing:
            - 1 book activity with image in the intros (pink).
            - 2 chapters and 1 subchapter all them with images too (red, green, blue).

            - Restore, as admin, the backup file into the site, 2 times to new course and 2 times to existing course, so at the end you get at least 2 courses with 2 book activities each. The process ends ok and all the images are in place (the summary and the chapters ones).

            - Note: At this point probably it would be interesting to perform a site backup (database & moodledata) because the points executed until now must be repeated later for other combination of branches/versions.

            h2. The "TESTs CHECK LIST"

            This is the list of things that must be tested at the end of each upgrade combination below:

            # Edit the settings of any of the book activities.
            # Without modifying anything, click and press "Save and return to course".
            # TEST: No error happens and you are redirected to the course page normally.
            # Visit the 4 books and verify that:
            ## TEST: Each book has 2 chapters and 1 subchapter.
            ## TEST: Each of the chapters/subchapters have one image (red, green, blue).
            ## TEST: The links of the images are served through pluginfile.php (aka they have been moved to proper book file area (mod_book/chapter).
            ## TEST: Manually going to the list of books in a course (http://MOODLEURL/mod/book/index.php?id=COURSEID) shows the intro for all book activities, each one with its "pink" image.
            ## TEST: The "pink" images are also being served through pluginfile.php with proper file area (mod_book/intro).
            # TEST: Verify the following database columns exist with the detailed specs below:
            ## book->intro, of type text exists
            ## book->introformat, of type integer exists, not null
            ## book->revision, of type integer exists, not null
            ## book->disableprinting does not exist
            ## book->summary does not exist
            ## book_chapters->contentformat, of type integer exists, not null

            h2. Testing 1.9 => 2.2 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_20_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later).
            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.


            h2. Testing 1.9 => 2.2 => 2.3 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_21_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir.
            - Checkout MOODLE_23_STABLE for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            And that's all, I think that with these combinations tested we are ensuring that anybody installing 23_STABLE or later will be getting the mod_book upgraded properly. Of course, if you're interested into testing any other combination... you are welcome.

            Ciao :-)
            Pull 2.3 Branch MDL-35297_23
            stronk7 Eloy Lafuente (stronk7) made changes -
            Testing Instructions h2. Requirements:

            - Enable debug developer & display errors.
            - This requires access to multiple git repositories and being able to switch branches by the tester.
            - Also, ideally, the ability to perform "site backups" (db & moodledata) is recommended to avoid the manual execution of the "preparing the initial status" section multiple times.

            h2. Preparing the initial status:

            - Install MOODLE_19_STABLE site
            - Clone git://github.com/skodak/moodle-mod_book.git into the site mod/book dir
            - Checkout the MOODLE_19_STABLE branch of mod/book
            - Install mod/book.

            - There is one attached backup file (backup-book-mdl-35297.zip) containing:
            - 1 book activity with image in the intros (pink).
            - 2 chapters and 1 subchapter all them with images too (red, green, blue).

            - Restore, as admin, the backup file into the site, 2 times to new course and 2 times to existing course, so at the end you get at least 2 courses with 2 book activities each. The process ends ok and all the images are in place (the summary and the chapters ones).

            - Note: At this point probably it would be interesting to perform a site backup (database & moodledata) because the points executed until now must be repeated later for other combination of branches/versions.

            h2. The "TESTs CHECK LIST"

            This is the list of things that must be tested at the end of each upgrade combination below:

            # Edit the settings of any of the book activities.
            # Without modifying anything, click and press "Save and return to course".
            # TEST: No error happens and you are redirected to the course page normally.
            # Visit the 4 books and verify that:
            ## TEST: Each book has 2 chapters and 1 subchapter.
            ## TEST: Each of the chapters/subchapters have one image (red, green, blue).
            ## TEST: The links of the images are served through pluginfile.php (aka they have been moved to proper book file area (mod_book/chapter).
            ## TEST: Manually going to the list of books in a course (http://MOODLEURL/mod/book/index.php?id=COURSEID) shows the intro for all book activities, each one with its "pink" image.
            ## TEST: The "pink" images are also being served through pluginfile.php with proper file area (mod_book/intro).
            # TEST: Verify the following database columns exist with the detailed specs below:
            ## book->intro, of type text exists
            ## book->introformat, of type integer exists, not null
            ## book->revision, of type integer exists, not null
            ## book->disableprinting does not exist
            ## book->summary does not exist
            ## book_chapters->contentformat, of type integer exists, not null

            h2. Testing 1.9 => 2.2 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_20_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later).
            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.


            h2. Testing 1.9 => 2.2 => 2.3 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_21_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir.
            - Checkout MOODLE_23_STABLE for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            And that's all, I think that with these combinations tested we are ensuring that anybody installing 23_STABLE or later will be getting the mod_book upgraded properly. Of course, if you're interested into testing any other combination... you are welcome.

            Ciao :-)
            h2. Requirements:

            - Enable debug developer & display errors.
            - This requires access to multiple git repositories and being able to switch branches by the tester.
            - Also, ideally, the ability to perform "site backups" (db & moodledata) is recommended to avoid the manual execution of the "preparing the initial status" section multiple times.

            h2. Preparing the initial status:

            - Install MOODLE_19_STABLE site
            - Clone git://github.com/skodak/moodle-mod_book.git into the site mod/book dir
            - Checkout the MOODLE_19_STABLE branch of mod/book
            - Install mod/book.

            - There is one attached backup file (backup-book-mdl-35297.zip) containing:
            - 1 book activity with image in the intros (pink).
            - 2 chapters and 1 subchapter all them with images too (red, green, blue).

            - Restore, as admin, the backup file into the site, 2 times to new course and 2 times to existing course, so at the end you get at least 2 courses with 2 book activities each. The process ends ok and all the images are in place (the summary and the chapters ones).

            - Note: At this point probably it would be interesting to perform a site backup (database & moodledata) because the points executed until now must be repeated later for other combination of branches/versions.

            h2. The "TESTs CHECK LIST"

            This is the list of things that must be tested at the end of each upgrade combination below:

            # Edit the settings of any of the book activities.
            # Without modifying anything, click and press "Save and return to course".
            # TEST: No error happens and you are redirected to the course page normally.
            # Visit the 4 books and verify that:
            ## TEST: Each book has 2 chapters and 1 subchapter.
            ## TEST: Each of the chapters/subchapters have one image (red, green, blue).
            ## TEST: The links of the images are served through pluginfile.php (aka they have been moved to proper book file area (mod_book/chapter).
            ## TEST: Manually going to the list of books in a course (http://MOODLEURL/mod/book/index.php?id=COURSEID) shows the intro for all book activities, each one with its "pink" image.
            ## TEST: The "pink" images are also being served through pluginfile.php with proper file area (mod_book/intro).
            # TEST: Verify the following database columns exist with the detailed specs below:
            ## book->intro, of type text exists
            ## book->introformat, of type integer exists, not null
            ## book->revision, of type integer exists, not null
            ## book->disableprinting does not exist
            ## book->summary does not exist
            ## book_chapters->contentformat, of type integer exists, not null

            h2. Testing 1.9 => 2.2 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_20_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir (better move it to your Desktop or wherever, you will need it again later).
            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.


            h2. Testing 1.9 => 2.2 => 2.3 => 2.4 upgrade.

            - Prepare the initial status (manually or from site backup).

            - Checkout MOODLE_22_STABLE for the site.
            - Checkout MOODLE_20_STABLE for the mod/book.
            - Upgrade the site.
            - TEST: No error happens.

            - Delete the mod/book dir.
            - Checkout MOODLE_23_STABLE for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            - Checkout master for the site.
            - Upgrade the site.
            - TEST: No error happens.

            - Verify the complete "TESTs CHECK LIST" above is passing.

            And that's all, I think that with these combinations tested we are ensuring that anybody installing 23_STABLE or later will be getting the mod_book upgraded properly. Of course, if you're interested into testing any other combination... you are welcome.

            Ciao :-)
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Sent to integration, i tried here different combinations, repeated executions a was unable to break it... so... here we go!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Sent to integration, i tried here different combinations, repeated executions a was unable to break it... so... here we go!
            stronk7 Eloy Lafuente (stronk7) made changes -
            Currently in integration Yes [ 10041 ]
            poltawski Dan Poltawski made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator poltawski
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to master and 2.3, thanks guys

            Show
            poltawski Dan Poltawski added a comment - Integrated to master and 2.3, thanks guys
            poltawski Dan Poltawski made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.3.3 [ 12373 ]
            Fix Version/s STABLE backlog [ 10463 ]
            dmonllao David Monllaó made changes -
            Tester davmon
            dmonllao David Monllaó made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Hide
            dmonllao David Monllaó added a comment -

            It fails in the first test, upgrading from 1.9 to 2.2 and to 2.4. With the site upgraded to 2.4 using the core mod_book, in the 3rd step:

            "Without modifying anything, click and press "Save and return to course".

            I receive a "Error writting to database"

            Show
            dmonllao David Monllaó added a comment - It fails in the first test, upgrading from 1.9 to 2.2 and to 2.4. With the site upgraded to 2.4 using the core mod_book, in the 3rd step: "Without modifying anything, click and press "Save and return to course". I receive a "Error writting to database"
            dmonllao David Monllaó made changes -
            Status Testing in progress [ 10011 ] Problem during testing [ 10007 ]
            Hide
            dmonllao David Monllaó added a comment -

            sorry, I'll repeat the test, I'm not 100% sure I've used the latest master version

            Show
            dmonllao David Monllaó added a comment - sorry, I'll repeat the test, I'm not 100% sure I've used the latest master version
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Thanks!

            Yes it's important to use latest master version (form integration.git, of course).

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Thanks! Yes it's important to use latest master version (form integration.git, of course). Ciao
            poltawski Dan Poltawski made changes -
            Status Problem during testing [ 10007 ] Waiting for testing [ 10005 ]
            dmonllao David Monllaó made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Hide
            dmonllao David Monllaó added a comment -

            It passes. Tested using all latests integration versions (19, 22, 23 and master)

            Show
            dmonllao David Monllaó added a comment - It passes. Tested using all latests integration versions (19, 22, 23 and master)
            dmonllao David Monllaó made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            poltawski Dan Poltawski added a comment -

            Hurray!

            You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

            Show
            poltawski Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4
            poltawski Dan Poltawski made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 01/Nov/12
            Hide
            t6nis20 Tõnis Tartes added a comment -

            Got this error when upgrading to latest weekly M2.3 - http://tracker.moodle.org/browse/MDL-36326
            Any help or ideas?

            Show
            t6nis20 Tõnis Tartes added a comment - Got this error when upgrading to latest weekly M2.3 - http://tracker.moodle.org/browse/MDL-36326 Any help or ideas?

              People

              • Votes:
                3 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12