Moodle

typo in lib/db/services.php

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.1
  • Fix Version/s: 2.3.3
  • Component/s: Web Services
  • Labels:
    None
  • Testing Instructions:
    Hide
    1. On a fresh install
    2. Navigate to Home ► Site administration ► Plugins ► Web services ► External services
    3. Add an external service
    4. Add the function core_course_update_categories to the external service
    5. Make sure the required capabilities next to the function name displays "moodle/category:manage" NOT "moodle:category/manage"
    Show
    On a fresh install Navigate to Home ► Site administration ► Plugins ► Web services ► External services Add an external service Add the function core_course_update_categories to the external service Make sure the required capabilities next to the function name displays "moodle/category:manage" NOT "moodle:category/manage"
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-35312-master
  • Pull Master Diff URL:

Description

on line 525 it says
"moodle:category/manage"

and it should be
"moodle/category:manage"

this seems to be only a typo

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jérôme Mouneyrac added a comment -

Ah you did a mistake, no I'm kidding, sending to integration.

Show
Jérôme Mouneyrac added a comment - Ah you did a mistake, no I'm kidding, sending to integration.
Hide
Permalink
Dan Poltawski added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Sam Hemelryk added a comment -

Thanks guys, has been integrated now

Show
Sam Hemelryk added a comment - Thanks guys, has been integrated now
Hide
Permalink
Jérôme Mouneyrac added a comment -

passing the test for the sake of the tester - I'll add $100 to my donation box if the fix breaks anything

PS: you may not see the change till next version bump.

Show
Jérôme Mouneyrac added a comment - passing the test for the sake of the tester - I'll add $100 to my donation box if the fix breaks anything PS: you may not see the change till next version bump.
Hide
Permalink
Dan Poltawski added a comment -

Congratulations, you've done it!

Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

Show
Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: