XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      This issue re-factors code but has no functional changes. The testing should be aimed on making sure that no functionality is lost and no warning/errors are displayed (where they were not displayed before).

      Proper testing would be done by running all QA tests

      Quick test. Make sure that there are no errors:

      1. Add activities/resources on the main page
      2. Add block_site_main_menu on the front page, navigate the links
      3. Create 'social' course, add activities
      4. block_social_activities will be added automatically, navigate the links in it
      5. Create course with topics or weeks format, add activities, move activities inside one section and between sections. Try in both JS and non JS mode
      6. Try increasing/decreasing number of sections in topics/weeks formats
      7. Add activities block to the course and navigate the links
      8. test course/externallib.php ?
      9. View outline and log reports
      10. Check the query counts before and after the patch on coruse page, and verify that no additional queries are added
      Show
      This issue re-factors code but has no functional changes. The testing should be aimed on making sure that no functionality is lost and no warning/errors are displayed (where they were not displayed before). Proper testing would be done by running all QA tests Quick test. Make sure that there are no errors: Add activities/resources on the main page Add block_site_main_menu on the front page, navigate the links Create 'social' course, add activities block_social_activities will be added automatically, navigate the links in it Create course with topics or weeks format, add activities, move activities inside one section and between sections. Try in both JS and non JS mode Try increasing/decreasing number of sections in topics/weeks formats Add activities block to the course and navigate the links test course/externallib.php ? View outline and log reports Check the query counts before and after the patch on coruse page, and verify that no additional queries are added
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-35339-master

      Description

      As we discussed in devchat the OOP refactoring of the courses is left to at least 2.5

      There are some changes that need to be done in 2.4:

      • add function get_module_types_names() to replace $modnames and $modnamesplural in get_all_mods()
      • deprecate function get_all_mods(), change it's usage
      • add get_used_module_types() to modinfo (to replace $modnamesused in get_all_mods())
      • deprecate get_all_sections()
      • deprecate add_mod_to_section() and replace it with course_add_cm_to_section() to fix the mess in arguments

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12