Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35345

Invalid HTML in completion images on course pages

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: Activity completion
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE

      Description

      In course/lib.php on line 1716, the alt and title attributes can cause invalid HTML to be output because format_string() does not do anything to fix apostrophes in the text. The invalid HTML is occasionally causing layout glitches as a result. There are a number of simple obvious ways to fix it.

      Replication steps:

      1. Log in as admin
      2. Navigate to Settings > Site admin > Advanced features
      3. Enable completion tracking
      4. Navigate to a course
      5. Edit the course settings
      6. Set Completion tracking setting to Enabled...
      7. Create an activity and put an apostrophe (') in its name.
      8. Save the activity and return to the course page
      9. Mouse over the completion icon and note the tooltip

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              quen Sam Marshall
              Reporter:
              anthonyforth Anthony Forth
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: