Moodle
  1. Moodle
  2. MDL-35350

Advanced Uploading of Files assignment does not show submission timestamp to students in assignment index page

    Details

    • Testing Instructions:
      Hide
      1. Log in as teacher/admin
      2. Create an "Advanced uploading of files" assignment with "Enable send for marking" set to "No"
      3. On the course page, add the Activities block
      4. Log in as a student and make a submission to the assignment.
      5. Navigate to the "Assignments" link in the course Activities block.
      6. VERIFY There is a timestamp here showing when the assignment was submitted.
      Show
      Log in as teacher/admin Create an "Advanced uploading of files" assignment with "Enable send for marking" set to "No" On the course page, add the Activities block Log in as a student and make a submission to the assignment. Navigate to the "Assignments" link in the course Activities block. VERIFY There is a timestamp here showing when the assignment was submitted.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
      MDL-35350_m24
    • Pull Master Branch:
    • Rank:
      44023

      Description

      To reproduce:

      1. Log in as teacher/admin
      2. Create an "Advanced uploading of files" assignment with "Enable send for marking" set to "No"
      3. On the course page, add the Activities block
      4. Log in as a student and make a submission to the assignment.
      5. Navigate to the "Assignments" link in the course Activities block.

      Expected result: There should be a timestamp here showing when the assignment was submitted.

      Actual result: The "Submitted" column is blank.

        Activity

        Hide
        Michael de Raadt added a comment -

        This appears to be related to the Send for marking setting.

        I will attach a patch.

        Show
        Michael de Raadt added a comment - This appears to be related to the Send for marking setting. I will attach a patch.
        Hide
        Adrian Greeve added a comment -

        [Y] Syntax
        [Y] Output
        [Y] Whitespace
        [-] Language
        [-] Databases
        [Y] Testing
        [-] Security
        [-] Documentation
        [Y] Git
        [Y] Sanity check

        Hello Rosie,

        This looks fine. Maybe as a nod to Michael you could mention that he provided the patch in your git commit message?

        Thanks.

        Show
        Adrian Greeve added a comment - [Y] Syntax [Y] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Hello Rosie, This looks fine. Maybe as a nod to Michael you could mention that he provided the patch in your git commit message? Thanks.
        Hide
        Rossiani Wijaya added a comment -

        Hmm.. I thought I assigned him as the commiter.

        Anyways I updated the patch and assigned him as the commiter.

        Thanks Adrian for checking that.

        Sending for integration review.

        Show
        Rossiani Wijaya added a comment - Hmm.. I thought I assigned him as the commiter. Anyways I updated the patch and assigned him as the commiter. Thanks Adrian for checking that. Sending for integration review.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks guys, this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks guys, this has been integrated now.
        Hide
        Rajesh Taneja added a comment -

        Thanks for fixing this Rossie and Michael,

        I can see time stamp on assignment page.
        IMO similar functionality should be there in Assign module as well. Have added Damyon as watcher to get his opinion.

        FYI (not related): Getting notice on assign index page.

        Notice: Trying to get property of non-object in /var/www/im/mod/assign/locallib.php on line 349 Call Stack: 0.0002 655016 1. {main}() /var/www/im/mod/assign/index.php:0 0.3267 70969944 2. assign->view() /var/www/im/mod/assign/index.php:51 
        
        Show
        Rajesh Taneja added a comment - Thanks for fixing this Rossie and Michael, I can see time stamp on assignment page. IMO similar functionality should be there in Assign module as well. Have added Damyon as watcher to get his opinion. FYI (not related): Getting notice on assign index page. Notice: Trying to get property of non-object in /var/www/im/mod/assign/locallib.php on line 349 Call Stack: 0.0002 655016 1. {main}() /var/www/im/mod/assign/index.php:0 0.3267 70969944 2. assign->view() /var/www/im/mod/assign/index.php:51
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

        Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

        Thanks, closing as fixed!

        Show
        Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: