Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35357

Undefined property: stdClass::$answerformat

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.3.4, 2.4.1
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Lesson
    • Labels:
    • Testing Instructions:
      Hide
      1. Set Debug mode to Developer
      2. In a Lesson add an Essay questions.
      3. As student, take the lesson.
      4. As teacher clicks on the Reports/Detailed Statistics tab

      Make sure there is no notice for undefined property.

      Show
      Set Debug mode to Developer In a Lesson add an Essay questions. As student, take the lesson. As teacher clicks on the Reports/Detailed Statistics tab Make sure there is no notice for undefined property.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Using Moodle 2.3.2 (Build: 20120910)
      Debug mode: set to max (DEVELOPER)
      In a Lesson containing Essay questions. After Lesson has been taken by students.
      When teacher clicks on the Reports/Detailed Statistics tab, error message is thrown:

      Notice: Undefined property: stdClass::$answerformat in moodle\mod\lesson\pagetypes\essay.php on line 226

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              This is a minor oversight in the code. I've attached a patch.

              I should stop coding now. I'm not getting what I'm supposed to get done.

              Show
              salvetore Michael de Raadt added a comment - This is a minor oversight in the code. I've attached a patch. I should stop coding now. I'm not getting what I'm supposed to get done.
              Hide
              rezeau Joseph Rézeau added a comment -

              Thanks, Michael, your patch solves the problem.

              Show
              rezeau Joseph Rézeau added a comment - Thanks, Michael, your patch solves the problem.
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Thanks Michael for creating a patch for this.

              Submitting this for integration review.

              Show
              rwijaya Rossiani Wijaya added a comment - Thanks Michael for creating a patch for this. Submitting this for integration review.
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated to master, 24 and 23. Thanks Rosie/Michael

              Show
              poltawski Dan Poltawski added a comment - Integrated to master, 24 and 23. Thanks Rosie/Michael
              Hide
              dmonllao David Monllaó added a comment -

              It passes, tested in 23 and master.

              While testing this I've discovered MDL-37634 which prevents questions to be imported in the lesson module

              Show
              dmonllao David Monllaó added a comment - It passes, tested in 23 and master. While testing this I've discovered MDL-37634 which prevents questions to be imported in the lesson module
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks!

              Closing as fixed, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks! Closing as fixed, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13