Moodle
  1. Moodle
  2. MDL-35375

Links to a single student's grading page from the Assignment Grading page goes to wrong student

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3.3
    • Component/s: Assignment
    • Labels:
      None
    • Database:
      PostgreSQL
    • Testing Instructions:
      Hide

      Prerequisite: PostgreSQL

      1. Create a new assignment in a course with multiple students. Enable at least one submission plugin.
      2. Leave blind marking disabled
      3. Go to the grading table in the assignment (View/grade all submissions)
      4. Click on the "Last modified (submission)" column header to sort by the submission date
      5. Click on the "Last modified (grade)" column header to sort by the graded date
      6. Remember the name of the first student in the list
      7. Click on the grade button for the first student in the list
        Expected result: The name of the student in the grading page matches the first row in the grading table
        Actual result: A random student will be shown in the grading page
      Show
      Prerequisite: PostgreSQL Create a new assignment in a course with multiple students. Enable at least one submission plugin. Leave blind marking disabled Go to the grading table in the assignment (View/grade all submissions) Click on the "Last modified (submission)" column header to sort by the submission date Click on the "Last modified (grade)" column header to sort by the graded date Remember the name of the first student in the list Click on the grade button for the first student in the list Expected result: The name of the student in the grading page matches the first row in the grading table Actual result: A random student will be shown in the grading page
    • Workaround:
      Hide

      Sort the grading table by a unique column (like lastname) before opening the single grading page.

      Show
      Sort the grading table by a unique column (like lastname) before opening the single grading page.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
    • Rank:
      44051

      Description

      When the current sort for the grading table is for a column that contains duplicate values (or no values) the returned order of rows is random. This affects the single grading page which is supposed to step through the rows in the grading table in a fixed order.

      This can be reliably triggered by sorting on the last modified (submission) column and then the last modified (grade) column when both of those columns contain no data as tablelib does not sort by any more than 2 columns (so this will ensure there are no other columns in the current sort).

        Activity

        Hide
        Damyon Wiese added a comment -

        Thanks Matthew for reporting this bug and supplying a patch - I have implemented a different fix that works reliably and updated the issue.

        Show
        Damyon Wiese added a comment - Thanks Matthew for reporting this bug and supplying a patch - I have implemented a different fix that works reliably and updated the issue.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Hi Damyon,

        These changes look good however before they get integrated I need to know whether this is a 2.4 change only or whether it should be backported.
        If it is to be backported could you please produce a branch for 23 as well, I've tried myself just now but there are conflicts.

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Hi Damyon, These changes look good however before they get integrated I need to know whether this is a 2.4 change only or whether it should be backported. If it is to be backported could you please produce a branch for 23 as well, I've tried myself just now but there are conflicts. Many thanks Sam
        Hide
        Damyon Wiese added a comment -

        It affects 23 as well - I'll make a branch for 23 now.

        Show
        Damyon Wiese added a comment - It affects 23 as well - I'll make a branch for 23 now.
        Hide
        Damyon Wiese added a comment -

        This 2.3 branch is ready to go now.

        Show
        Damyon Wiese added a comment - This 2.3 branch is ready to go now.
        Hide
        Sam Hemelryk added a comment -

        Thanks Damyon, this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Damyon, this has been integrated now
        Hide
        Rossiani Wijaya added a comment -

        Tested this with PostgreSQL on integration repos for 2.3 and master.

        It works as expected.

        Test passed.

        Show
        Rossiani Wijaya added a comment - Tested this with PostgreSQL on integration repos for 2.3 and master. It works as expected. Test passed.
        Hide
        Dan Poltawski added a comment -

        Congratulations, you've done it!

        Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

        Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

        Show
        Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: