Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35380

SCORM - detect invalid packages with extra directory and show specific error

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.4, 2.4.5, 2.5.1
    • 2.6
    • SCORM
    • MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_26_STABLE
    • master_MDL-35380
    • Hide

      Test 1:
      Using Drag/drop onto course homepage Create a SCORM and use the file attached to this issue - it should fail (no specific error is shown with drag/drop yet)

      Test 2:
      Using Drag/drop onto course homepage Create a SCORM and use a normal SCORM package - make sure it adds correctly.

      Test 3
      Using add an activity Create a SCORM and use the file attached to this issue - it should display an error "Invalid package detected - the imsmanifest.xml file must sit in the root of your package, not inside a directory."

      Test 2:
      Using add an activity Create a SCORM and use a normal SCORM package - make sure it adds correctly.

      Show
      Test 1: Using Drag/drop onto course homepage Create a SCORM and use the file attached to this issue - it should fail (no specific error is shown with drag/drop yet) Test 2: Using Drag/drop onto course homepage Create a SCORM and use a normal SCORM package - make sure it adds correctly. Test 3 Using add an activity Create a SCORM and use the file attached to this issue - it should display an error "Invalid package detected - the imsmanifest.xml file must sit in the root of your package, not inside a directory." Test 2: Using add an activity Create a SCORM and use a normal SCORM package - make sure it adds correctly.

    Description

      many SCORM packages are created with an extra directory that contains the SCORM package - correct packages will have the content in the root of the package but when manually zipping in windows by right clicking on a directory it will create the extra dir and some authoring tools appear to package them incorrectly too - see: http://moodle.org/mod/forum/discuss.php?d=210070

      We should make it easier on teachers and automatically detect the extra dir. Ideally I'd like to handle this by stripping the extra directory out but that's a bit more work and it's easier to just provide a specific error message about the package.

      Attachments

        Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-28579 SCORM replace filepicker element with filemanager and allow linking.

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Improvement - An enhancement to an existing Moodle feature. MDL-33633 create new function to check for valid SCORM packages

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              danmarsden Dan Marsden
              danmarsden Dan Marsden
              Dan Poltawski Dan Poltawski
              Damyon Wiese Damyon Wiese
              Damyon Wiese Damyon Wiese
              Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13