Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35382

courselib_testcase::test_reorder_sections is failing sporadically

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Unit tests
    • Labels:

      Description

      We have seen this test fail maybe 4/5 times on the integration server (out of 1000's of runs) and Tim has just seen it fail on the nightly build server.

      The error is:

      courselib_testcase::test_reorder_sections
      Failed asserting that 7 matches expected '6'.
       
      /var/lib/jenkins/git_repositories/MOODLE_23_STABLE/course/tests/courselib_test.php:47
      /var/lib/jenkins/git_repositories/MOODLE_23_STABLE/lib/phpunit/classes/advanced_testcase.php:76

      We should investigate the cause.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            Note that this does not seem to have a pattern. On the 2 integration severs running the same build on the same commit when it fails, the other server passes and a new run will pass.

            Show
            poltawski Dan Poltawski added a comment - Note that this does not seem to have a pattern. On the 2 integration severs running the same build on the same commit when it fails, the other server passes and a new run will pass.
            Hide
            salvetore Michael de Raadt added a comment -

            Mmmm... Mysterious.

            Show
            salvetore Michael de Raadt added a comment - Mmmm... Mysterious.
            Hide
            poltawski Dan Poltawski added a comment -

            Just seen this occur on master again:

            courselib_testcase::test_reorder_sections
            Failed asserting that 7 matches expected '6'.

            /Users/Shared/Jenkins/Home/git_repositories/master/course/tests/courselib_test.php:81
            /Users/Shared/Jenkins/Home/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:76

            Show
            poltawski Dan Poltawski added a comment - Just seen this occur on master again: courselib_testcase::test_reorder_sections Failed asserting that 7 matches expected '6'. /Users/Shared/Jenkins/Home/git_repositories/master/course/tests/courselib_test.php:81 /Users/Shared/Jenkins/Home/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:76
            Hide
            poltawski Dan Poltawski added a comment -

            courselib_testcase::test_reorder_sections
            Failed asserting that 14 matches expected '6'.

            /Users/Shared/Jenkins/Home/git_repositories/master/course/tests/courselib_test.php:81
            /Users/Shared/Jenkins/Home/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:76

            Show
            poltawski Dan Poltawski added a comment - courselib_testcase::test_reorder_sections Failed asserting that 14 matches expected '6'. /Users/Shared/Jenkins/Home/git_repositories/master/course/tests/courselib_test.php:81 /Users/Shared/Jenkins/Home/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:76
            Hide
            skodak Petr Skoda added a comment -

            Thanks for the report.

            Show
            skodak Petr Skoda added a comment - Thanks for the report.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (23 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (23 & master), thanks!
            Hide
            timb Tim Barker added a comment -

            This failed in the nightly build on Postgres on 5th October. It is passing now though.

            I think to truly discover if this is fixed, it needs to be monitored over a period of time. So let this in and monitor in the two builds.

            Show
            timb Tim Barker added a comment - This failed in the nightly build on Postgres on 5th October. It is passing now though. I think to truly discover if this is fixed, it needs to be monitored over a period of time. So let this in and monitor in the two builds.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            From somewhere within the clouds...

            Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12