Moodle
  1. Moodle
  2. MDL-35389

Coding error when changing locked state of a assignment with blind marking set

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a assignment with blind marking
      2. Go to gradebook and lock the column for this assignment
      3. Submit an assignment as a student
      4. Go to gradebook and unlock the column for the assignment.
      5. Verify you do not receive this error: Coding error detected, it must be fixed by a programmer: The property "context" is not set.
      Show
      Create a assignment with blind marking Go to gradebook and lock the column for this assignment Submit an assignment as a student Go to gradebook and unlock the column for the assignment. Verify you do not receive this error: Coding error detected, it must be fixed by a programmer: The property "context" is not set.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      assign_get_user_grades() is not correctly loading the assignment context. This results in errors when the gradebook uses this callback to mod_assign.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Raymond Antonio added a comment -

            Hi Damyon and Ankit,

            This is the patch for the issue and it is ready for testing. The patch's details are as follows:
            1. Repo
            git://github.com/raymondAntonio/moodle.git
            2. The branch
            MDL-35389
            And This is the diff :
            https://github.com/raymondAntonio/moodle/commit/f5ed5949841a56d3bd3ce21b7e59ed08d1613a67

            Cheers

            Show
            Raymond Antonio added a comment - Hi Damyon and Ankit, This is the patch for the issue and it is ready for testing. The patch's details are as follows: 1. Repo git://github.com/raymondAntonio/moodle.git 2. The branch MDL-35389 And This is the diff : https://github.com/raymondAntonio/moodle/commit/f5ed5949841a56d3bd3ce21b7e59ed08d1613a67 Cheers
            Hide
            Michael de Raadt added a comment - - edited

            Hi, Raymond.

            Thanks for your work on this issue and others.

            I've added you to the jira-developers group in Tracker. That allows you to edit issues, assign them to yourself and push issues for peer review. You can't submit to integration, but Damyon or a peer reviewer at HQ can do that after peer review.

            Feel free to assign this issue to yourself and put your Git details in the appropriate slots. This would need some testing instructions before being sent to peer review.

            Show
            Michael de Raadt added a comment - - edited Hi, Raymond. Thanks for your work on this issue and others. I've added you to the jira-developers group in Tracker. That allows you to edit issues, assign them to yourself and push issues for peer review. You can't submit to integration, but Damyon or a peer reviewer at HQ can do that after peer review. Feel free to assign this issue to yourself and put your Git details in the appropriate slots. This would need some testing instructions before being sent to peer review.
            Hide
            Damyon Wiese added a comment -

            This fix looks correct to me. Thanks Raymond.

            Show
            Damyon Wiese added a comment - This fix looks correct to me. Thanks Raymond.
            Hide
            Frédéric Massart added a comment -

            I could reproduce this working on MDL-34931 with an assignment (default settings) with groupings set.

            Show
            Frédéric Massart added a comment - I could reproduce this working on MDL-34931 with an assignment (default settings) with groupings set.
            Hide
            Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Raymond Antonio added a comment -

            Hi Dan
            Rebase done. Cheers

            Show
            Raymond Antonio added a comment - Hi Dan Rebase done. Cheers
            Hide
            Sam Hemelryk added a comment -

            Hi Raymond,

            Changes look good thanks, I'll integrate this when git.moodle.org is available again.
            Again just to confirm is this issue 2.4 only?

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Hi Raymond, Changes look good thanks, I'll integrate this when git.moodle.org is available again. Again just to confirm is this issue 2.4 only? Cheers Sam
            Hide
            Damyon Wiese added a comment -

            Hi Sam,

            Yep 2.4 only

            Cheers
            Damyon

            Show
            Damyon Wiese added a comment - Hi Sam, Yep 2.4 only Cheers Damyon
            Hide
            Sam Hemelryk added a comment -

            Integrated now thanks

            Show
            Sam Hemelryk added a comment - Integrated now thanks
            Hide
            Mark Nelson added a comment - - edited

            The assignment was unlocked by default. I changed this to locked and back to unlocked and did not receive any errors. Passed.

            Show
            Mark Nelson added a comment - - edited The assignment was unlocked by default. I changed this to locked and back to unlocked and did not receive any errors. Passed.
            Hide
            Dan Poltawski added a comment -

            Congratulations, you've done it!

            Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

            Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

            Show
            Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: