Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35392

Feedback from module assign is not shown in the gradebook.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Copying Michael Woods excellent reproduction steps here.

      Testing Steps:

      1. Create a brand new assignment and ensure 'Use Marking Workflow' = Yes.
      2. Go to the assignment grading screen and ensure 'Quick Grading' is ticked.
      3. Give a grade and some feedback to a single student, using the quick grading fields on the screen. Do not change the workflow state to released yet.
      4. Check in either the grader report or user report to ensure that neither the grade or feedback has flowed through yet. This is correct as we haven't released the grade yet.
      5. Back on the assignment grading screen, tick the student that you previously graded (the checkbox in the very first 'Select' column) and down the bottom, change 'With selected...' dropdown box to be 'Set Marking Workflow state' and Go.
      6. Change 'Marking Workflow State' dropdown selection to be 'Released' and click 'Save Changes'.
      7. Now check in either the grader report or user report.

      Expected Result: The grade and feedback comment would be present in the Grader Report and User Report, as the workflow status has been set to released.

      Note: I began to write behat tests but unfortunately, as there is a dialogue box that loads when you select and try to update work flow I cannot write working tests for this unless we alter that page.

      Show
      Copying Michael Woods excellent reproduction steps here. Testing Steps: Create a brand new assignment and ensure 'Use Marking Workflow' = Yes. Go to the assignment grading screen and ensure 'Quick Grading' is ticked. Give a grade and some feedback to a single student, using the quick grading fields on the screen. Do not change the workflow state to released yet. Check in either the grader report or user report to ensure that neither the grade or feedback has flowed through yet. This is correct as we haven't released the grade yet. Back on the assignment grading screen, tick the student that you previously graded (the checkbox in the very first 'Select' column) and down the bottom, change 'With selected...' dropdown box to be 'Set Marking Workflow state' and Go. Change 'Marking Workflow State' dropdown selection to be 'Released' and click 'Save Changes'. Now check in either the grader report or user report. Expected Result: The grade and feedback comment would be present in the Grader Report and User Report, as the workflow status has been set to released. Note: I began to write behat tests but unfortunately, as there is a dialogue box that loads when you select and try to update work flow I cannot write working tests for this unless we alter that page.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35392-master
    • Sprint:
      Team Beards Sprint 3
    • Issue size:
      Small

      Description

      After grading an assignment and providing feedback, if the teacher then goes to the grade book and views the grades in the edit view, the feedback will not be present.
      If the teacher then enters feedback in the grade book, this feedback will not be present in the assignment area.

      The issue here is that in mod/assign/locallib.php there is get_user_grades_for_gradebook() which is doing a check for $assign->feedback instead of the value provided in $assign->feedbacktext. Rather than changing the API, we're changing the code which utilises that API so that we supply $assign->feedback.

      As this is used only by the bulk updating code for when we alter a students current workflow state, the impact and therefore the fix is rather small.

      Replication steps:

      1. Create an assignment with the new assign mod.
      2. Grade a students assignment and type in some feedback.
      3. Go to [Settings ► Grader report], turn on editing and select the graded mark.
      4. Notice that no feedback is shown.
      5. You can enter some feedback here and save it.
      6. Going back to the assign module and viewing the feedback there will show that the text entered from the grade book is not present.

        Attachments

        1. 1.jpg
          1.jpg
          250 kB
        2. 2.jpg
          2.jpg
          285 kB
        3. 3.jpg
          3.jpg
          251 kB
        4. 4.jpg
          4.jpg
          225 kB
        5. 5.jpg
          5.jpg
          323 kB
        6. 6.jpg
          6.jpg
          215 kB

          Issue Links

            Activity

              People

              • Votes:
                64 Vote for this issue
                Watchers:
                38 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Mar/15