Moodle

Some text that is shown at the end of a workshop

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.2
  • Fix Version/s: 2.4
  • Component/s: Workshop
  • Labels:
  • Testing Instructions:
    Hide

    Testing difficulty: trivial

    1. Set up a workshop. No need to submit or assess anything this time. In mod_form, provide some Conclusion for the activity with some images embedded.
    2. TEST: Make sure that when the workshop is closed (you can close it immediately after the setup for the purpose of this testing), the conclusion text is displayed to workshop participants (i.e. both teachers and students).
    3. Duplicate the activity (which makes backup & restore in background).
    4. TEST: Make sure the conclusion text is correctly duplicated including the embedded images.

    Show
    Testing difficulty: trivial 1. Set up a workshop. No need to submit or assess anything this time. In mod_form, provide some Conclusion for the activity with some images embedded. 2. TEST: Make sure that when the workshop is closed (you can close it immediately after the setup for the purpose of this testing), the conclusion text is displayed to workshop participants (i.e. both teachers and students). 3. Duplicate the activity (which makes backup & restore in background). 4. TEST: Make sure the conclusion text is correctly duplicated including the embedded images.
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-35421-conclusion
  • Pull Master Diff URL:

Description

This would be the opposite of the Introduction text on the setting form.

Typical examples might be:

You have finished this activity. Next you should write a blog post reflecting on what you got out of the experience.

or

This activity is now finished. Next you should do ... link to some activity

Issue Links

is blocked by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36086 ERROR: Incorrect number of query parameters. Expected 10, got 0. when entering assessment phase

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Mudrak added a comment -

This is hard to test until MDL-36086 is integrated.

Show
David Mudrak added a comment - This is hard to test until MDL-36086 is integrated.
Hide
Permalink
David Mudrak added a comment -

Submitting a patchset for integration.

Show
David Mudrak added a comment - Submitting a patchset for integration.
Hide
Permalink
Tim Hunt added a comment -

Thank you very much for doing this David. Looks good to me, just two minor niggles:

1. Should there be conclusionformat here: https://github.com/mudrd8mz/moodle/compare/master...MDL-35421-conclusion#diff-2

2. Is length 3 what is normally used for format columns? https://github.com/mudrd8mz/moodle/compare/master...MDL-35421-conclusion#L4R38

Show
Tim Hunt added a comment - Thank you very much for doing this David. Looks good to me, just two minor niggles: 1. Should there be conclusionformat here: https://github.com/mudrd8mz/moodle/compare/master...MDL-35421-conclusion#diff-2 2. Is length 3 what is normally used for format columns? https://github.com/mudrd8mz/moodle/compare/master...MDL-35421-conclusion#L4R38
Hide
Permalink
David Mudrak added a comment -

Thank you for the peer-review Tim.

re 1. No, the restore_decode_content() does not take the format into account. As I understood, it was designed for transformations that do not depend on the format and AFAIK it is used for converting manually inserted URLs only.

re 2. Can't find any docs on it, but yes. 3 or 4 was suggested value, leading to SMALLINT type in SQL. But note that there is no "normally used" even in activity modules. Grepping across install.xml files shows the currently used values vary from 1 to 20.
Hmm, PostgreSQL manual states that SMALLINT should be used only when disk space is the issue which does not apply to this case. So I would probably consider INT(10) if I designed the whole table today. For the matter of this patch, I preferred consistency with existing format columns in that table.

Show
David Mudrak added a comment - Thank you for the peer-review Tim. re 1. No, the restore_decode_content() does not take the format into account. As I understood, it was designed for transformations that do not depend on the format and AFAIK it is used for converting manually inserted URLs only. re 2. Can't find any docs on it, but yes. 3 or 4 was suggested value, leading to SMALLINT type in SQL. But note that there is no "normally used" even in activity modules. Grepping across install.xml files shows the currently used values vary from 1 to 20. Hmm, PostgreSQL manual states that SMALLINT should be used only when disk space is the issue which does not apply to this case. So I would probably consider INT(10) if I designed the whole table today. For the matter of this patch, I preferred consistency with existing format columns in that table.
Hide
Permalink
Tim Hunt added a comment -

1. Oops, I did not read the code properly.

2. You are right.

Thanks.

Show
Tim Hunt added a comment - 1. Oops, I did not read the code properly. 2. You are right. Thanks.
Hide
Permalink
Dan Poltawski added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Dan Poltawski added a comment -

Thanks David, looks great. This has been integrated now.

Show
Dan Poltawski added a comment - Thanks David, looks great. This has been integrated now.
Hide
Permalink
Adrian Greeve added a comment -

Tested.
Verified the inclusion of text and embedded images. I duplicated the activity and text and images were still present.
Passed.

Show
Adrian Greeve added a comment - Tested. Verified the inclusion of text and embedded images. I duplicated the activity and text and images were still present. Passed.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

(not really)

Closing, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!
Hide
Permalink
Mary Cooch added a comment -

removing docs_required label as this is now documented in #6.1 here http://docs.moodle.org/24/en/Workshop_settings

Show
Mary Cooch added a comment - removing docs_required label as this is now documented in #6.1 here http://docs.moodle.org/24/en/Workshop_settings

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: