[MDL-35423] Activity chooser links and toolbox links not correctly created if you don't have a wrapper div called #page-content - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE, MOODLE_26_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-35423~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/bbb291b...MDL-35423-master
Testing Instructions:
Hide

Open a course page

Turn editing on

Ensure that you can open the Activity Chooser

Check for JS errors

Ensure that the resource buttons all work (e.g. show/hide)

Check for JS errors

Check that the correct resources were hidden

Ensure that the section buttons work (e.g. show/hide)

Check for JS errors

Check that the correct sections were hidden

Ensure that activity/resource drag and drop works

Ensure that the activities are constrained to the activity area correctly
Show
Open a course page Turn editing on Ensure that you can open the Activity Chooser Check for JS errors Ensure that the resource buttons all work (e.g. show/hide) Check for JS errors Check that the correct resources were hidden Ensure that the section buttons work (e.g. show/hide) Check for JS errors Check that the correct sections were hidden Ensure that activity/resource drag and drop works Ensure that the activities are constrained to the activity area correctly

The AJAX mod chooser links are not created if you don't have a div#page-content in your theme.

The CSS selectors that it's looking for are defined at the start of this file:

"../course/yui/modchooser/modchooser.js"

changing it to:

PAGECONTENT : 'body',

seems to work and shouldn't impact performance since when used it is narrowed by one of the following:

SECTION : 'li.section',
SITEMENU : 'div.block_site_main_menu',
SITETOPIC : 'div.sitetopic'

blocks

CONTRIB-3915 Can't add activities or resources to OU Module: subpage

Discovered while testing

MDL-43684 Activity drag and drop makes an activity appear "visible" even when it's not.

will be (partly) resolved by

MDL-43167 Frontpage should support the same JavaScript as course pages

will help resolve

MDL-36164 Changing/removing CSS ID and CLASS selector names in theme layouts can silently break a variety of AJAX interactions.

Participants:: Andrew Lyons, CiBoT, Damyon Wiese, Dan Poltawski, David Scotson, Elizabeth Dalton, Eloy Lafuente (stronk7), Jason Platts, Mary Evans, Michael de Raadt, Rajesh Taneja, Sam Marshall, Thanh Le

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona), David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May