Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36164 Changing/removing CSS ID and CLASS selector names in theme layouts can silently break a variety of AJAX interactions.
  3. MDL-35423

Activity chooser links and toolbox links not correctly created if you don't have a wrapper div called #page-content

    XMLWordPrintable

Details

    • MOODLE_23_STABLE, MOODLE_26_STABLE
    • MOODLE_27_STABLE
    • MDL-35423-master
    • Hide
      • Open a course page
      • Turn editing on
      • Ensure that you can open the Activity Chooser
        • Check for JS errors
      • Ensure that the resource buttons all work (e.g. show/hide)
        • Check for JS errors
        • Check that the correct resources were hidden
      • Ensure that the section buttons work (e.g. show/hide)
        • Check for JS errors
        • Check that the correct sections were hidden
      • Ensure that activity/resource drag and drop works
        • Ensure that the activities are constrained to the activity area correctly
      Show
      Open a course page Turn editing on Ensure that you can open the Activity Chooser Check for JS errors Ensure that the resource buttons all work (e.g. show/hide) Check for JS errors Check that the correct resources were hidden Ensure that the section buttons work (e.g. show/hide) Check for JS errors Check that the correct sections were hidden Ensure that activity/resource drag and drop works Ensure that the activities are constrained to the activity area correctly
    • 5

    Description

      The AJAX mod chooser links are not created if you don't have a div#page-content in your theme.

      The CSS selectors that it's looking for are defined at the start of this file:

      "../course/yui/modchooser/modchooser.js"

      changing it to:

      PAGECONTENT : 'body',

      seems to work and shouldn't impact performance since when used it is narrowed by one of the following:

      SECTION : 'li.section',
      SITEMENU : 'div.block_site_main_menu',
      SITETOPIC : 'div.sitetopic'

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              bawjaws David Scotson
              David Scotson David Scotson
              Damyon Wiese Damyon Wiese
              Rajesh Taneja Rajesh Taneja
              Votes:
              4 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.