Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36164 Changing/removing CSS ID and CLASS selector names in theme layouts can silently break a variety of AJAX interactions.
  3. MDL-35423

Activity chooser links and toolbox links not correctly created if you don't have a wrapper div called #page-content

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.6.1
    • Fix Version/s: 2.7
    • Component/s: Course, JavaScript, Themes
    • Labels:
    • Testing Instructions:
      Hide
      • Open a course page
      • Turn editing on
      • Ensure that you can open the Activity Chooser
        • Check for JS errors
      • Ensure that the resource buttons all work (e.g. show/hide)
        • Check for JS errors
        • Check that the correct resources were hidden
      • Ensure that the section buttons work (e.g. show/hide)
        • Check for JS errors
        • Check that the correct sections were hidden
      • Ensure that activity/resource drag and drop works
        • Ensure that the activities are constrained to the activity area correctly
      Show
      Open a course page Turn editing on Ensure that you can open the Activity Chooser Check for JS errors Ensure that the resource buttons all work (e.g. show/hide) Check for JS errors Check that the correct resources were hidden Ensure that the section buttons work (e.g. show/hide) Check for JS errors Check that the correct sections were hidden Ensure that activity/resource drag and drop works Ensure that the activities are constrained to the activity area correctly
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-35423-master
    • Story Points:
      5

      Description

      The AJAX mod chooser links are not created if you don't have a div#page-content in your theme.

      The CSS selectors that it's looking for are defined at the start of this file:

      "../course/yui/modchooser/modchooser.js"

      changing it to:

      PAGECONTENT : 'body',

      seems to work and shouldn't impact performance since when used it is narrowed by one of the following:

      SECTION : 'li.section',
      SITEMENU : 'div.block_site_main_menu',
      SITETOPIC : 'div.sitetopic'

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              bawjaws David Scotson
              Peer reviewer:
              David Scotson
              Integrator:
              Damyon Wiese
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
              Votes:
              4 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14