Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.4
    • Component/s: Themes
    • Labels:
    • Rank:
      44106

      Description

      Right align role names inside course Participants view (registered users)

      BTW,
      It would be visually useful to add a solid 1px border too, so they will look like buttons. Similar to the Enrollment method "buttons".

        Activity

        Show
        Nadav Kavalerchik added a comment - proposed fix: https://github.com/nadavkav/moodle/commit/9afb58aa28438bfa47b9bd7d44a4573f26e7d7a1
        Hide
        Mary Evans added a comment - - edited

        I am sorry Nadav, but in trying to change your latest commits as listed above, I realised too late that you are doing the exact thing that I thought we agreed you would not do. That is pile everything together under one tracker issue.

        What you have done in setting up the META tracker MDL-35244 is the right way to go about it. However, each SUB-TASK should go under it's own tracker number. So MDL-35426 should be a branch on it own NOT a commit in MDL-35244. At least this is how I was taught to do things.

        Show
        Mary Evans added a comment - - edited I am sorry Nadav, but in trying to change your latest commits as listed above, I realised too late that you are doing the exact thing that I thought we agreed you would not do. That is pile everything together under one tracker issue. What you have done in setting up the META tracker MDL-35244 is the right way to go about it. However, each SUB-TASK should go under it's own tracker number. So MDL-35426 should be a branch on it own NOT a commit in MDL-35244 . At least this is how I was taught to do things.
        Hide
        Mary Evans added a comment -

        @Eloy
        If you have a minute, can you let me know if I am giving the correct advice, re: GIT workflow, to Nadav about some important RTL CSS fixes he is committing?

        Thanks

        Show
        Mary Evans added a comment - @Eloy If you have a minute, can you let me know if I am giving the correct advice, re: GIT workflow, to Nadav about some important RTL CSS fixes he is committing? Thanks
        Hide
        Nadav Kavalerchik added a comment -

        @Mary

        The MDL sub-tasks with the commit links are not intended to be used separately.
        I am just linking the commits into each MDL so who ever is separately reviewing them
        can cherry-pick them or get them as patches into their working tree, for testing.

        I was actually expacting who ever is reviewing or integrating MDL-35244 to integrate the entire WIP-MDL-35244_RTL_fixes branch
        These subtasks are not really separate issues. I just seperated them since I keep finding new RTL issues and I wish not to waste time and hold the integration process. that is why I separated each MDL issue and linked it to the relevant commit in the actual META MDL (MDL-35244).

        I can easily convert the commits (links) in each sub-task MDL to separate branches, If it is easier for you to review and integrate. I have no preference.

        btw, who do i bug to review and integrate those issues, so they are not left behind like in the previous Moodle version?

        And...
        I am about to "rebase" all the RTL fixes I made to ALL the themes. How would you suggest I go about it, so it would be easier for you (Moodle HQ) to review and integrate before Moodle 2.4 is freezed?

        Show
        Nadav Kavalerchik added a comment - @Mary The MDL sub-tasks with the commit links are not intended to be used separately. I am just linking the commits into each MDL so who ever is separately reviewing them can cherry-pick them or get them as patches into their working tree, for testing. I was actually expacting who ever is reviewing or integrating MDL-35244 to integrate the entire WIP-MDL-35244_RTL_fixes branch These subtasks are not really separate issues. I just seperated them since I keep finding new RTL issues and I wish not to waste time and hold the integration process. that is why I separated each MDL issue and linked it to the relevant commit in the actual META MDL ( MDL-35244 ). I can easily convert the commits (links) in each sub-task MDL to separate branches, If it is easier for you to review and integrate. I have no preference. btw, who do i bug to review and integrate those issues, so they are not left behind like in the previous Moodle version? And... I am about to "rebase" all the RTL fixes I made to ALL the themes. How would you suggest I go about it, so it would be easier for you (Moodle HQ) to review and integrate before Moodle 2.4 is freezed?
        Hide
        Mary Evans added a comment -

        If the META branch is all ready then I can set it for integration. It is NOT a case of bugging someone. I have to add it to the process. But I cannot do that until you tell me it's ready to go. If the fixes are as you need them to look in RTL then that is good enough for me, I don't have time to Peer Review them. If you can confirm today that MDL-35244 is ready for Integration Review then I can set it up ready for this weekend. Integration begins early on Monday morning in Perth Australia which is about 7 hrs in front of UK. May be 5rs or less in Israel? Is that OK with you?

        So to recap: If you are ready to roll MDL-35244 out then tell me and I'll set it for Integration Review NOW!

        Show
        Mary Evans added a comment - If the META branch is all ready then I can set it for integration. It is NOT a case of bugging someone. I have to add it to the process. But I cannot do that until you tell me it's ready to go. If the fixes are as you need them to look in RTL then that is good enough for me, I don't have time to Peer Review them. If you can confirm today that MDL-35244 is ready for Integration Review then I can set it up ready for this weekend. Integration begins early on Monday morning in Perth Australia which is about 7 hrs in front of UK. May be 5rs or less in Israel? Is that OK with you? So to recap: If you are ready to roll MDL-35244 out then tell me and I'll set it for Integration Review NOW!
        Hide
        Nadav Kavalerchik added a comment -

        Please set it for Integration Review

        I have 7 out of 10 issues, fixed.
        Whatever is left, i will move the the "Next" Meta RTL UI issues list

        Show
        Nadav Kavalerchik added a comment - Please set it for Integration Review I have 7 out of 10 issues, fixed. Whatever is left, i will move the the "Next" Meta RTL UI issues list
        Hide
        Nadav Kavalerchik added a comment -

        Thank you

        Show
        Nadav Kavalerchik added a comment - Thank you
        Hide
        Adrian Greeve added a comment -

        Tested on the master integration branch.
        The alignment has been changed on the enrolled users page. It looks OK to me.

        Show
        Adrian Greeve added a comment - Tested on the master integration branch. The alignment has been changed on the enrolled users page. It looks OK to me.
        Hide
        Dan Poltawski added a comment -

        Congratulations, you've done it!

        Thanks, this change is now in the latest weekly release!

        Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

        Show
        Dan Poltawski added a comment - Congratulations, you've done it! Thanks, this change is now in the latest weekly release! Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: