Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35427

Bad code $_POST = array(); in mod_assign

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      • View the grading table for the assignment
      • Sort the table by lastname (so this bug is not confused with a related one)
      • Click the grade button for the first submission in the table.
      • The single grading page should display and the user should be the same as the first user in the grading table
      • Click on next to move to the next submission - the progress should move to "Grading student 2 of X" and the user information should change to the information for the second user in the grading table
      • Click on previous to move to the previous submission - the progress should move to "Grading student 1 of X" and the user information should change to the information for the first user in the grading table
      Show
      View the grading table for the assignment Sort the table by lastname (so this bug is not confused with a related one) Click the grade button for the first submission in the table. The single grading page should display and the user should be the same as the first user in the grading table Click on next to move to the next submission - the progress should move to "Grading student 2 of X" and the user information should change to the information for the second user in the grading table Click on previous to move to the previous submission - the progress should move to "Grading student 1 of X" and the user information should change to the information for the first user in the grading table
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      Line 1956 of mod/assign/locallib.php is

      $_POST = array();

      How did that get through integration review?!

      I don't know what it is doing, but that is clearly unacceptable and needs to be fixed.

      See also http://moodle.org/mod/forum/discuss.php?d=210844#p921105

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12