Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35427

Bad code $_POST = array(); in mod_assign

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      • View the grading table for the assignment
      • Sort the table by lastname (so this bug is not confused with a related one)
      • Click the grade button for the first submission in the table.
      • The single grading page should display and the user should be the same as the first user in the grading table
      • Click on next to move to the next submission - the progress should move to "Grading student 2 of X" and the user information should change to the information for the second user in the grading table
      • Click on previous to move to the previous submission - the progress should move to "Grading student 1 of X" and the user information should change to the information for the first user in the grading table
      Show
      View the grading table for the assignment Sort the table by lastname (so this bug is not confused with a related one) Click the grade button for the first submission in the table. The single grading page should display and the user should be the same as the first user in the grading table Click on next to move to the next submission - the progress should move to "Grading student 2 of X" and the user information should change to the information for the second user in the grading table Click on previous to move to the previous submission - the progress should move to "Grading student 1 of X" and the user information should change to the information for the first user in the grading table
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      Line 1956 of mod/assign/locallib.php is

      $_POST = array();

      How did that get through integration review?!

      I don't know what it is doing, but that is clearly unacceptable and needs to be fixed.

      See also http://moodle.org/mod/forum/discuss.php?d=210844#p921105

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Hmmmm.

            Show
            salvetore Michael de Raadt added a comment - Hmmmm.
            Hide
            damyon Damyon Wiese added a comment -

            Changed to use $mform->setConstant() to force the rownum to update even when it is different from the value in $_POST.

            Show
            damyon Damyon Wiese added a comment - Changed to use $mform->setConstant() to force the rownum to update even when it is different from the value in $_POST.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Damyon, this will be integrated as soon as I have access to git.moodle.org again.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Damyon, this will be integrated as soon as I have access to git.moodle.org again.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Integrated now thanks

            Show
            samhemelryk Sam Hemelryk added a comment - Integrated now thanks
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested on the master integration branch.
            Navigating from one student to another through the single grading page worked as expected.
            No regressions found.
            Test passed.

            Show
            abgreeve Adrian Greeve added a comment - Tested on the master integration branch. Navigating from one student to another through the single grading page worked as expected. No regressions found. Test passed.
            Hide
            poltawski Dan Poltawski added a comment -

            Congratulations, you've done it!

            Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

            Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

            Show
            poltawski Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12