Moodle
  1. Moodle
  2. MDL-35436

Usability issues for assignment offline grading

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a new course with some enrolled students in it
      2. Create a new assignment with setting 'Feedback settings > Offline grading worksheet' to Yes
      3. Save and display the assignment
      4. Click on 'View/grade all submissions'
      5. Select 'Upload grading worksheet' from the dropdown menu
      6. Upload a CSV file that has invalid and valid inputs in it
      7. All the invalid inputs are not outputted as expected
      Show
      Create a new course with some enrolled students in it Create a new assignment with setting 'Feedback settings > Offline grading worksheet' to Yes Save and display the assignment Click on 'View/grade all submissions' Select 'Upload grading worksheet' from the dropdown menu Upload a CSV file that has invalid and valid inputs in it All the invalid inputs are not outputted as expected
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
    • Rank:
      44117

      Description

      Here are a few comments after the exploratory testing session on MDL-31276.

      Invalid grades should not be outputted

      As the only the last 3 grades are valid, we should not display the other ones.

      Set grade for Bebe Stevens to 125
      Set grade for Kyle Broflovski to abcde
      Set grade for Timmy Burch to 9999999999999
      Set grade for Clyde Donovan to ##
      Set grade for Kenny McCormick to 10*30
      Set grade for Stan Marsh to 0
      Set grade for Jimmy Valmer to 100
      Set grade for Butters Stotch to 76
      

      File naming

      I don't understand the bit with the time in the file name, it was between 1.30pm and 2.30pm and the files were:

      • Grades-Soldier-Assign me-12-20120912_0549-comma_separated.csv
      • Grades-Soldier-Assign me-12-20120912_0605-comma_separated.csv

      What does 0549 or 0605 stand for?

      Also, my +1 for a lowercased file name without special characters such as spaces, etc...

      Confusion on when the grades will be updated

      I was a bit confused (and still am) on when a grade is actually updated when the overwrite checkbox is unticked. Is it required to update the modified time in the CSV? If yes, that probably needs to be explained somewhere and it did not occur to me that I had to edit this value. If not, then I had some random behaviours and cannot tell when the grade will be updated or not.

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          Hi Frédéric,

          Some comments on these suggestions:

          Raymond has a patch for the first issue (do not show invalid grades in the confirmation page) and will post it soon.

          Issue number 2: The time in the filename - this is added by csvlib and is the same everywhere in Moodle that generates a csv (like the grade boook) - the time looks like it is in GMT - but regardless this should be posted as a separate issue against csv lib.

          Issue number 3: Lowercase filename with no spaces - I disagree with this suggestion as the course short name and assignment name are user defined and may contain foreign characters - I would prefer to do as little translation on them as possible to avoid the risk of breaking something for a user in another language. This is also consistent with the filenames used in the gradebook (has course shortname in the filename). It does use clean_filename on the name to ensure it is a valid/safe filename.

          Issue number 4: Confusion about when grades should be updated - if you are confused then the help definitely needs changing. The purpose of the last modified dates is to prevent this:

          Marker A downloads CSV

          Marker B updates a grade for a submission directly in Moodle

          Marker A updates a different grade in the CSV

          Marker A uploads the modified CSV

          Marker B's grade is reset to the version in the CSV when Marker A downloaded it

          The rule is simple - do not modify a grade in Moodle unless the last modified date for the grade in the CSV and in Moodle are the same.

          Show
          Damyon Wiese added a comment - Hi Frédéric, Some comments on these suggestions: Raymond has a patch for the first issue (do not show invalid grades in the confirmation page) and will post it soon. Issue number 2: The time in the filename - this is added by csvlib and is the same everywhere in Moodle that generates a csv (like the grade boook) - the time looks like it is in GMT - but regardless this should be posted as a separate issue against csv lib. Issue number 3: Lowercase filename with no spaces - I disagree with this suggestion as the course short name and assignment name are user defined and may contain foreign characters - I would prefer to do as little translation on them as possible to avoid the risk of breaking something for a user in another language. This is also consistent with the filenames used in the gradebook (has course shortname in the filename). It does use clean_filename on the name to ensure it is a valid/safe filename. Issue number 4: Confusion about when grades should be updated - if you are confused then the help definitely needs changing. The purpose of the last modified dates is to prevent this: Marker A downloads CSV Marker B updates a grade for a submission directly in Moodle Marker A updates a different grade in the CSV Marker A uploads the modified CSV Marker B's grade is reset to the version in the CSV when Marker A downloaded it The rule is simple - do not modify a grade in Moodle unless the last modified date for the grade in the CSV and in Moodle are the same.
          Hide
          Damyon Wiese added a comment -

          Thanks Raymond - this looks good.

          Show
          Damyon Wiese added a comment - Thanks Raymond - this looks good.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

          This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

          This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

          Apologises for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologises for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (master, aka, 24 only), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (master, aka, 24 only), thanks!
          Hide
          Mark Nelson added a comment -

          Test passed. I tried using characters, negative numbers, random symbols, equations and changing the assignment's grade from 100 to a lower value and trying to insert a grade higher than this and was not able to.

          Show
          Mark Nelson added a comment - Test passed. I tried using characters, negative numbers, random symbols, equations and changing the assignment's grade from 100 to a lower value and trying to insert a grade higher than this and was not able to.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          From somewhere within the clouds...

          Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: