Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35437

Removing columns from the offline grading worksheet gives errors on import

    Details

    • Testing Instructions:
      Hide
      1. Create a new course with some enrolled students in it
      2. Create a new assignment with setting 'Feedback settings > Offline grading worksheet' to Yes
      3. Save and display the assignment
      4. Click on 'View/grade all submissions'
      5. From the default worksheet, remove all columns but 'Identifier', 'Grade' and 'Last modified (grade)'
      6. Select 'Upload grading worksheet' from the dropdown menu
      7. Upload the grading worksheet with missing columns
      8. It does not give out any warning/notice as the missing columns have been ignored.
      Show
      Create a new course with some enrolled students in it Create a new assignment with setting 'Feedback settings > Offline grading worksheet' to Yes Save and display the assignment Click on 'View/grade all submissions' From the default worksheet, remove all columns but 'Identifier', 'Grade' and 'Last modified (grade)' Select 'Upload grading worksheet' from the dropdown menu Upload the grading worksheet with missing columns It does not give out any warning/notice as the missing columns have been ignored.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      Here are a few comments after the exploratory testing session on MDL-31276.

      Using a CSV with only the 3 required fields

      From the default worksheet, remove all columns but 'Identifier', 'Grade' and 'Last modified (grade)'

      It generates the following notice as the feedback column was not present. We could perhaps smoothly ignore it.

      Notice: Undefined index: index in /home/fred/www/repositories/im/moodle/mod/assign/feedback/offline/importgradeslib.php on line 164
      
      Call Stack:
          0.0003     663024   1. {main}() /home/fred/www/repositories/im/moodle/mod/assign/view.php:0
          0.2075   52284672   2. assign->view() /home/fred/www/repositories/im/moodle/mod/assign/view.php:53
          0.2075   52285408   3. assign->view_plugin_page() /home/fred/www/repositories/im/moodle/mod/assign/locallib.php:427
          0.2076   52286000   4. assign_feedback_offline->view_page() /home/fred/www/repositories/im/moodle/mod/assign/locallib.php:1668
          0.2076   52286000   5. assign_feedback_offline->upload_grades() /home/fred/www/repositories/im/moodle/mod/assign/feedback/offline/locallib.php:348
          0.2331   54295784   6. moodleform->moodleform() /home/fred/www/repositories/im/moodle/mod/assign/feedback/offline/locallib.php:265
          0.2344   54304904   7. assignfeedback_offline_import_grades_form->definition() /home/fred/www/repositories/im/moodle/lib/formslib.php:191
          0.2774   54610944   8. assignfeedback_offline_grade_importer->next() /home/fred/www/repositories/im/moodle/mod/assign/feedback/offline/importgradesform.php:88
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12