Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.3.2, 2.4
-
Component/s: Libraries
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_23_STABLE, MOODLE_24_STABLE
-
Fixed Branches:MOODLE_22_STABLE, MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:w38_
MDL-35454_m24_bogusmaxsize -
Pull Master Diff URL:
Description
$currentmaxbytes = get_config('moodlecourse', 'maxbytes');
|
if (isset($CFG->maxbytes)) {
|
$choices = get_max_upload_sizes($CFG->maxbytes, 0, 0, $currentmaxbytes);
|
} else {
|
$choices = get_max_upload_sizes(0, 0, 0, $currentmaxbytes);
|
}
|
missing value from get_config() is FALSE.
// If custombytes is given then add it to the list.
|
if (!is_null($custombytes)) {
|
if (is_number($custombytes)) {
|
$custombytes = array((int)$custombytes);
|
}
|
$sizelist = array_unique(array_merge($sizelist, $custombytes));
|
}
|
can not deal with non-array data such as false, this needs to be reworked.