Moodle
  1. Moodle
  2. MDL-35454

installation and phpunit init regression caused by MDL-30667

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.3.2, 2.4
        • Fix Version/s: 2.2.6, 2.3.3
        • Component/s: Libraries
        • Labels:
        • Testing Instructions:
          Hide

          1/ make fresh install - no warnings or notices expected
          2/ init phpunit environment - no warnings or notices expected
          3/ manually inject custom value into plugin config table via set_config('maxbytes', 666, 'moodlecourse');
          4/ verify the custom value is displayed in admin setting for maxbytes

          Show
          1/ make fresh install - no warnings or notices expected 2/ init phpunit environment - no warnings or notices expected 3/ manually inject custom value into plugin config table via set_config('maxbytes', 666, 'moodlecourse'); 4/ verify the custom value is displayed in admin setting for maxbytes
        • Affected Branches:
          MOODLE_23_STABLE, MOODLE_24_STABLE
        • Fixed Branches:
          MOODLE_22_STABLE, MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          w38_MDL-35454_m24_bogusmaxsize
        • Pull Master Diff URL:

          Description

              $currentmaxbytes = get_config('moodlecourse', 'maxbytes');
          		 
              if (isset($CFG->maxbytes)) {
          		 
                  $choices = get_max_upload_sizes($CFG->maxbytes, 0, 0, $currentmaxbytes);
          		 
              } else {
          		 
                  $choices = get_max_upload_sizes(0, 0, 0, $currentmaxbytes);
          		 
              }

          missing value from get_config() is FALSE.

              // If custombytes is given then add it to the list.
          		 
              if (!is_null($custombytes)) {
          		 
                  if (is_number($custombytes)) {
          		 
                      $custombytes = array((int)$custombytes);
          		 
                  }
          		 
                  $sizelist = array_unique(array_merge($sizelist, $custombytes));
          		 
              }

          can not deal with non-array data such as false, this needs to be reworked.

            Gliffy Diagrams

              Issue Links

              is a regression caused by

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30667 Upload maximum settings are not always followed while $CFG->maxbytes is set to a different value

              • Critical - Crashes server, loss of data, severe memory leak
              • Closed
              is duplicated by

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35466 Warning on install/phpunit init related with upload sizes...

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Petr Skoda added a comment -

                Sending for peer-review, I suppose this should be fixed asap.

                Show
                Petr Skoda added a comment - Sending for peer-review, I suppose this should be fixed asap.
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Looks spot on thanks Petr, I hit this issue this morning and tested your fix. Works perfectly.

                Show
                Sam Hemelryk added a comment - Looks spot on thanks Petr, I hit this issue this morning and tested your fix. Works perfectly.
                Hide
                Permalink
                Dan Poltawski added a comment -

                Integrated, thanks

                Show
                Dan Poltawski added a comment - Integrated, thanks
                Hide
                Permalink
                Adrian Greeve added a comment -

                Tested on 2.2, 2.3 and Master integration branches.
                No warnings or notices were seen.
                Custom value for maxbytes was verified.
                Test passed.

                Show
                Adrian Greeve added a comment - Tested on 2.2, 2.3 and Master integration branches. No warnings or notices were seen. Custom value for maxbytes was verified. Test passed.
                Hide
                Permalink
                Dan Poltawski added a comment -

                Congratulations, you've done it!

                Thanks, this change is now in the latest weekly release!

                Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

                Show
                Dan Poltawski added a comment - Congratulations, you've done it! Thanks, this change is now in the latest weekly release! Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: