Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35454

installation and phpunit init regression caused by MDL-30667

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 2.2.6, 2.3.3
    • 2.3.2, 2.4
    • Libraries
    • MOODLE_23_STABLE, MOODLE_24_STABLE
    • MOODLE_22_STABLE, MOODLE_23_STABLE
    • w38_MDL-35454_m24_bogusmaxsize
    • Hide

      1/ make fresh install - no warnings or notices expected
      2/ init phpunit environment - no warnings or notices expected
      3/ manually inject custom value into plugin config table via set_config('maxbytes', 666, 'moodlecourse');
      4/ verify the custom value is displayed in admin setting for maxbytes

      Show
      1/ make fresh install - no warnings or notices expected 2/ init phpunit environment - no warnings or notices expected 3/ manually inject custom value into plugin config table via set_config('maxbytes', 666, 'moodlecourse'); 4/ verify the custom value is displayed in admin setting for maxbytes

    Description

          $currentmaxbytes = get_config('moodlecourse', 'maxbytes');
          if (isset($CFG->maxbytes)) {
              $choices = get_max_upload_sizes($CFG->maxbytes, 0, 0, $currentmaxbytes);
          } else {
              $choices = get_max_upload_sizes(0, 0, 0, $currentmaxbytes);
          }

      missing value from get_config() is FALSE.

          // If custombytes is given then add it to the list.
          if (!is_null($custombytes)) {
              if (is_number($custombytes)) {
                  $custombytes = array((int)$custombytes);
              }
              $sizelist = array_unique(array_merge($sizelist, $custombytes));
          }

      can not deal with non-array data such as false, this needs to be reworked.

      Attachments

        Issue Links

          Activity

            People

              skodak Petr Skoda (Inactive)
              skodak Petr Skoda (Inactive)
              Rajesh Taneja Rajesh Taneja
              Dan Poltawski Dan Poltawski
              Adrian Greeve Adrian Greeve
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.