[MDL-35454] installation and phpunit init regression caused by MDL-30667 - Moodle Tracker

XML

Word

Printable

Testing Instructions:

Hide

1/ make fresh install - no warnings or notices expected
2/ init phpunit environment - no warnings or notices expected
3/ manually inject custom value into plugin config table via set_config('maxbytes', 666, 'moodlecourse');
4/ verify the custom value is displayed in admin setting for maxbytes

Show
1/ make fresh install - no warnings or notices expected 2/ init phpunit environment - no warnings or notices expected 3/ manually inject custom value into plugin config table via set_config('maxbytes', 666, 'moodlecourse'); 4/ verify the custom value is displayed in admin setting for maxbytes
Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Master Branch:
w38_~~MDL-35454~~_m24_bogusmaxsize
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/master...w38_MDL-35454_m24_bogusmaxsize

    $currentmaxbytes = get_config('moodlecourse', 'maxbytes');

    if (isset($CFG->maxbytes)) {

        $choices = get_max_upload_sizes($CFG->maxbytes, 0, 0, $currentmaxbytes);

    } else {

        $choices = get_max_upload_sizes(0, 0, 0, $currentmaxbytes);

missing value from get_config() is FALSE.

    // If custombytes is given then add it to the list.

    if (!is_null($custombytes)) {

        if (is_number($custombytes)) {

            $custombytes = array((int)$custombytes);

        $sizelist = array_unique(array_merge($sizelist, $custombytes));

can not deal with non-array data such as false, this needs to be reworked.

is a regression caused by

MDL-30667 Upload maximum settings are not always followed while $CFG->maxbytes is set to a different value

is duplicated by

MDL-35466 Warning on install/phpunit init related with upload sizes...

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)