Moodle
  1. Moodle
  2. MDL-35465

Cleanup cohorts code and add tests

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: Cohorts, Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      1/ execute phpunit tests (please note the phpunit environment needs to be reinitialised in order to get the phpunit.xml with new suite updated)

      2/ go to cohort admin UI and try all operations there:

      • adding new cohort
      • deleting cohort
      • adding and removing members
      • searching cohorts
      Show
      1/ execute phpunit tests (please note the phpunit environment needs to be reinitialised in order to get the phpunit.xml with new suite updated) 2/ go to cohort admin UI and try all operations there: adding new cohort deleting cohort adding and removing members searching cohorts
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w38_MDL-35465_m24_cohortscleanup

      Description

      There are some coding style problems, tiny bugs and documentation issues in the cohorts related code. We also need unit tests and generators before making any changes and adding new features.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Petr Skoda added a comment -

            If tests fail in Oracle or MSSQL then please create a new issue.

            Show
            Petr Skoda added a comment - If tests fail in Oracle or MSSQL then please create a new issue.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            Andrew Davis added a comment -

            Seems to work fine. I did get some phpunit failures but they seem to be unrelated.

            Show
            Andrew Davis added a comment - Seems to work fine. I did get some phpunit failures but they seem to be unrelated.
            Hide
            Dan Poltawski added a comment -

            Congratulations, you've done it!

            Thanks, this change is now in the latest weekly release!

            Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

            Show
            Dan Poltawski added a comment - Congratulations, you've done it! Thanks, this change is now in the latest weekly release! Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: