Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35489

Notice on Browse Users page when using an empty filter

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3.2
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide
      1. Turn on debugging.
      2. Go to Site Administration > Users > Browse list of users.
      3. Choose "is empty" for one of the filters (like email).
      4. Add the filter and make sure you don't see any notice.
        3 Try "is empty" for other filters and make sure you don't see notice.
      Show
      Turn on debugging. Go to Site Administration > Users > Browse list of users. Choose "is empty" for one of the filters (like email). Add the filter and make sure you don't see any notice. 3 Try "is empty" for other filters and make sure you don't see notice.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      wip-mdl-35489

      Description

      Steps to reproduce:

      1. Turn on debugging.
      2. Go to Site Administration > Browse list of users.
      3. Choose "empty" for one of the filters (like email).
      4. Add the filter.

      You'll get a notice like this: Notice: Undefined property: stdClass::$email in wwwroot/user/filters/text.php on line 65

        Gliffy Diagrams

          Activity

          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for reporting that, Charles.

          Feel free to work with us on the issue.

          Show
          salvetore Michael de Raadt added a comment - Thanks for reporting that, Charles. Feel free to work with us on the issue.
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          Hi Rajesh,
          It looks good.
          Check the following:
          [y] Syntax
          [y] Output
          [y] Whitespace
          [-] Language
          [-] Databases
          [y] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          Does it needs to be backported?

          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - Hi Rajesh, It looks good. Check the following: [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check Does it needs to be backported? Thanks
          Hide
          rajeshtaneja Rajesh Taneja added a comment -

          Yes Ankit,
          I will back-port this, before pushing it for integration.

          Show
          rajeshtaneja Rajesh Taneja added a comment - Yes Ankit, I will back-port this, before pushing it for integration.
          Hide
          nebgor Aparup Banerjee added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          nebgor Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          poltawski Dan Poltawski added a comment -

          Integrated to 22, 23 and master, thanks Raj

          Show
          poltawski Dan Poltawski added a comment - Integrated to 22, 23 and master, thanks Raj
          Hide
          dmonllao David Monllaó added a comment -

          I can't see any noticed. Tested in 22, 23 and master

          Show
          dmonllao David Monllaó added a comment - I can't see any noticed. Tested in 22, 23 and master
          Hide
          poltawski Dan Poltawski added a comment -

          Hurray!

          You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

          Show
          poltawski Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/12