Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Please Note:
      Before TESTING please ensure you have...

      1. Hebrew (he) RTL language pack installed
      2. Category and Course views set in Frontpage settings
      3. Detect Mobile device set in Theme settings
      4. MyMobile theme set as the default for TABLET device
      5. If possible use:
        • a Tablet device (Asus Transformer with Android will gain you some good karma points!!!)
          or...
        • Use Chrome (Developer mode with Overrides set to "Tablet") or...
        • Use Firefox (with "User agent" switcher plugins set to "tablet")

      WHEN TESTING

      • Navigate to Frontpage and TEST that both Course name and Category names are right aligned and clear of adjoining icons.
      Show
      Please Note: Before TESTING please ensure you have... Hebrew (he) RTL language pack installed Category and Course views set in Frontpage settings Detect Mobile device set in Theme settings MyMobile theme set as the default for TABLET device If possible use: a Tablet device (Asus Transformer with Android will gain you some good karma points!!!) or... Use Chrome (Developer mode with Overrides set to "Tablet") or... Use Firefox (with "User agent" switcher plugins set to "tablet") WHEN TESTING Navigate to Frontpage and TEST that both Course name and Category names are right aligned and clear of adjoining icons.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-35510_master

      Description

      Right align course & category names (theme/mymobile) when in RTL mode.
      See attached screen capture of Moodle's front page, in RTL mode (Language= Hebrew) and also proposed fix in attached image filename MDL-35510_categorybox.jpg

        Gliffy Diagrams

        1. bonfire-screenshot-20120918-183049-027.png
          87 kB
        2. ipad.png
          30 kB
        3. mdl-35510.jpg
          48 kB
        4. MDL-35510-categorybox.jpg
          34 kB

          Activity

          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment - - edited

          I've tried this both under Safari (setting User Agent both to ipad and iphone) and directly in the iPad.

          And, while I get the texts right-aligned... they overlap the "circles" (screenshot attached: "ipad.png").

          So I'm reopening this, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - - edited I've tried this both under Safari (setting User Agent both to ipad and iphone) and directly in the iPad. And, while I get the texts right-aligned... they overlap the "circles" (screenshot attached: "ipad.png"). So I'm reopening this, thanks!
          Hide
          nadavkav Nadav Kavalerchik added a comment -

          Well...
          We'll have to get some Apple developer help, since I use Linux and I do not have Safari or an iPad.

          Show
          nadavkav Nadav Kavalerchik added a comment - Well... We'll have to get some Apple developer help, since I use Linux and I do not have Safari or an iPad.
          Hide
          cibot CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          lazydaisy Mary Evans added a comment - - edited

          @Nadav If you add a right margin of about 1em

          .dir-rtl .ui-btn-text {padding-right: 20px;}

          it should fix this.

          Show
          lazydaisy Mary Evans added a comment - - edited @Nadav If you add a right margin of about 1em .dir-rtl .ui-btn-text {padding-right: 20px;} it should fix this.
          Hide
          lazydaisy Mary Evans added a comment -

          @Nadav,

          I can fix this if you prefer. No problem.

          Mary

          Show
          lazydaisy Mary Evans added a comment - @Nadav, I can fix this if you prefer. No problem. Mary
          Hide
          nadavkav Nadav Kavalerchik added a comment -

          @Mary
          Love to!
          Thanks

          Show
          nadavkav Nadav Kavalerchik added a comment - @Mary Love to! Thanks
          Hide
          lazydaisy Mary Evans added a comment -

          I've fixed this and look ok to me, but not sure if a previous fix is adding to another problem, with the categorybox

          Categories have a black circle which contains the 'count' number of courses for teach category listed. This 'count' number has CSS

          .dir-rtl .ui-li-count { left:38px; right:auto;}

          This seems to heve the effect of dragging out the black circle making it look like a black 'pill' shaped background to the category title. Which looks odd. So this will need a new MDL to fix it. See attached image.

          Show
          lazydaisy Mary Evans added a comment - I've fixed this and look ok to me, but not sure if a previous fix is adding to another problem, with the categorybox Categories have a black circle which contains the 'count' number of courses for teach category listed. This 'count' number has CSS .dir-rtl .ui-li-count { left:38px; right:auto;} This seems to heve the effect of dragging out the black circle making it look like a black 'pill' shaped background to the category title. Which looks odd. So this will need a new MDL to fix it. See attached image.
          Hide
          lazydaisy Mary Evans added a comment - - edited

          Uploaded image attachment MDL-35510.jpg

          Show
          lazydaisy Mary Evans added a comment - - edited Uploaded image attachment MDL-35510 .jpg
          Hide
          lazydaisy Mary Evans added a comment - - edited

          On the other hand, if I delete the CSS rule for the count

          .dir-rtl .ui-li-count { left:38px; right:auto;}

          and add fixes for the category box to the fixes for .coursbox like so...

          .dir-rtl .categorybox .ui-btn-inner,
          .dir-rtl .coursebox .ui-btn-inner {text-align: right;}
           
          .dir-rtl .categorybox .ui-btn-text,
          .dir-rtl .coursebox .ui-btn-text {padding-right: 25px;}

          I get this view as can be seen in MDL-35510-categorybox.jpg (see attached)

          Show
          lazydaisy Mary Evans added a comment - - edited On the other hand, if I delete the CSS rule for the count .dir-rtl .ui-li-count { left:38px; right:auto;} and add fixes for the category box to the fixes for .coursbox like so... .dir-rtl .categorybox .ui-btn-inner, .dir-rtl .coursebox .ui-btn-inner {text-align: right;}   .dir-rtl .categorybox .ui-btn-text, .dir-rtl .coursebox .ui-btn-text {padding-right: 25px;} I get this view as can be seen in MDL-35510 -categorybox.jpg (see attached)
          Hide
          lazydaisy Mary Evans added a comment -

          @Nadav
          What do you think? Shall I go for it?

          Show
          lazydaisy Mary Evans added a comment - @Nadav What do you think? Shall I go for it?
          Hide
          nadavkav Nadav Kavalerchik added a comment -

          Looks great!

          Show
          nadavkav Nadav Kavalerchik added a comment - Looks great!
          Hide
          lazydaisy Mary Evans added a comment -

          I just had a major catastrophe I made change to my MOODLE_23_STABLE branch by mistake, it's taken me ages to get back on track!

          Hopefully this will get integrated soon.

          Show
          lazydaisy Mary Evans added a comment - I just had a major catastrophe I made change to my MOODLE_23_STABLE branch by mistake, it's taken me ages to get back on track! Hopefully this will get integrated soon.
          Hide
          nadavkav Nadav Kavalerchik added a comment -

          We all been there Hope you are out of the swamp safe and dry on solid ground!

          Show
          nadavkav Nadav Kavalerchik added a comment - We all been there Hope you are out of the swamp safe and dry on solid ground!
          Hide
          nebgor Aparup Banerjee added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          nebgor Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          poltawski Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          lazydaisy Mary Evans added a comment -

          REBASED BOTH BRANCHES

          Show
          lazydaisy Mary Evans added a comment - REBASED BOTH BRANCHES
          Hide
          nebgor Aparup Banerjee added a comment -

          Thanks, thats been integrated. Davmon to test!

          Show
          nebgor Aparup Banerjee added a comment - Thanks, thats been integrated. Davmon to test!
          Hide
          markn Mark Nelson added a comment -

          Works as expected. Passed.

          Show
          markn Mark Nelson added a comment - Works as expected. Passed.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

          (not really)

          Closing, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/12