Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35581 META: tasks related to RTL theme fixes before 2.4 freeze (Week 39)
  3. MDL-35512

Two left pointing arrows appear after clicking "left indent activity/resource" arrow, when in RTL mode

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.3.2, 2.4
    • 2.3.3
    • Themes
    • MOODLE_23_STABLE, MOODLE_24_STABLE
    • MOODLE_23_STABLE
    • WIP-MDL-35512
    • Hide

      See the issue

      1. Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle
      2. Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting)
      3. Navigate into a course which has some resources and activities
      4. Switch to "Edit" mode
      5. Now, that you are in RTL mode, click the "left" indent arrow to indent the element to the left, which should add a "right" indent arrow to the right side of the "left" indent arrow.

      Two "right" indent arrows appear, incorrectly!

      See the fix

      1. Apply the patch (fix) for this issue.
      2. Switch to Design Mode (Home / ► Site administration / ► Appearance / ► Themes / ► Theme settings)
        or by adding the following line to the config.php file 

        $CFG->themedesignermode = true;

      3. You might need to turn off JavaScript caching (Home / ► Site administration / ► Appearance / ► AJAX and Javascript)
        or by adding the following line to the config.php file 

        $CFG->cachejs = false;

        since this fix relate to YUI3 Java Script code

      4. Navigate into a course which has some resources and activities
      5. Switch to "Edit" mode
      6. Now, that you are in RTL mode, click the "left" indent arrow to indent the element to the left, which should add a "right" indent arrow to the right side of the "left" indent arrow.
      7. Click the left/right indent arrows to see that the appear and disappear correctly.
      8. Switch to LTR (English) language
      9. Now, that you are in LTR mode, click the "right" indent arrow to indent the element to the right, which should add a "left" indent arrow to the left side of the "right" indent arrow.
      10. Click the left/right indent arrows to see that the appear and disappear correctly.
      Show
      See the issue Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting) Navigate into a course which has some resources and activities Switch to "Edit" mode Now, that you are in RTL mode, click the "left" indent arrow to indent the element to the left, which should add a "right" indent arrow to the right side of the "left" indent arrow. Two "right" indent arrows appear, incorrectly! See the fix Apply the patch (fix) for this issue. Switch to Design Mode (Home / ► Site administration / ► Appearance / ► Themes / ► Theme settings) or by adding the following line to the config.php file $CFG->themedesignermode = true; You might need to turn off JavaScript caching (Home / ► Site administration / ► Appearance / ► AJAX and Javascript) or by adding the following line to the config.php file $CFG->cachejs = false; since this fix relate to YUI3 Java Script code Navigate into a course which has some resources and activities Switch to "Edit" mode Now, that you are in RTL mode, click the "left" indent arrow to indent the element to the left, which should add a "right" indent arrow to the right side of the "left" indent arrow. Click the left/right indent arrows to see that the appear and disappear correctly. Switch to LTR (English) language Now, that you are in LTR mode, click the "right" indent arrow to indent the element to the right, which should add a "left" indent arrow to the left side of the "right" indent arrow. Click the left/right indent arrows to see that the appear and disappear correctly.

    Description

      While Editing course in RTL UI mode...
      Clicking the "left indent activity or resource arrow", moves the activity or resource to the left and (wrongly) add another "left arrow" instead of a "right pointing arrow".

      clicking the right "left pointing arrow" will indent the activity or resource to the right (as it should)

      Only the icon point to the wrong direction
      The action is correct.

      Attachments

        Activity

          People

            nadavkav Nadav Kavalerchik
            nadavkav Nadav Kavalerchik
            Aparup Banerjee Aparup Banerjee
            Aparup Banerjee Aparup Banerjee
            Huong Nguyen, Bas Brands, Mathew May
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              12/Nov/12