Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35581 META: tasks related to RTL theme fixes before 2.4 freeze (Week 39)
  3. MDL-35512

Two left pointing arrows appear after clicking "left indent activity/resource" arrow, when in RTL mode

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      See the issue

      1. Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle
      2. Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting)
      3. Navigate into a course which has some resources and activities
      4. Switch to "Edit" mode
      5. Now, that you are in RTL mode, click the "left" indent arrow to indent the element to the left, which should add a "right" indent arrow to the right side of the "left" indent arrow.

      Two "right" indent arrows appear, incorrectly!

      See the fix

      1. Apply the patch (fix) for this issue.
      2. Switch to Design Mode (Home / ► Site administration / ► Appearance / ► Themes / ► Theme settings)
        or by adding the following line to the config.php file

        $CFG->themedesignermode = true;

      3. You might need to turn off JavaScript caching (Home / ► Site administration / ► Appearance / ► AJAX and Javascript)
        or by adding the following line to the config.php file

        $CFG->cachejs = false;

        since this fix relate to YUI3 Java Script code

      4. Navigate into a course which has some resources and activities
      5. Switch to "Edit" mode
      6. Now, that you are in RTL mode, click the "left" indent arrow to indent the element to the left, which should add a "right" indent arrow to the right side of the "left" indent arrow.
      7. Click the left/right indent arrows to see that the appear and disappear correctly.
      8. Switch to LTR (English) language
      9. Now, that you are in LTR mode, click the "right" indent arrow to indent the element to the right, which should add a "left" indent arrow to the left side of the "right" indent arrow.
      10. Click the left/right indent arrows to see that the appear and disappear correctly.
      Show
      See the issue Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting) Navigate into a course which has some resources and activities Switch to "Edit" mode Now, that you are in RTL mode, click the "left" indent arrow to indent the element to the left, which should add a "right" indent arrow to the right side of the "left" indent arrow. Two "right" indent arrows appear, incorrectly! See the fix Apply the patch (fix) for this issue. Switch to Design Mode (Home / ► Site administration / ► Appearance / ► Themes / ► Theme settings) or by adding the following line to the config.php file $CFG->themedesignermode = true; You might need to turn off JavaScript caching (Home / ► Site administration / ► Appearance / ► AJAX and Javascript) or by adding the following line to the config.php file $CFG->cachejs = false; since this fix relate to YUI3 Java Script code Navigate into a course which has some resources and activities Switch to "Edit" mode Now, that you are in RTL mode, click the "left" indent arrow to indent the element to the left, which should add a "right" indent arrow to the right side of the "left" indent arrow. Click the left/right indent arrows to see that the appear and disappear correctly. Switch to LTR (English) language Now, that you are in LTR mode, click the "right" indent arrow to indent the element to the right, which should add a "left" indent arrow to the left side of the "right" indent arrow. Click the left/right indent arrows to see that the appear and disappear correctly.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      WIP-MDL-35512

      Description

      While Editing course in RTL UI mode...
      Clicking the "left indent activity or resource arrow", moves the activity or resource to the left and (wrongly) add another "left arrow" instead of a "right pointing arrow".

      clicking the right "left pointing arrow" will indent the activity or resource to the right (as it should)

      Only the icon point to the wrong direction
      The action is correct.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting this, Nadav.

            Feel free to work with us on the issue.

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting this, Nadav. Feel free to work with us on the issue.
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Fixed it please review

            Show
            nadavkav Nadav Kavalerchik added a comment - Fixed it please review
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Sorry, but this is conflicting, so I've to reopen it.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Sorry, but this is conflicting, so I've to reopen it.
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            fixed (reabsed over recent "master")

            Show
            nadavkav Nadav Kavalerchik added a comment - fixed (reabsed over recent "master")
            Hide
            cibot CiBoT added a comment -

            Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

            Show
            cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Eloy,
            I have rebased it over latest (29-9-2012) moodle.org/master
            please see if you can integrate it

            Show
            nadavkav Nadav Kavalerchik added a comment - Eloy, I have rebased it over latest (29-9-2012) moodle.org/master please see if you can integrate it
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            I have rebased (6-10-2012) and added Moodle 2.3 fix too

            Show
            nadavkav Nadav Kavalerchik added a comment - I have rebased (6-10-2012) and added Moodle 2.3 fix too
            Hide
            nebgor Aparup Banerjee added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            nebgor Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Eloy,
            I have rebased it over latest (19-10-2012) moodle.org/master
            please see if you can integrate it

            Show
            nadavkav Nadav Kavalerchik added a comment - Eloy, I have rebased it over latest (19-10-2012) moodle.org/master please see if you can integrate it
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            Rebased over latest (1-11-2012) moodle.org/master
            please see if you can integrate it

            Show
            nadavkav Nadav Kavalerchik added a comment - Rebased over latest (1-11-2012) moodle.org/master please see if you can integrate it
            Hide
            nebgor Aparup Banerjee added a comment -

            Thanks, this has been integrated into 23 and master.

            Tested -> all good!
            Passed! <- Setting this to

            Show
            nebgor Aparup Banerjee added a comment - Thanks, this has been integrated into 23 and master. Tested -> all good! Passed! <- Setting this to
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

            (not really)

            Closing, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12