Moodle
  1. Moodle
  2. MDL-35518

Fatal error: Call to private method assign::get_renderer() when uploading grading worksheet

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Blocker Blocker
        • Resolution: Fixed
        • Affects Version/s: 2.4
        • Fix Version/s: 2.4
        • Component/s: Assignment
        • Labels:
        • Testing Instructions:
          Hide
          1. Create a new course with some enrolled students in it
          2. Create a new assignment with setting 'Feedback settings > Offline grading worksheet' to Yes
          3. Save and display the assignment
          4. Click on 'View/grade all submissions'
          5. Select 'Upload grading worksheet' from the dropdown menu
          6. It takes you to the upload file page and doesn't give you any error/warning message
          Show
          Create a new course with some enrolled students in it Create a new assignment with setting 'Feedback settings > Offline grading worksheet' to Yes Save and display the assignment Click on 'View/grade all submissions' Select 'Upload grading worksheet' from the dropdown menu It takes you to the upload file page and doesn't give you any error/warning message
        • Affected Branches:
          MOODLE_24_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE
        • Pull from Repository:
        • Pull Master Branch:
        • Pull Master Diff URL:
        • Rank:
          44229

          Description

          Fatal error: Call to private method assign::get_renderer() when uploading grading worksheet
          This error is thrown as the result of calling a private function in assign/offline/locallib.php when uploading grading worksheet
          The steps to replicate:

          1. Create a new course with some enrolled students in it
          2. Create a new assignment with setting 'Feedback settings > Offline grading worksheet' to Yes
          3. Save and display the assignment
          4. Click on 'View/grade all submissions'
          5. Select 'Upload grading worksheet' from the dropdown menu
          6. It gives you the above error message

            Issue Links

            discovered while testing

            Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35436 Usability issues for assignment offline grading

            • Minor - Minor loss of function where workaround is possible
            • Closed
            is a regression caused by

            Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35388 Cannot run PHP unit tests for the new assignment module web services

            • Critical - Crashes server, loss of data, severe memory leak
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Damyon Wiese added a comment -

              This renderer should be public to allow the plugins to render common parts of the assignment interface in their own pages.

              Show
              Damyon Wiese added a comment - This renderer should be public to allow the plugins to render common parts of the assignment interface in their own pages.
              Hide
              Permalink
              Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              Permalink
              Raymond Antonio added a comment -

              Hi Dan
              Rebase done. Cheers

              Show
              Raymond Antonio added a comment - Hi Dan Rebase done. Cheers
              Hide
              Permalink
              Dan Poltawski added a comment -

              Integrated to 2.4, thanks Raymond!

              Show
              Dan Poltawski added a comment - Integrated to 2.4, thanks Raymond!
              Hide
              Permalink
              Adrian Greeve added a comment -

              Tested on the integration and normal branches.
              First I replicated the error, then I checked integration.
              No errors found and the upload a file page was displayed.
              Test passed.

              Show
              Adrian Greeve added a comment - Tested on the integration and normal branches. First I replicated the error, then I checked integration. No errors found and the upload a file page was displayed. Test passed.
              Hide
              Permalink
              Dan Poltawski added a comment -

              Congratulations, you've done it!

              Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

              Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

              Show
              Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: