Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35519

Cancelling a book chapter import takes you to the wrong URL

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Book
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      Create a book resource including creating the first chapter.
      Click on "import chapter" under book administration.
      Click "cancel" and check that you're returned to viewing the book resource.

      Show
      Create a book resource including creating the first chapter. Click on "import chapter" under book administration. Click "cancel" and check that you're returned to viewing the book resource.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-35519_book_cancel

      Description

      If you create a book resource then go to book administration > import chapter and click cancel it takes you to the wrong URL. From http://localhost/moodle/int/master/mod/book/tool/importhtml/index.php?id=70 the cancel button sends me to http://localhost/mod/book/view.php?id=70

      Part of the URL has been left out.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              andyjdavis Andrew Davis added a comment -

              Putting this up for peer review.

              Show
              andyjdavis Andrew Davis added a comment - Putting this up for peer review.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Looks good thanks Andrew, clear to go up when you want.

              Show
              samhemelryk Sam Hemelryk added a comment - Looks good thanks Andrew, clear to go up when you want.
              Hide
              andyjdavis Andrew Davis added a comment -

              Created a branch for 2.3. Putting this up for integration.

              Show
              andyjdavis Andrew Davis added a comment - Created a branch for 2.3. Putting this up for integration.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated (23 & master), thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (23 & master), thanks!
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Tested on 2.3 and 2.4.

              It works as expected.

              Test passed.

              Show
              rwijaya Rossiani Wijaya added a comment - Tested on 2.3 and 2.4. It works as expected. Test passed.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              From somewhere within the clouds...

              Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

              Ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12