Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Install an Hebrew (RTL) language pack, and switch to Hebrew
      2. Navigate to any course and turn on Editing mode
        1. Click the "Activity picker" inside any Topic
        2. Click the "Question Bank" link on the Navigation Menu and then Click the "Question Selector" button
          See the issues listed above (Description section)
      3. Apply the patch
      4. Reload the page and verify the issue is solved (Make sure "Theme Designer" mode is ON, so changes are applied)
      Show
      Install an Hebrew (RTL) language pack, and switch to Hebrew Navigate to any course and turn on Editing mode Click the "Activity picker" inside any Topic Click the "Question Bank" link on the Navigation Menu and then Click the "Question Selector" button See the issues listed above (Description section) Apply the patch Reload the page and verify the issue is solved (Make sure "Theme Designer" mode is ON, so changes are applied)
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      WIP-MDL-35527
    • Rank:
      44238

      Description

      Left justify the close button and right justify the headers in the following in RTL mode:

      • Activity picker
      • New question selector

        Issue Links

          Activity

          Hide
          Mary Evans added a comment -

          I don't see this as an issue, as people who read from right to left are on the whole right handed and so use a mouse like the rest of us so the X is in the right place!

          Show
          Mary Evans added a comment - I don't see this as an issue, as people who read from right to left are on the whole right handed and so use a mouse like the rest of us so the X is in the right place!
          Hide
          Mary Evans added a comment -

          @Nadav can you comment about this issue? Thanks

          Show
          Mary Evans added a comment - @Nadav can you comment about this issue? Thanks
          Hide
          Nadav Kavalerchik added a comment -

          It could be very nice (consistency wise) to have the "close" button moved to the left side, though it does not block the dialog's title from being read ( as on other issues: MDL-35248 )
          I'll fix it. and update this issue.

          Show
          Nadav Kavalerchik added a comment - It could be very nice (consistency wise) to have the "close" button moved to the left side, though it does not block the dialog's title from being read ( as on other issues: MDL-35248 ) I'll fix it. and update this issue.
          Hide
          Nadav Kavalerchik added a comment -

          Title's text can be stay centered and should not move right. I think. maybe...

          Show
          Nadav Kavalerchik added a comment - Title's text can be stay centered and should not move right. I think. maybe...
          Hide
          Nadav Kavalerchik added a comment -

          Dan, i have proposed a fix for this issue. please check it

          Show
          Nadav Kavalerchik added a comment - Dan, i have proposed a fix for this issue. please check it
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (23 and master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (23 and master), thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Both dialogues show the close button upper-left under rtl, passing!

          Show
          Eloy Lafuente (stronk7) added a comment - Both dialogues show the close button upper-left under rtl, passing!
          Hide
          Dan Poltawski added a comment -

          Congratulations, you've done it!

          Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

          Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

          Show
          Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: