Moodle
  1. Moodle
  2. MDL-35530

Question Text missing when grading Essay question in Lesson activity

    Details

    • Testing Instructions:
      Hide
      1. Create a Lesson activity and add a page of type Essay.
      2. Enter a questions and save the lesson.
      3. Log in as a student and take the lesson.
      4. Log in as a teacher/admin click the Grade Essays tab.
      5. Click the essay attempt

      Make sure the essay question is display.

      Show
      Create a Lesson activity and add a page of type Essay. Enter a questions and save the lesson. Log in as a student and take the lesson. Log in as a teacher/admin click the Grade Essays tab. Click the essay attempt Make sure the essay question is display.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      In 1.9.x when grading Essay questions included in a Lesson activity the question text was displayed in a block. This is not the case in 2.2.3 (see attached). The Student response is visible but no the question text.

      To recreate:

      1. Create a Lesson activity and add a page of type Essay.
      2. Enter a questions and save the lesson.
      3. Log in as a student and take the lesson.
      4. Log in as a teacher/admin click the Grade Essays tab.
      5. Click the essay attempt

      Expected result: The essay question should be displayed

      Actual result: The grading screen has the student response but not the essay question text.

        Gliffy Diagrams

          Activity

          Hide
          Miguel Santos added a comment -

          The Stuent response shows but there is no reference to the original question.

          Adding the question text would facilitate grading.

          Show
          Miguel Santos added a comment - The Stuent response shows but there is no reference to the original question. Adding the question text would facilitate grading.
          Hide
          Michael de Raadt added a comment -

          Thanks for suggesting that.

          Feel free to work with us on the issue.

          Show
          Michael de Raadt added a comment - Thanks for suggesting that. Feel free to work with us on the issue.
          Hide
          Ankit Agarwal added a comment -

          Hi Rosie this looks good,
          Tested on master as well works as expected.
          [y] Syntax
          [y] Output
          [y] Whitespace
          [y] Language
          [na] Databases
          [y] Testing
          [na] Security
          [na] Documentation
          [y] Git
          [y] Sanity check

          Thanks

          Show
          Ankit Agarwal added a comment - Hi Rosie this looks good, Tested on master as well works as expected. [y] Syntax [y] Output [y] Whitespace [y] Language [na] Databases [y] Testing [na] Security [na] Documentation [y] Git [y] Sanity check Thanks
          Hide
          Rossiani Wijaya added a comment -

          Thanks Ankit for reviewing.

          Submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Thanks Ankit for reviewing. Submitting for integration review.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          This has been integrated now, for next time guys please ensure that you provide at least the context option to any format_string/format_text calls.
          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - This has been integrated now, for next time guys please ensure that you provide at least the context option to any format_string/format_text calls. Many thanks Sam
          Hide
          Andrew Davis added a comment -

          Works as described. Passing.

          Show
          Andrew Davis added a comment - Works as described. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Changes are now upstream, thanks for your collaboration!

          If you are going to have any celebration next days, enjoy with your gang, if not, too!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Changes are now upstream, thanks for your collaboration! If you are going to have any celebration next days, enjoy with your gang, if not, too! Ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: