Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3, 2.4
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      See the issue

      1. Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle
      2. Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting)
      3. Logout from Moodle and navigate to http://your-moodle/login (or click "register a new user" from the login block on the front page.

      The right side "registration" instruction are left justified, incorrectly! ( as seen in the attached screenshot )

      See the fix

      1. Apply the patch (fix) for this issue.
      2. Switch to Design Mode (Home / ► Site administration / ► Appearance / ► Themes / ► Theme settings) or by adding the following line to the config.php file
        $CFG->themedesignermode = true;
      3. Make sure you are still in RTL mode or switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting)
      4. Logout from Moodle and navigate to http://your-moodle/login (or click "register a new user" from the login block on the front page.

      The right side "registration" instruction are right justified, correctly

      Show
      See the issue Add an RTL language package (Hebrew or Arabic or Farsi...) to Moodle Switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting) Logout from Moodle and navigate to http://your-moodle/login (or click "register a new user" from the login block on the front page. The right side "registration" instruction are left justified, incorrectly! ( as seen in the attached screenshot ) See the fix Apply the patch (fix) for this issue. Switch to Design Mode (Home / ► Site administration / ► Appearance / ► Themes / ► Theme settings) or by adding the following line to the config.php file $CFG->themedesignermode = true ; Make sure you are still in RTL mode or switch to the RTL language you have installed by navigating to Moodle's Front-page and choosing it from the Language menu (or add "&lang=he" to the end of the URL you are currently using. If inside a course, set the RTL language from the course's setting) Logout from Moodle and navigate to http://your-moodle/login (or click "register a new user" from the login block on the front page. The right side "registration" instruction are right justified, correctly
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      WIP-MDL-35537
    • Rank:
      44249

      Description

      Right align registration text on login page, when in RTL mode (login/index.php)

        Activity

        Hide
        Mary Evans added a comment - - edited

        Nadav I have just set this for Integration Review. I will get all the others done tomorrow. Please can you add Test Instructions to this and the others that you have been adding these last few days? They will all need re-basing too.
        Thanks

        Show
        Mary Evans added a comment - - edited Nadav I have just set this for Integration Review. I will get all the others done tomorrow. Please can you add Test Instructions to this and the others that you have been adding these last few days? They will all need re-basing too. Thanks
        Hide
        Nadav Kavalerchik added a comment -

        Just added Test Instructions. Hope they make sense.

        Show
        Nadav Kavalerchik added a comment - Just added Test Instructions. Hope they make sense.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (22, 23 and master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 and master), thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Tested while reviewing under 22_STABLE and master. The self-registration pane now is properly right-aligned for rtl langs.

        Passing.

        Show
        Eloy Lafuente (stronk7) added a comment - Tested while reviewing under 22_STABLE and master. The self-registration pane now is properly right-aligned for rtl langs. Passing.
        Hide
        Dan Poltawski added a comment -

        Congratulations, you've done it!

        Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

        Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

        Show
        Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: