Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35556

Improve user completion data permission checking

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Enable course completion site-wide in advanced settings.
      Create a new course with completion enabled.
      Enrol multiple users in the course.
      Apply some criteria to the course view the Completion Tracking course settings page.
      Add the Course Completion Status block to the course.
      Login as a user and check they can view the report linked to in the bottom of the block (the "Details" link).
      Modify the URL to include a different user's id (append ?user=x to url), make sure a student can not view another students report.
      Create a teacher for the course and logged in as them visit the reports from previous steps. Teachers should be able to view these reports.

      Show
      Enable course completion site-wide in advanced settings. Create a new course with completion enabled. Enrol multiple users in the course. Apply some criteria to the course view the Completion Tracking course settings page. Add the Course Completion Status block to the course. Login as a user and check they can view the report linked to in the bottom of the block (the "Details" link). Modify the URL to include a different user's id (append ?user=x to url), make sure a student can not view another students report. Create a teacher for the course and logged in as them visit the reports from previous steps. Teachers should be able to view these reports.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Improve and encapsulate the logic around checking if a user's completion information for a course is viewable by the logged in user.

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-37542 Navigation is broken in course completion report when focussed on a single student

          • Minor - Minor loss of function where workaround is possible
          • Open

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-37537 Course completion report includes a string error

          • Major - Major loss of function, incorrect output
          • Closed
          has a QA test

          Improvement - An enhancement to an existing Moodle feature. MDL-35386 Update Course Completion report to include more useful information

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              sry_not4sale Aaron Barnes
              Reporter:
              sry_not4sale Aaron Barnes
              Peer reviewer:
              Sam Hemelryk
              Integrator:
              Dan Poltawski
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13