Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: HTML Editor (TinyMCE)
    • Labels:
    • Testing Instructions:
      Hide

      1/ switch to any non-english language with some translated tinymce strings
      2/ try all our custom tinymce plugins (see the admin UI for list of our plugins)
      3/ add a line with one bogus button to tinymce toolbar configuration and verify the editor is not borked

      Show
      1/ switch to any non-english language with some translated tinymce strings 2/ try all our custom tinymce plugins (see the admin UI for list of our plugins) 3/ add a line with one bogus button to tinymce toolbar configuration and verify the editor is not borked
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w39_MDL-35561_m24_tinymce357

      Description

      this should finally verify no changes are necessary any more when importing new version....

      changelog: http://www.tinymce.com/develop/changelog/index.php?type=tinymce

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              skodak Petr Skoda added a comment -

              ARRRGGHH, I have previously imported 3.5.6 as "3.6.0"!

              Show
              skodak Petr Skoda added a comment - ARRRGGHH, I have previously imported 3.5.6 as "3.6.0"!
              Hide
              poltawski Dan Poltawski added a comment -

              Ooops, I integrated it too, and the commit message said 'import TinyMCE 3.6.0' too.

              Show
              poltawski Dan Poltawski added a comment - Ooops, I integrated it too, and the commit message said 'import TinyMCE 3.6.0' too.
              Hide
              poltawski Dan Poltawski added a comment -

              This bad import was on master only, at least.

              Show
              poltawski Dan Poltawski added a comment - This bad import was on master only, at least.
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated, thanks!

              [Note to self: dont do cvs update this week :P]

              Show
              poltawski Dan Poltawski added a comment - Integrated, thanks! [Note to self: dont do cvs update this week :P]
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Bogus button doesn't break tinymce and title is translated.

              FYI:
              Tinymce html settings show plugins are enabled even though corresponding filters are disabled. Should we be showing some kind of message and disable corresponding plugins? Also, add status column, saying enable filter to active them?
              Example:
              moodleemoticon is not visible, if emoticon filter is disabled.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Bogus button doesn't break tinymce and title is translated. FYI: Tinymce html settings show plugins are enabled even though corresponding filters are disabled. Should we be showing some kind of message and disable corresponding plugins? Also, add status column, saying enable filter to active them? Example: moodleemoticon is not visible, if emoticon filter is disabled.
              Hide
              skodak Petr Skoda added a comment -

              Thanks for reminding, I have created a new issue for it.

              Show
              skodak Petr Skoda added a comment - Thanks for reminding, I have created a new issue for it.
              Hide
              poltawski Dan Poltawski added a comment -

              Congratulations, you've done it!

              Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

              Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

              Show
              poltawski Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12