Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3, 2.4
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Install an Hebrew (RTL) language pack, and switch to Hebrew
      2. Navigate to "Course setting page" to view the issue (as described in the attached screen capture)
      3. Apply the patch
      4. Reload the page and verify the issue is solved
      Show
      Install an Hebrew (RTL) language pack, and switch to Hebrew Navigate to "Course setting page" to view the issue (as described in the attached screen capture) Apply the patch Reload the page and verify the issue is solved
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      WIP-MDL-35576

      Description

      It's a really minor issue, but annoying. after visiting this page so many times a day.
      So here goes a fix (patch) theme/base/style/core.css

      .dir-rtl .mform .fitem fieldset.felement {padding-right: 1%;margin-right: 15%;}

        Gliffy Diagrams

          Activity

          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated (22, 23 & master), thanks!

          In 22_STABLE the selectors were slightly different, so I've amended the change.

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 & master), thanks! In 22_STABLE the selectors were slightly different, so I've amended the change. Ciao
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Tested under 22, 23 and master (safari and ff), now the date fieldsets are properly aligned for rtl langs.

          Passing.

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Tested under 22, 23 and master (safari and ff), now the date fieldsets are properly aligned for rtl langs. Passing.
          Hide
          poltawski Dan Poltawski added a comment -

          Congratulations, you've done it!

          Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

          Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

          Show
          poltawski Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/12