Moodle

Display grouping name for Drag and Dropped resources

Details

  • Testing Instructions:
    Hide
    1. Login as instructor of course or someone who has the moodle/course:managegroups capability
    2. Create group and grouping
    3. Edit course settings and set default grouping to be the created grouping
    4. Drag and drop a file
    5. VERIFY The grouping name is displayed in the file label
    6. Drag and drop a URL
    7. VERIFY The grouping name is displayed in the URL label
    Show
    Login as instructor of course or someone who has the moodle/course:managegroups capability Create group and grouping Edit course settings and set default grouping to be the created grouping Drag and drop a file VERIFY The grouping name is displayed in the file label Drag and drop a URL VERIFY The grouping name is displayed in the URL label
  • Affected Branches:
    MOODLE_23_STABLE, MOODLE_24_STABLE
  • Fixed Branches:
    MOODLE_23_STABLE
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

When dragging and dropping a resource, if there is a default grouping set, it isn't displayed until a full page reload.

This patch adds the display of the grouping name for dragged and dropped resources.

Replication steps:

  1. Login as instructor of course or someone who has the moodle/course:managegroups capability
  2. Create group and grouping
  3. Edit course settings and set default grouping to be the created grouping
  4. Drag and drop a file

Expected result: The grouping name label displayed

Actual result: The grouping name label is only displayed after a page reload

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rex Lorenzo added a comment -

Davo, since you worked on the drag and drop functionality for Moodle 2.3, do you mind code reviewing my patch?

Of if you are not the appropriate person, then please assign it back to "Rajesh Taneja" (the default person for the AJAX component)

Show
Rex Lorenzo added a comment - Davo, since you worked on the drag and drop functionality for Moodle 2.3, do you mind code reviewing my patch? Of if you are not the appropriate person, then please assign it back to "Rajesh Taneja" (the default person for the AJAX component)
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting that and providing a fix.

I've rearranged the roles a bit there.

Davo: if you could peer review this, that would be appreciated. If not, please edit the issue and set the peer reviewer to moodle.com. If you are happy with the fix, please push the issue to integration.

Show
Michael de Raadt added a comment - Thanks for reporting that and providing a fix. I've rearranged the roles a bit there. Davo: if you could peer review this, that would be appreciated. If not, please edit the issue and set the peer reviewer to moodle.com. If you are happy with the fix, please push the issue to integration.
Hide
Permalink
Davo Smith added a comment -

I'm happy to do a peer review - I've had a quick glance already and it looked fine, but I'll go through in more detail later and submit for integration if it all looks ok.

Show
Davo Smith added a comment - I'm happy to do a peer review - I've had a quick glance already and it looked fine, but I'll go through in more detail later and submit for integration if it all looks ok.
Hide
Permalink
Davo Smith added a comment -

I've tested this out and it seems to work fine - the code looks sensible to me, so I'm happy to submit it for integration.

Show
Davo Smith added a comment - I've tested this out and it seems to work fine - the code looks sensible to me, so I'm happy to submit it for integration.
Hide
Permalink
Aparup Banerjee added a comment -

Thanks, thats been integrated into 23 and master.

ps: i've fixed up some whitespaces i found in patch too.

Show
Aparup Banerjee added a comment - Thanks, thats been integrated into 23 and master. ps: i've fixed up some whitespaces i found in patch too.
Hide
Permalink
Rossiani Wijaya added a comment -

Tested in 2.3 and 2.4.

It works as expected.

Additional note: enable the setting for testing "Drag and drop a URL" (Site admin > Development > Experimental > Experimental settings > enable drag and drop upload of text/links).

Test passed.

Show
Rossiani Wijaya added a comment - Tested in 2.3 and 2.4. It works as expected. Additional note: enable the setting for testing "Drag and drop a URL" (Site admin > Development > Experimental > Experimental settings > enable drag and drop upload of text/links). Test passed.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

From somewhere within the clouds...

Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: