Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35590

Navigation block does not meet aria spec

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      This test requires JAWS and NVDA screen readers.
      1. Using the screen reader, navigate through the navigation block.
      2. Make sure it's accessible and you can expand/collapse items on the menu using the keyboard.
      3. Compare the behaviour to http://oaa-accessibility.org/example/42/
        1. The keyboard behaviour should be the same
      4. Test on all supported browsers.
      Testing without screen readers (Smoke tests)
      1. Do a extensive testing on the Navigation block (expand, colapse, tree, branches...) on each option.
      2. Make sure you are able to navigate through them without any problems.
      3. Compare the behaviour to http://oaa-accessibility.org/example/42/
        1. The mouse behaviour should be the same, except single clicking expands and collapses rather than double clicking
      4. Repeat the testing on the Administration blocks.
      5. Make sure you are able to navigate through them without any problems.
      6. Repeat the test on all supported browsers.
      Additional tests
      1. As admin, go to a course. Make sure the Site administration node is not a link. Make sure no error displays or is in inspector console
        1. Still on that page, expand site administration, and click on "registration" ensure it successfully takes you to the registration page. (only need to do this test on one browser)
      2. As admin, go to the notifications page. Make sure no error displays or in inspector console
      3. As a teacher, go to a course. Make sure no errors display or in inspector console
      4. As a teacher, go to a course administration page. Make sure no errors display or in inspector console
      5. Repeat on all supported browsers
        Only one browser
      6. Turn off slasharguments
      7. Go to a course with activity modules
      8. Expand the sections. you should be able to see icons for the activities
      Show
      This test requires JAWS and NVDA screen readers. Using the screen reader, navigate through the navigation block. Make sure it's accessible and you can expand/collapse items on the menu using the keyboard. Compare the behaviour to http://oaa-accessibility.org/example/42/ The keyboard behaviour should be the same Test on all supported browsers. Testing without screen readers (Smoke tests) Do a extensive testing on the Navigation block (expand, colapse, tree, branches...) on each option. Make sure you are able to navigate through them without any problems. Compare the behaviour to http://oaa-accessibility.org/example/42/ The mouse behaviour should be the same, except single clicking expands and collapses rather than double clicking Repeat the testing on the Administration blocks. Make sure you are able to navigate through them without any problems. Repeat the test on all supported browsers. Additional tests As admin, go to a course. Make sure the Site administration node is not a link. Make sure no error displays or is in inspector console Still on that page, expand site administration, and click on "registration" ensure it successfully takes you to the registration page. (only need to do this test on one browser) As admin, go to the notifications page. Make sure no error displays or in inspector console As a teacher, go to a course. Make sure no errors display or in inspector console As a teacher, go to a course administration page. Make sure no errors display or in inspector console Repeat on all supported browsers Only one browser Turn off slasharguments Go to a course with activity modules Expand the sections. you should be able to see icons for the activities
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35590-master
    • Documentation link:
    • Sprint:
      Team Both Sprint 1, 3.1 Sprint 3

      Description

      Aria expansion attributes were added to the navigation block as per MDL-22322 and MDL-30833.
      However they were not added with the required role attributes. Reading the aria + role spec's it sounds to me like those attributes are going to be straight up ignored. It reads that the attributes will only be applied with one of the expected roles is in play.
      A quick check also confirms that this breaks out HTML validation.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                3 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16