[MDL-35593] core_webservice_get_site_info returns version number set to PARAM_TEXT and PARAM_FLOAT - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.2.5, 2.3.2
Fix Version/s: 2.2.7, 2.3.4, 2.4.1
Component/s: Web Services
Labels:
- api_change
- triaged

Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git://github.com/mouneyrac/moodle.git
Pull Master Branch:
~~MDL-35593~~-master
Pull Master Diff URL:
https://github.com/mouneyrac/moodle/compare/moodle:master...MDL-35593-master
Testing Instructions:

Hide

phpunit core_webservice_external_testcase webservice/tests/externallib_test.php

Show
phpunit core_webservice_external_testcase webservice/tests/externallib_test.php

Description

core_webservice_get_site_info should always use the same PARAM_XXX for version numbers. Note that PARAM_FLOAT may be not the best choice (or may be), see ~~MDL-31473~~ report.

Attachments

Activity

People

Assignee:: Jérôme Mouneyrac

Reporter:: Jérôme Mouneyrac

Peer reviewer:: Dan Poltawski

Integrator:: Sam Hemelryk

Tester:: Damyon Wiese

Participants:: Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Jérôme Mouneyrac, Sam Hemelryk

Component watchers:: Juan Leyva, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 24/Sep/12 8:44 PM

Updated:: 15/Dec/12 8:29 AM

Resolved:: 15/Dec/12 8:29 AM

Fix Release Date:: 14/Jan/13