[MDL-35618] move "cohort users" enrolment to manual enrol widget - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.3
Fix Version/s: 2.8
Component/s: Cohorts, Enrolments
Labels:
- ci
- triaged
- ui_change

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Main Branch:
wip-~~MDL-35618~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/wip-MDL-36014-master...wip-MDL-35618-master
Testing Instructions:
Hide

Make sure teacher can enrol users using "Enrol users" button on "Enrolled users" page, play with enrolment options.

As admin create some cohorts visible in the course (for example in the system context or in the category where this course is), populate them with members

As a teacher go to the "Enrolled users" page and make sure that "Enrol users" popup now has a choice of "Browse users/Browse cohorts".

As a teacher try enrolling individual users and/or all users in cohorts, make sure the functionality works.

Apply some enrolment options

Try enrolling one user from cohort individually. Make sure the cohort now has displays one less member. Enrol the rest of the cohort with different enrolment options, make sure they apply

Check the style of the dialogue in different themes

The button "Enrol cohort" no longer appears on the "Enrolled users" page
Show
Make sure teacher can enrol users using "Enrol users" button on "Enrolled users" page, play with enrolment options. As admin create some cohorts visible in the course (for example in the system context or in the category where this course is), populate them with members As a teacher go to the "Enrolled users" page and make sure that "Enrol users" popup now has a choice of "Browse users/Browse cohorts". As a teacher try enrolling individual users and/or all users in cohorts, make sure the functionality works. Apply some enrolment options Try enrolling one user from cohort individually. Make sure the cohort now has displays one less member. Enrol the rest of the cohort with different enrolment options, make sure they apply Check the style of the dialogue in different themes The button "Enrol cohort" no longer appears on the "Enrolled users" page

Description

At present the "Enrol cohort" does both manual enrolments and cohort sync, this is wrong for several reasons:
1/ it is confusing
2/ the code is in wrong locations - each plugin must be self-contained
3/ it is not possible to add more options to cohort sync plugin
4/ it is not possible to visualise existing sync instances
5/ if you disable cohort sync plugin you can not manually enrol users from cohort
6/ invalid use of cohort enrol cohort capabilities for manual enrolments
etc.

Solution is to move enrolling of cohort users to manual plugin and keep the cohort sync plugin for itself.

Attachments

Issue Links

caused a regression

MDL-48772 Hardcoded language elements: missing lang strings

Closed

is blocked by

MDL-36014 Allow users in course to access cohorts defined in course category or system

Closed

will help resolve

MDL-27402 Unenrole cohort from course not possible

Closed

MDL-28431 manual enrolment of cohort members requires cohort:sync incorrectly

Closed

MDL-39078 Enrol users/Enrol cohort dialogues are inconsistently styled

Closed

Activity

People

Assignee:: Marina Glancy

Reporter:: Petr Skoda

Integrator:: Dan Poltawski

Tester:: Simey Lameze

Participants:: CiBoT, Dan Poltawski, Juerg Hoerner, Marina Glancy, Mary Cooch, Petr Skoda, Sam Hemelryk, Simey Lameze

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 26/Sep/12 4:08 AM

Updated:: 22/Jan/15 1:43 AM

Resolved:: 11/Oct/14 3:16 AM

Fix Release Date:: 10/Nov/14