Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35618

move "cohort users" enrolment to manual enrol widget

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Make sure teacher can enrol users using "Enrol users" button on "Enrolled users" page, play with enrolment options.
      2. As admin create some cohorts visible in the course (for example in the system context or in the category where this course is), populate them with members
      3. As a teacher go to the "Enrolled users" page and make sure that "Enrol users" popup now has a choice of "Browse users/Browse cohorts".
      4. As a teacher try enrolling individual users and/or all users in cohorts, make sure the functionality works.
      5. Apply some enrolment options
      6. Try enrolling one user from cohort individually. Make sure the cohort now has displays one less member. Enrol the rest of the cohort with different enrolment options, make sure they apply
      7. Check the style of the dialogue in different themes
      8. The button "Enrol cohort" no longer appears on the "Enrolled users" page
      Show
      Make sure teacher can enrol users using "Enrol users" button on "Enrolled users" page, play with enrolment options. As admin create some cohorts visible in the course (for example in the system context or in the category where this course is), populate them with members As a teacher go to the "Enrolled users" page and make sure that "Enrol users" popup now has a choice of "Browse users/Browse cohorts". As a teacher try enrolling individual users and/or all users in cohorts, make sure the functionality works. Apply some enrolment options Try enrolling one user from cohort individually. Make sure the cohort now has displays one less member. Enrol the rest of the cohort with different enrolment options, make sure they apply Check the style of the dialogue in different themes The button "Enrol cohort" no longer appears on the "Enrolled users" page
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      wip-MDL-35618-master

      Description

      At present the "Enrol cohort" does both manual enrolments and cohort sync, this is wrong for several reasons:
      1/ it is confusing
      2/ the code is in wrong locations - each plugin must be self-contained
      3/ it is not possible to add more options to cohort sync plugin
      4/ it is not possible to visualise existing sync instances
      5/ if you disable cohort sync plugin you can not manually enrol users from cohort
      6/ invalid use of cohort enrol cohort capabilities for manual enrolments
      etc.

      Solution is to move enrolling of cohort users to manual plugin and keep the cohort sync plugin for itself.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14