Moodle

Question engine cannot cope with a question variable called "0"

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2.5, 2.3.2, 2.4
  • Fix Version/s: 2.2.6, 2.3.3
  • Component/s: Questions
  • Labels:
  • Testing Instructions:
    Hide

    The unit tests are a reasonable test of this, but to be on the safe side:

    1. Preview a couple of questions, including a shortanswer question using deferred feedback behaviour, and another qtype using a different behaviour.

    Show
    The unit tests are a reasonable test of this, but to be on the safe side: 1. Preview a couple of questions, including a shortanswer question using deferred feedback behaviour, and another qtype using a different behaviour.
  • Affected Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

It is, of course, a really bad idea to use a question variable called 0. However, it turns out that the OU has a lot of Opaque questions (https://github.com/moodleou/moodle-qtype_opaque) that do just that, and it is impossible to change it now.

Amazingly, the system can actually cope with such silly names, except for one place where we do a sloppy test for whether the name is NULL, so I will fix that.

Also, interestingly, <input name="0" ... /> is valid HTML, so supporting this is not totally crazy.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Poltawski added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated (22, 23 & master), thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 & master), thanks!
Hide
Permalink
Dan Poltawski added a comment -

Not done that extensive test since i'm not really sure what i'm tested, but I tried adding a number of qtypes and changed their bhaviours and previewed. No problems encountered.

Show
Dan Poltawski added a comment - Not done that extensive test since i'm not really sure what i'm tested, but I tried adding a number of qtypes and changed their bhaviours and previewed. No problems encountered.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Closing as fixed, many thanks for your awesome collaboration.

Show
Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your awesome collaboration.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: