Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35634

Restore alt attribute containing module name on activity icons

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3.2
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Course
    • Labels:

      Description

      This is a regression of MDL-31976. The module icons should not have an empty alt attribute.

      Diff from MDL-31976:
      https://github.com/FMCorz/moodle/commit/aad982aa2412ed786075cefcd0b397457065c34d#L1L1579

      1. Go to a course page with activities
      2. Make sure the activity icons have an alt attribute containing the type of module they are

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            andyjdavis Andrew Davis added a comment -

            [Y] Syntax
            [Y] Output
            [Y] Whitespace
            [NA] Language
            [NA] Databases
            [Y] Testing
            [Y] Security
            [NA] Documentation
            [Y] Git
            [Y] Sanity check

            Seems a simple enough fix.

            Show
            andyjdavis Andrew Davis added a comment - [Y] Syntax [Y] Output [Y] Whitespace [NA] Language [NA] Databases [Y] Testing [Y] Security [NA] Documentation [Y] Git [Y] Sanity check Seems a simple enough fix.
            Hide
            fred Frédéric Massart added a comment -

            Thanks Andrew, pushing for integration.

            Show
            fred Frédéric Massart added a comment - Thanks Andrew, pushing for integration.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Fred, this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Fred, this has been integrated now
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Fred,
            It is not related to this bug, but should we not also have alt text in edit activity page with the icons?
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Fred, It is not related to this bug, but should we not also have alt text in edit activity page with the icons? Thanks
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            passing test as it works as described

            Show
            ankit_frenz Ankit Agarwal added a comment - passing test as it works as described
            Hide
            fred Frédéric Massart added a comment -

            Thanks for testing this Ankit. You are right, this is not related to this issue, but if you are asking for my opinion I don't think those icons need an alt because they are not containing any information required for the impaired user to be notified of their content. Cheers!

            Show
            fred Frédéric Massart added a comment - Thanks for testing this Ankit. You are right, this is not related to this issue, but if you are asking for my opinion I don't think those icons need an alt because they are not containing any information required for the impaired user to be notified of their content. Cheers!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            From somewhere within the clouds...

            Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12