Moodle
  1. Moodle
  2. MDL-35636

login/token.php: confusing "create user token" log appearing before "token user request"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3.2
    • Fix Version/s: 2.4
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      Require web service client creation experience.

      1) Enable mobile service in the Moodle admin
      2) http://docs.moodle.org/dev/Creating_a_web_service_client#How_to_get_a_user_token
      Call login/token.php following the documentation. Checks Moodle logs (in the Moodle admin), you should see the new info "sending requested user token".

      Show
      Require web service client creation experience. 1) Enable mobile service in the Moodle admin 2) http://docs.moodle.org/dev/Creating_a_web_service_client#How_to_get_a_user_token Call login/token.php following the documentation. Checks Moodle logs (in the Moodle admin), you should see the new info "sending requested user token".
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
    • Rank:
      44369

      Issue Links

        Activity

        Hide
        Rajesh Taneja added a comment -

        Thanks Jerome,

        Re-wording make sense. Feel free to push it for integration, after adding testing instructions. You might want to back-port this as well.

        Show
        Rajesh Taneja added a comment - Thanks Jerome, Re-wording make sense. Feel free to push it for integration, after adding testing instructions. You might want to back-port this as well.
        Hide
        Jérôme Mouneyrac added a comment -

        Thanks Raj, submitting to integration.

        Show
        Jérôme Mouneyrac added a comment - Thanks Raj, submitting to integration.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Hi,

        I've integrated this, but i've only done it on master.

        The reason i've only done the change on master is because I think it'd be a bit confusing to have changing log messages on the stable branches. I don't think this is a major issue, so I think just keepign the message the same on stable branches makes sure sites aren't confused by the change mid branch lifecyclc.e

        Show
        Dan Poltawski added a comment - Hi, I've integrated this, but i've only done it on master. The reason i've only done the change on master is because I think it'd be a bit confusing to have changing log messages on the stable branches. I don't think this is a major issue, so I think just keepign the message the same on stable branches makes sure sites aren't confused by the change mid branch lifecyclc.e
        Hide
        David Monllaó added a comment -

        It passes, the recorded log is "sending requested user token". Tested only in master

        Show
        David Monllaó added a comment - It passes, the recorded log is "sending requested user token". Tested only in master
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Closing as fixed, many thanks for your awesome collaboration.

        Show
        Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your awesome collaboration.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: