Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35638

Cancelling restore due to conflict in role mapping process produces a warning

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.7.4, 2.8.2
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide
      1. Backup and download this course http://school.demo.moodle.net/course/view.php?id=35
      2. Try restoring it up in a moodle install
      3. Cancel the restore on the "Restore settings" page, make sure you don't get any debugging before the redirect.
      4. Try restoring the course again, and now cancel at the step "Course settings". Again, make sure no debugging is shown.
      5. Do the same thing again for "Backup settings" step.
      6. Start the restore process again and this time go to till you see a role conflict. click cancel on that page and make sure no debugging is shown before redirect.
        (Be aware of the linked issues, they are not related to this fix)
      Show
      Backup and download this course http://school.demo.moodle.net/course/view.php?id=35 Try restoring it up in a moodle install Cancel the restore on the "Restore settings" page, make sure you don't get any debugging before the redirect. Try restoring the course again, and now cancel at the step "Course settings". Again, make sure no debugging is shown. Do the same thing again for "Backup settings" step. Start the restore process again and this time go to till you see a role conflict. click cancel on that page and make sure no debugging is shown before redirect. (Be aware of the linked issues, they are not related to this fix)
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-35638-master
    • Sprint:
      BACKEND Sprint 18

      Description

      Found this warning while testing MDL-35337.

      Warning: Illegal offset type in isset or empty in /integration/master/course/format/renderer.php on line 547
       
      Unknown course section in course "Course restoration in progress"
       
      More information about this error
      Debug info:
      Error code: unknowncoursesection
      Stack trace:
       
          line 467 of /lib/setuplib.php: moodle_exception thrown
          line 549 of /course/format/renderer.php: call to print_error()
          line 50 of /course/format/topics/format.php: call to format_section_renderer_base->print_single_section_page()
          line 279 of /course/view.php: call to require()
      

      You should really redirect before you start page output
       
       
       
          line 789 of /lib/outputrenderers.php: call to debugging()
       
          line 2634 of /lib/weblib.php: call to core_renderer->redirect_message()
       
          line 785 of /backup/util/ui/restore_ui_stage.class.php: call to redirect()
       
          line 105 of /backup/util/ui/restore_ui.class.php: call to restore_ui_stage_process->process()
       
          line 80 of /backup/restore.php: call to restore_ui->process()
       
       
       
      This page should automatically redirect. If nothing is happening please use the continue link below.
      
      

      Steps to reproduce:

      1. restore a course as new course from the attach backup file (the backup file was retrieved from World of Water course found at http://school.demo.moodle.net/course/view.php?id=115)
      2. use the default value
      3. There should be a conflict for restoring role mappings in step 6 (process) of the restore process.
      4. select the cancel button
        The above error display.

      Note: I'm assigning the component field as 'backup' because there is no option for 'restore'. Please feel free to change it to a more proper component.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Jan/15