Details

    • Testing Instructions:
      Hide

      TESTING requires RTL language pack (Hebrew, Arabic, etc.)

      1. Select Anomaly theme as default from Theme selector NOT by URL
      2. Add some Custom menu items in Theme settings page
      3. TEST that the menu labels float left and that the drop-down sub-menu 'click-able' menu items pop-out to the right when hovered over, and also that the sub-menu indicator arrow background changes colour in response to the hover.
      4. Change to a RTL language from the language menu.
      5. TEST that the menu labels float right and that the drop-down sub-menu 'click-able' menu items pop-out to the left when hovered over, and also that the sub-menu indicator arrow background changes colour in response to the hover.
      6. End Test
      Show
      TESTING requires RTL language pack (Hebrew, Arabic, etc.) Select Anomaly theme as default from Theme selector NOT by URL Add some Custom menu items in Theme settings page TEST that the menu labels float left and that the drop-down sub-menu 'click-able' menu items pop-out to the right when hovered over, and also that the sub-menu indicator arrow background changes colour in response to the hover. Change to a RTL language from the language menu. TEST that the menu labels float right and that the drop-down sub-menu 'click-able' menu items pop-out to the left when hovered over, and also that the sub-menu indicator arrow background changes colour in response to the hover. End Test
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-35654_master
    • Rank:
      44389

      Description

      By adding a renderer for the custom menu to any Moodle theme helps enormously with styling for RTL languages. This renderer can be seen in action in the Afterburner theme.

      1. nav-arrow-left.jpg
        0.5 kB
      2. nav-arrowover-left.jpg
        0.4 kB
      3. nav-arrowover-right.jpg
        0.4 kB
      4. nav-arrow-right.jpg
        0.4 kB

        Activity

        Hide
        Mary Evans added a comment - - edited

        @Nadav

        You can add the fix for the custom menu here together with the change to logininfo

        However can you make sure you add the arrow images that I will upload here so they match the color scheme of the Anomaly theme?

        Cheers

        Mary

        Show
        Mary Evans added a comment - - edited @Nadav You can add the fix for the custom menu here together with the change to logininfo However can you make sure you add the arrow images that I will upload here so they match the color scheme of the Anomaly theme? Cheers Mary
        Hide
        Mary Evans added a comment -

        Please use the attached arrows.

        Colour HEX Code:
        Dark Green = #3A4D28 (Active hover colour)
        Mid Green = #697F55 (Main colour)

        Thanks. Mary

        Show
        Mary Evans added a comment - Please use the attached arrows. Colour HEX Code: Dark Green = #3A4D28 (Active hover colour) Mid Green = #697F55 (Main colour) Thanks. Mary
        Hide
        Nadav Kavalerchik added a comment -

        Fix is ready with colors and all
        There was no need to fix the loginfo since it was already apearing in each page as it was intended to be.

        Show
        Nadav Kavalerchik added a comment - Fix is ready with colors and all There was no need to fix the loginfo since it was already apearing in each page as it was intended to be.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Mary Evans added a comment -

        @Nadav

        I've been working on adding the full menu to Anomaly as this lessens the need for two sets of CSS for the YUI menu and the rendered one.

        I'll do this and then open a new tracker issue to deal with the swap side blocks, as I have a feeling Sam Hemelryk would prefer this was fixed in core.

        Thanks
        Mary

        Show
        Mary Evans added a comment - @Nadav I've been working on adding the full menu to Anomaly as this lessens the need for two sets of CSS for the YUI menu and the rendered one. I'll do this and then open a new tracker issue to deal with the swap side blocks, as I have a feeling Sam Hemelryk would prefer this was fixed in core. Thanks Mary
        Hide
        Mary Evans added a comment -

        I'm just reopening this while I sort out what elements need to get fixed first.

        Show
        Mary Evans added a comment - I'm just reopening this while I sort out what elements need to get fixed first.
        Hide
        Nadav Kavalerchik added a comment - - edited

        I have just now rebased master and M23 branches with this fix

        I have left the YUI menu for the LTR mode (IF !right_to_left() ...) and only used the renderer for the RTL menu.

        Show
        Nadav Kavalerchik added a comment - - edited I have just now rebased master and M23 branches with this fix I have left the YUI menu for the LTR mode (IF !right_to_left() ...) and only used the renderer for the RTL menu.
        Hide
        Mary Evans added a comment -

        I'm adding the renderer so it works in both LTR & RTL

        Show
        Mary Evans added a comment - I'm adding the renderer so it works in both LTR & RTL
        Hide
        Mary Evans added a comment -

        @DanP

        Is the reason this is not being integrated because my branch MDL-35654_M23 conflicts with MDL-34121...???

        I tried to rebase but ended up aborting the process because of the above conflict.

        Show
        Mary Evans added a comment - @DanP Is the reason this is not being integrated because my branch MDL-35654 _M23 conflicts with MDL-34121 ...??? I tried to rebase but ended up aborting the process because of the above conflict.
        Hide
        Sam Hemelryk added a comment -

        Thanks Mary - this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks Mary - this has been integrated now.
        Hide
        Adrian Greeve added a comment -

        Tested on the master branch and 2.3 and master integration branches.
        The custom menu is positioned on the right for RTL languages. The pop ups and mouse overs work as described.
        Test passed.

        Show
        Adrian Greeve added a comment - Tested on the master branch and 2.3 and master integration branches. The custom menu is positioned on the right for RTL languages. The pop ups and mouse overs work as described. Test passed.
        Hide
        Mary Evans added a comment -

        Excellent thanks!

        Show
        Mary Evans added a comment - Excellent thanks!
        Hide
        Nadav Kavalerchik added a comment -

        Beautiful

        Show
        Nadav Kavalerchik added a comment - Beautiful
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Closing as fixed, many thanks for your awesome collaboration.

        Show
        Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your awesome collaboration.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: