Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35660

Assignment module, feedback file plugin, batch upload feedback files uses incorrect constant name

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Ensure debugging level is set to developer
      2. Create an assignment and enable feedback files
      3. Go to the grading table for assignment, select some students and choose "Send feedback files" from the menu underneath the grading table
      4. Click go and accept the confirmation, you will see a page with a form for uploading the files.
      5. VERIFY No warnings appear
      Show
      Ensure debugging level is set to developer Create an assignment and enable feedback files Go to the grading table for assignment, select some students and choose "Send feedback files" from the menu underneath the grading table Click go and accept the confirmation, you will see a page with a form for uploading the files. VERIFY No warnings appear
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      Replication steps:

      1. Ensure debugging level is set to developer
      2. Create an assignment and enable feedback files
      3. Go to the grading table for assignment, select some students and choose "Send feedback files" from the menu underneath the grading table
      4. Click go and accept the confirmation, you will see a page with a form for uploading the files.

      Expected result: No warning printed at top of page

      Actual result: Warning printed at top of page

      Notice: Use of undefined constant ASSIGNFEEDBACK_BATCHFILE_FILEAREA - assumed 'ASSIGNFEEDBACK_BATCHFILE_FILEAREA' in /git/working/moodle23/mod/assign/feedback/file/batchuploadfilesform.php on line 61

      Should be ASSIGNFEEDBACK_FILE_BATCH_FILEAREA

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Damyon, is this 2.4 only or also 2.3.x ?

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Damyon, is this 2.4 only or also 2.3.x ?
            Hide
            damyon Damyon Wiese added a comment -

            2.4 only.

            Thanks!

            Show
            damyon Damyon Wiese added a comment - 2.4 only. Thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Tested this in 2.4 only.

            It works as expected.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - Tested this in 2.4 only. It works as expected. Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Closing as fixed, many thanks for your awesome collaboration.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your awesome collaboration.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12