Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35661

Plugins that only use settings.php to add items to another section can cause an error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.3
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      In 2.3 and master:
      install some contributed local plugin and make sure that plugins overview page (xxx/admin/plugins.php) does not show the broken 'settings' link.

      In master only:
      1. Make sure that Plugins section of Site Administration has working 'settings' and 'uninstall' links.

      Note: New functionality does not affect any core plugins.

      2. Install some contributed plugins and make sure that settings, visibility icon and uninstall link are similar to overview page of this particular plugin type.
      Changed interfaces: webservices, plagiarism, editors, message protocols.

      3. Try altering some plugin's settings.php file by adding $settings=null; in the end. Expected behaviour: the settings item is removed from navigation menu and overview page for particular plugin type. After this fix the link is also removed from general plugin overview page.

      Show
      In 2.3 and master: install some contributed local plugin and make sure that plugins overview page (xxx/admin/plugins.php) does not show the broken 'settings' link. In master only: 1. Make sure that Plugins section of Site Administration has working 'settings' and 'uninstall' links. Note: New functionality does not affect any core plugins. 2. Install some contributed plugins and make sure that settings, visibility icon and uninstall link are similar to overview page of this particular plugin type. Changed interfaces: webservices, plagiarism, editors, message protocols. 3. Try altering some plugin's settings.php file by adding $settings=null; in the end. Expected behaviour: the settings item is removed from navigation menu and overview page for particular plugin type. After this fix the link is also removed from general plugin overview page.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-35661-master

      Description

      See MDL-35442:

      1. install the adminer contrib plugin to local
      2. Click on the settings link in the plugins overview page

      This is probably the case for other plugin types settings links too.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Andrew Davis Andrew Davis
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/12