Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35664

Filepicker does not handle the current path

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.3.3
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide

      Test pre-requisites

      1. Enable Wikimedia and Box.net repositories
      2. Enable another repository which supports pagination and subfolders (Evernote can, with a little config, or use dummyrepo2.zip)

      Test steps

      1. Navigate to your private files and open the file picker
      2. Search for 'cat' in Wikimedia and make sure the next results are fetched as you scroll
      1. Navigate to your Box.net (you need subfolders in there)
      2. Browse your files and directories and make sure the repository behave correctly
      1. Try the 3rd repository (do not use tree view)
      2. Navigate to some directory (do not stay on the default repository folder)
      3. Make sure hitting the refresh button, refreshes the correct path, and does not redirect you to the default folder
      4. Make sure the next results are fetched while you scroll

      Known issues:

      • the search cannot be refreshed, and the next page results do not pass the initial query MDL-35897
      • switching to tree view while in a subfolder of a dynload off repository (box.net) is not well supported
      Show
      Test pre-requisites Enable Wikimedia and Box.net repositories Enable another repository which supports pagination and subfolders (Evernote can, with a little config, or use dummyrepo2.zip) Test steps Navigate to your private files and open the file picker Search for 'cat' in Wikimedia and make sure the next results are fetched as you scroll Navigate to your Box.net (you need subfolders in there) Browse your files and directories and make sure the repository behave correctly Try the 3rd repository (do not use tree view) Navigate to some directory (do not stay on the default repository folder) Make sure hitting the refresh button, refreshes the correct path, and does not redirect you to the default folder Make sure the next results are fetched while you scroll Known issues: the search cannot be refreshed, and the next page results do not pass the initial query MDL-35897 switching to tree view while in a subfolder of a dynload off repository (box.net) is not well supported
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35664-master
    • Pull Master Diff URL:

      Description

      When viewing (not in tree view) a repository (Dropbox for example) and browsing into some subdirectories, clicking the refresh button will reload the root of the repository.

      From what I have seen, the file picker is not storing the current path anywhere.
      Also, when requesting the next page, the path sent back to repository_ajax is undefined.
      And later on the following test will fail because the obj.path is the breadcrumb and scope.path is undefined:

      // repository/filepicker.js:1036
      		 
                          if (scope.active_repo.hasmorepages && obj.list && obj.page &&
      		 
                                  obj.repo_id == scope.active_repo.id &&
      		 
                                  obj.page == scope.active_repo.page+1 && obj.path == scope.path) {
      		 
                              scope.parse_repository_options(obj, true);
      		 
                              scope.view_files(obj.list)
      		 
                          }

      (I am not sure how this can be handled in the tree view.)

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36696 filepicker.js has superfluous comma which prevents the filepicker loading in IE

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-35894 File picker refresh button should notify the repository

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Marina Glancy
              Integrator:
              Sam Hemelryk
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/12