[MDL-35667] Potential infinite loop in grade_category::apply_limit_rules() - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.2.5
Fix Version/s: 2.2.6, 2.3.3
Component/s: Gradebook
Labels:
- triaged

Database:

Any
Testing Instructions:

Hide

Run "phpunit grade_category_testcase lib/grade/tests/grade_category_test.php"

Repeat the manual testing instructions from ~~MDL-13629~~. Sorry

You may run into ~~MDL-35665~~ which is a known issue.

Show
Run "phpunit grade_category_testcase lib/grade/tests/grade_category_test.php" Repeat the manual testing instructions from MDL-13629 . Sorry You may run into MDL-35665 which is a known issue.
Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/andyjdavis/moodle.git
Pull Master Branch:
~~MDL-35667~~_extra_credit_loop
Pull Master Diff URL:
https://github.com/andyjdavis/moodle/compare/master...MDL-35667_extra_credit_loop

Description

I've spotted a possible infinite loop introduced by ~~MDL-13629~~ to do with droplow and keephigh and extra credit grade items.

Attachments

Issue Links

is a regression caused by

MDL-13629 Gradebook: Unexpected behavior in selection of lowest grade to drop and resultant category calculation

Closed

Activity

People

Assignee:: Andrew Davis

Reporter:: Andrew Davis

Peer reviewer:: Dan Poltawski

Integrator:: Sam Hemelryk

Tester:: Adrian Greeve

Participants:: Adrian Greeve, Andrew Davis, Dan Poltawski, Eloy Lafuente (stronk7), Eric Eisenhart, Sam Hemelryk

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan

Votes:: 2 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 27/Sep/12 10:59 PM

Updated:: 30/Sep/13 9:08 PM

Resolved:: 15/Oct/12 3:08 PM

Fix Release Date:: 12/Nov/12