Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35668

Server files repository takes a long time to load

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Performance compare (start test BEFORE UPGRADE or revert commits from this issue):

      1. Create several course categories, courses in them and modules with files
      2. Enrol a teacher in some of these courses
      3. Hide some course categories and unhide courses in them so that teacher is enrolled in a course that is inside a hidden category
      4. Login as a teacher and open a file manager anywhere (for example, create a new resource and insert a link in an editor)
      5. Add 'logall'=>true to the dboptions in config.php
      6. As a teacher open "Server files" repository and navigate to top level.
      7. Check the number of new records in the mdl_log_queries table - remember this number
      8. Remove logall and truncate the mdl_log_queries table
      9. UPGRADE
      10. As the same teacher navigate to the same page
      11. Add 'logall'=>true to the dboptions in config.php
      12. As a teacher open "Server files" repository and navigate to top level.
      13. Check the number of new records in the mdl_log_queries table - it should be significantly less than before upgrade

      Regression test - browse around "Server files" repository, make sure that you can see all courses where you are enrolled and files inside them. If category containing your courses is hidden you should see these courses on the lowest level of the category that you can access (or system)

      Important to perform all tests as a TEACHER - admins bypass all checks and students do not have access to "Server files" repository

      Show
      Performance compare (start test BEFORE UPGRADE or revert commits from this issue): Create several course categories, courses in them and modules with files Enrol a teacher in some of these courses Hide some course categories and unhide courses in them so that teacher is enrolled in a course that is inside a hidden category Login as a teacher and open a file manager anywhere (for example, create a new resource and insert a link in an editor) Add 'logall'=>true to the dboptions in config.php As a teacher open "Server files" repository and navigate to top level. Check the number of new records in the mdl_log_queries table - remember this number Remove logall and truncate the mdl_log_queries table UPGRADE As the same teacher navigate to the same page Add 'logall'=>true to the dboptions in config.php As a teacher open "Server files" repository and navigate to top level. Check the number of new records in the mdl_log_queries table - it should be significantly less than before upgrade Regression test - browse around "Server files" repository, make sure that you can see all courses where you are enrolled and files inside them. If category containing your courses is hidden you should see these courses on the lowest level of the category that you can access (or system) Important to perform all tests as a TEACHER - admins bypass all checks and students do not have access to "Server files" repository
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_30_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull Master Branch:
      wip-MDL-35668-master
    • Sprint:
      3.4 Sprint 4

      Description

      When logged in as an admin user with a large number of courses/categories in a site, when browsing to the server files root in the file picker it takes too long to load in the browser - it looks like it's hitting the db pretty hard during the load.

      I'm testing this on a site with a massive number of courses/categories - MDL-35179 has a script that lets you create 900 categories quickly.

      MDL-33857 is partially related to this.

        Attachments

        1. after.png
          after.png
          146 kB
        2. before.png
          before.png
          143 kB

          Issue Links

            Activity

              People

              • Votes:
                8 Vote for this issue
                Watchers:
                17 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17