Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35675

constrained dateselector can appear in wrong places

    Details

    • Testing Instructions:
      Hide

      Test pre-requisites

      • To be tested on ALL major browsers

      Test steps

      1. Visit a few pages where the popup calendar is used (new event, module settings, ...)
      2. Make sure it pops up nicely above the select boxes, even when the page is scrolled.
      Show
      Test pre-requisites To be tested on ALL major browsers Test steps Visit a few pages where the popup calendar is used (new event, module settings, ...) Make sure it pops up nicely above the select boxes, even when the page is scrolled.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35675-master

      Description

      Hi,

      on moodle.fhnw.ch, we noticed that the dateselector could appear in wrong places (like: always at the top of the page).

      While this is probably a CSS-YUI interaction bug, we noticed:

      1. the definition of constraints in lib/form/yui/dateselector/dateselector.js is incoherent:
        • on line 118, the M.form.dateselector is constrained to the 'form' ancestor
        • on line 248, the panel is then re-constrained to the 'body' ancestor.
          This was addressed in MDL-32297 but apparently partly so.
      2. we could restore a sane behaviour by dropping the dateselector constrains completely.

      The patch to do the latter as well as a screenshot of the problem are attached.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/Jan/13