[MDL-35675] constrained dateselector can appear in wrong places - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Test pre-requisites

To be tested on ALL major browsers

Test steps

Visit a few pages where the popup calendar is used (new event, module settings, ...)

Make sure it pops up nicely above the select boxes, even when the page is scrolled.
Show
Test pre-requisites To be tested on ALL major browsers Test steps Visit a few pages where the popup calendar is used (new event, module settings, ...) Make sure it pops up nicely above the select boxes, even when the page is scrolled.
Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-35675~~-master
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/moodle:master...MDL-35675-master

Hi,

on moodle.fhnw.ch, we noticed that the dateselector could appear in wrong places (like: always at the top of the page).

While this is probably a CSS-YUI interaction bug, we noticed:

the definition of constraints in lib/form/yui/dateselector/dateselector.js is incoherent:
- on line 118, the M.form.dateselector is constrained to the 'form' ancestor
- on line 248, the panel is then re-constrained to the 'body' ancestor.
  This was addressed in ~~MDL-32297~~ but apparently partly so.
we could restore a sane behaviour by dropping the dateselector constrains completely.

The patch to do the latter as well as a screenshot of the problem are attached.

has a non-specific relationship to

MDL-26649 Date picker formslib element usability improvements

is a regression caused by

MDL-32297 date_time_selector popup is too constrained

Participants:: Adrian Greeve, Dan Poltawski, Didier Raboud, Frédéric Massart, Michael de Raadt, Rajesh Taneja

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias