Moodle
  1. Moodle
  2. MDL-3567

Unenrolled students appear in quiz result block

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.5, 1.6.8, 1.7.6, 1.8.7, 1.9.3, 2.1.1
    • Fix Version/s: STABLE backlog
    • Component/s: Quiz
    • Labels:
    • Environment:
      All
    • Affected Branches:
      MOODLE_15_STABLE, MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_21_STABLE

      Description

      It would appear the names of students who are no longer enrolled on a course still appear in the quiz results block - at least this is the case in the features demo course

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Martin Dougiamas added a comment -

            From Gustav Delius (gwd2 at york.ac.uk) Monday, 20 June 2005, 04:10 AM:

            Martin, do you know who is maintaining this quiz results block?

            Show
            Martin Dougiamas added a comment - From Gustav Delius (gwd2 at york.ac.uk) Monday, 20 June 2005, 04:10 AM: Martin, do you know who is maintaining this quiz results block?
            Hide
            Tim Hunt added a comment -

            Does this still happen? does anyone know?

            Show
            Tim Hunt added a comment - Does this still happen? does anyone know?
            Hide
            Tim Hunt added a comment -

            Yes, this will still happen. And now roles are around, finding the people to include or exclude is quite hard. MDL-7772 will need the same logic though.

            Show
            Tim Hunt added a comment - Yes, this will still happen. And now roles are around, finding the people to include or exclude is quite hard. MDL-7772 will need the same logic though.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Adding versions and fixfor versions to have this rolling...

            Show
            Eloy Lafuente (stronk7) added a comment - Adding versions and fixfor versions to have this rolling...
            Hide
            Tim Hunt added a comment -

            Getting rid of fix for versions again. I don't have time to work on this right now. This is a really old bug with zero votes, and I think it is hard to do properly. I'll happily review a patch though.

            Show
            Tim Hunt added a comment - Getting rid of fix for versions again. I don't have time to work on this right now. This is a really old bug with zero votes, and I think it is hard to do properly. I'll happily review a patch though.
            Hide
            Anthony Borrow added a comment -

            This issue was discussed a bit in http://moodle.org/mod/forum/discuss.php?d=131809#p690797 Peace - Anthony

            Show
            Anthony Borrow added a comment - This issue was discussed a bit in http://moodle.org/mod/forum/discuss.php?d=131809#p690797 Peace - Anthony
            Hide
            Justin K. Reeve added a comment -

            This doesn't fix the issue for everyone, but here's a quick hack I did using a custom enrollments table that contains a user id, course id, and role. There's probably a better way to do this, but I inserted the following in /mod/quiz/overview/report.php:~354, after all the $from declarations:

            INNER JOIN mdl_quiz q ON qa.quiz = q.id
            INNER JOIN mdl_course c ON q.course = c.id
            INNER JOIN enrollments e ON c.idnumber = e.course_id AND u.idnumber = e.user_id

            Show
            Justin K. Reeve added a comment - This doesn't fix the issue for everyone, but here's a quick hack I did using a custom enrollments table that contains a user id, course id, and role. There's probably a better way to do this, but I inserted the following in /mod/quiz/overview/report.php:~354, after all the $from declarations: INNER JOIN mdl_quiz q ON qa.quiz = q.id INNER JOIN mdl_course c ON q.course = c.id INNER JOIN enrollments e ON c.idnumber = e.course_id AND u.idnumber = e.user_id
            Hide
            Tim Hunt added a comment -

            Just a note that this should be fixable in Moodle 2.0, now there is the new enrolments code. However, I am not familiar with that code yet, so I don't think I will have time to fix this before the 2.0 release. We should be able to fix it at some time on the 2.0 stable branch though.

            Show
            Tim Hunt added a comment - Just a note that this should be fixable in Moodle 2.0, now there is the new enrolments code. However, I am not familiar with that code yet, so I don't think I will have time to fix this before the 2.0 release. We should be able to fix it at some time on the 2.0 stable branch though.
            Hide
            Tim Hunt added a comment -

            This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

            For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            Show
            Tim Hunt added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: